Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: optional and intent(inout) attributes for glacier arrays #729

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

scrasmussen
Copy link
Member

TYPE: bug fix

KEYWORDS: Crocus, Glacier, Variable Attribute

SOURCE: Soren Rasmussen, NCAR

DESCRIPTION OF CHANGES: Changing Crocus glacier arrays from allocatable to optional. Allocated array glact was becoming unallocated upon entry to the readland_hrldas subroutine. Changing variable attribute to optional fixes this. Variable will never be allocated in the function so this is appropriate. Changing intent to inout also fixes this.

TESTS CONDUCTED: Builds and runs Huijie Glacier domain.

NOTES:

Checklist

  • Closes issue #xxxx (An issue must exist or be created to be closed. The issue describes and documents the problem and general solution, the PR describes the technical details of the solution.)
  • Tests added (unit tests and/or regression/integration tests)
  • Backwards compatible
  • Requires new files? If so, how to generate them.
  • Documentation included
  • Short description in the Development section of NEWS.md

@scrasmussen scrasmussen force-pushed the bugfix/optional-glacier-variables branch from ab5f128 to 5036a87 Compare February 23, 2024 23:20
@scrasmussen scrasmussen force-pushed the bugfix/optional-glacier-variables branch from 5036a87 to bbc22d9 Compare May 23, 2024 04:15
@scrasmussen scrasmussen force-pushed the bugfix/optional-glacier-variables branch from bbc22d9 to 2e8197a Compare June 5, 2024 15:59
@scrasmussen scrasmussen force-pushed the bugfix/optional-glacier-variables branch from 2e8197a to 21702ea Compare July 20, 2024 17:27
…out. Allocated array glact was becoming unallocated upon entry to the readland_hrldas subroutine cause it was intent(in). Changing variable attribute to optional fixes or changing intent to inout fixes this. Variable is allocated before and never in the function, so both are appropriate.
@scrasmussen scrasmussen force-pushed the bugfix/optional-glacier-variables branch from 21702ea to e92e478 Compare September 26, 2024 17:29
@scrasmussen scrasmussen merged commit 3dc1b88 into NCAR:main Sep 26, 2024
4 checks passed
@rcabell rcabell added this to the WRF-Hydro v5.4 milestone Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants