Skip to content

Add "isort:skip_file" directives to recipes #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

davidhassell
Copy link
Collaborator

pre-commit wants to reorder the imports in some of the recipe files, but due to the esmpy/shapely class we don't want this to happen - so we can add some "isort:skip_file" directives to the relevant Python recipe files.

See https://pycqa.github.io/isort/ for details.

@davidhassell davidhassell added the linting Related to linting tests label Apr 4, 2025
@davidhassell davidhassell added this to the NEXTVERSION milestone Apr 4, 2025
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, thanks for adding. Please merge.

@davidhassell davidhassell merged commit 747e7ed into NCAS-CMS:main Apr 4, 2025
1 of 3 checks passed
@davidhassell davidhassell deleted the recipes-isort branch April 4, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linting Related to linting tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants