Skip to content

Conversation

@bnlawrence
Copy link
Collaborator

@bnlawrence bnlawrence commented Oct 5, 2025

Description

Added support for opaque datasets, or at least those written by h5py. Would need some real test files written by someone else to check full support (but I am hopeful it would work).

Closes #88
Closes #70

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • Unit tests have been added (if codecov test fails)
  • Any changed dependencies have been added or removed correctly (if need be)
  • If you are working on the documentation, please ensure the current build passes
  • All tests pass

@bnlawrence bnlawrence requested a review from kmuehlbauer October 5, 2025 10:22
@codecov
Copy link

codecov bot commented Oct 5, 2025

Codecov Report

❌ Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.05%. Comparing base (c962394) to head (7cb0531).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
pyfive/datatype_msg.py 81.81% 1 Missing and 1 partial ⚠️
pyfive/h5t.py 88.88% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (90.32%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   73.32%   74.05%   +0.73%     
==========================================
  Files          11       11              
  Lines        2575     2598      +23     
  Branches      401      406       +5     
==========================================
+ Hits         1888     1924      +36     
+ Misses        580      565      -15     
- Partials      107      109       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@kmuehlbauer kmuehlbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bnlawrence This looks like a nice addition. I've added a couple comments and suggestions.

@bnlawrence bnlawrence mentioned this pull request Oct 7, 2025
21 tasks
Copy link
Collaborator

@kmuehlbauer kmuehlbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@valeriupredoi
Copy link
Collaborator

very many thanks @bnlawrence and @kmuehlbauer 🍻

@valeriupredoi valeriupredoi merged commit 8a44c01 into main Oct 7, 2025
5 of 6 checks passed
@valeriupredoi valeriupredoi deleted the opaque branch October 7, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Opaque Datatypes NotImplementedError: Opaque datatype class not supported after last commit

4 participants