-
Notifications
You must be signed in to change notification settings - Fork 24
Support for Opaque datasets #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…sting around edge cases, and the docuemenation, and should be done.
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (90.32%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 73.32% 74.05% +0.73%
==========================================
Files 11 11
Lines 2575 2598 +23
Branches 401 406 +5
==========================================
+ Hits 1888 1924 +36
+ Misses 580 565 -15
- Partials 107 109 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bnlawrence This looks like a nice addition. I've added a couple comments and suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
|
very many thanks @bnlawrence and @kmuehlbauer 🍻 |
Description
Added support for opaque datasets, or at least those written by h5py. Would need some real test files written by someone else to check full support (but I am hopeful it would work).
Closes #88
Closes #70
Checklist