Fix loop detection in object hierarchies #5053
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there were parent-child loops in the database, PostgreSQL would go into an infinite loop on our WITH RECURSIVE queries. Replace UNION ALL with simply UNION in these, as we don't need to know the depth; this makes PostgreSQL discard duplicates, and thus avoid infinite recursion.
When there were parent-child loops in the database, getAscendantObjectsAsList() would go into an infinite loop. Prevent this by adding loop detection, breaking the loop in such a case, and logging an error on the browser console and on the server.
gjvoosten
force-pushed
the
AB-1233-fix-loop-detection
branch
from
8555839 to
d04a4e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging organizations/locations, it was possible to create loops in the hierarchy. This is now prevented.
Also, in the case of (pre-existing) loops, PostgreSQL and the GUI client no longer go into an infinite recursion.
And if the GUI client detects a loop, an error is logged on the server.
Closes AB#1233
User changes
Superuser changes
Admin changes
System admin changes
Checklist
repo#issue: Titletitle format and these 7 rules