Skip to content

Pin searches to homepage #5216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

Pin searches to homepage #5216

wants to merge 40 commits into from

Conversation

jlnat
Copy link
Collaborator

@jlnat jlnat commented Jul 7, 2025 •
edited by gjvoosten
Loading

When saving a search, we now allow that search to be displayed on the homepage.
Additionally, the user can control the order in which the saved searches are displayed.

Closes AB#1383

User changes

  • User is able to display a saved search on the homepage
  • User is able to change the order of the searches on the homepage and saved searches page
  • User is able to view the saved searches details
  • User is able to change the visibility of the searches on the homepage on the saved searches page

Superuser changes

  • None

Admin changes

  • None

System admin changes

  • application.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • described the user behavior in PR body
  • referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • added and/or updated unit tests
  • added and/or updated e2e tests
  • added and/or updated data migrations
  • updated documentation
  • resolved all build errors and warnings
  • opened debt issues for anything not resolved here

@jlnat jlnat requested review from gjvoosten and midmarch July 7, 2025 10:46
@jlnat jlnat added the feature label Jul 7, 2025
gjvoosten
gjvoosten requested changes Jul 9, 2025
View reviewed changes
@gjvoosten gjvoosten force-pushed the AB-1383-pin-searches-to-homepage branch 4 times, most recently from e7e0168 to 4f10604 Compare July 9, 2025 13:37
gjvoosten
gjvoosten reviewed Jul 9, 2025
View reviewed changes
jlnat added 21 commits July 10, 2025 16:41
@jlnat @gjvoosten
AB#1383 Add displayInHomepage to SavedSearch
9073f67
@jlnat @gjvoosten
AB#1383 Allow to save a search with displayInHomepage
1dc2c63
@jlnat @gjvoosten
AB#1383 Display the searches name on the home page
8dedccf
@jlnat @gjvoosten
AB#1383 Display search results for each saved search
d890e17
@jlnat @gjvoosten
AB#1383 Refactor Search into separate SearchResult components
bcd9a0c
@jlnat @gjvoosten
AB#1383 Using new SearchResult components
dc69c77
@jlnat @gjvoosten
AB#1383 Fix issue with callback taking too long
d5dbf68
@jlnat @gjvoosten
AB#1383 Display the badge for the count
90cf1ca
@jlnat @gjvoosten
AB#1383 Display global search counts
aa671a2
@jlnat @gjvoosten
AB#1383 Add collapsible searches
8d83435
@jlnat @gjvoosten
AB#1383 Add showText to SearchDescription
f66c502
@jlnat @gjvoosten
AB#1383 Remove pagination on saved searches page
7cf2d8b
@jlnat @gjvoosten
AB#1383 Add priority value to saved searches
80af38e
@jlnat @gjvoosten
AB#1383 Add DraggableRow component
4e44f5a
@jlnat @gjvoosten
AB#1383 Use DraggableRow in Home page
b96c490
@jlnat @gjvoosten
AB#1383 Adapt DraggableRow to allow table rows
0eb56ae
@jlnat @gjvoosten
AB#1383 Use DraggableRow in SavedSearches page
cdaaf2b
@jlnat @gjvoosten
AB#1383 Allow changing displayInHomepage
e3aa9bd
@jlnat @gjvoosten
AB#1383 Add homepagePriority
c0b665f
@jlnat @gjvoosten
AB#1383 Remove pagination from report results
95ebbd8
@jlnat @gjvoosten
AB#1383 Update resourceTest
e65368e
jlnat and others added 17 commits July 10, 2025 16:41
@jlnat @gjvoosten
AB#1383 Fix issue with quick dragging
af74f3f
@jlnat @gjvoosten
AB#1383 Fix issue with quick dragging in savedSearches
73f91ef
@jlnat @gjvoosten
AB#1383 Improve drag performance
4035640
@jlnat @gjvoosten
AB#1383 Use smaller page size for counter request
d784928
@gjvoosten
AB#1383 Correctly update GraphQL schema
ca2f82b
@gjvoosten
AB#1383 Remove unused imports
222c004
@gjvoosten
AB#1383 Use simple defaultValue
37241e6
@gjvoosten
AB#1383 No need to show the new fields in toString
d2d1703
@gjvoosten
AB#1383 Call super for equals and hashCode
ae370be
@gjvoosten
AB#1383 Log delete of saved searches in the audit log
ee0e3a2
@gjvoosten
AB#1383 Simplify mySearches query
f4a1066
@gjvoosten
AB#1383 Simplify mapper
5a6d650
@gjvoosten
AB#1383 Add updatedAt column to saved searches
0c64075
@gjvoosten
AB#1383 Migrate existing saved searches
e715abe
@gjvoosten
AB#1383 Use a single SQL statement to set the priorities
752e28d
@gjvoosten
AB#1383 Simplify updates to saved searches
33fc7b4
@gjvoosten
AB#1383 Factor out common code for search results components
0fcc497
@gjvoosten gjvoosten force-pushed the AB-1383-pin-searches-to-homepage branch from b4e4b81 to 0fcc497 Compare July 10, 2025 14:41
@jlnat jlnat requested a review from gjvoosten July 14, 2025 14:21
gjvoosten
gjvoosten requested changes Jul 15, 2025
View reviewed changes
@jlnat jlnat force-pushed the AB-1383-pin-searches-to-homepage branch from c2b2450 to b72cdd2 Compare July 15, 2025 14:50
@jlnat jlnat force-pushed the AB-1383-pin-searches-to-homepage branch from b72cdd2 to d7592fd Compare July 15, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjvoosten gjvoosten gjvoosten requested changes

@midmarch midmarch Awaiting requested review from midmarch

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlnat @gjvoosten