Lint the whole collection and introduce a common style#223
Draft
Lint the whole collection and introduce a common style#223
Conversation
* add module x509 and mysql imports task * Add documentation for x509 module * Add documentation about database imports * Continues working on x509 module installation --------- Co-authored-by: Thilo W <[email protected]>
Adds docs on database setup
Member
|
I'll change here and there a few linter rules but yes sounds good. The Icinga 2 roles has more issues than the newer ones cause I started to lint the new code more often. |
Member
Author
|
I'll continue working on this then, and convert this to a proper PR once done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started fixing all warnings/errors that come up when you run
ansible-lint roles/from the repository's root directory.I will continue doing so, rebasing and force-pushing changes into the different categories (see commit messages). This way, we can revert a particular aspect of the linter if we feel the rules are too strict/weird/whatever.
Let me know what you think of this @mkayontour