FATES API refactor - BC to patch "direct" #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemieux
force-pushed
the
lnd/fates-bc-refactor-patch-direct
branch
from
1a338a0 to
c6c5b78
Compare
Remove rof_comp_esmf.F90 from MOSART. Never used.
Remove lnd_comp_esmf.F90 from ELM. Never used.
Remove atm_comp_esmf.F90 from EAM. Never used.
[BFB] for most resolutions (NE30, NE256, NE1024), may be CC for some tests
Use the newly installed ADIOS2 libraries under /ccs/proj/cli115 to avoid potential system enforced purges on /lustre/orion/cli115. [BFB]
Makes downstream code simpler
If ekat or eamxx's main CMakeLists change, it's probably a good idea to test
Remove cime_model=cesm options in namelist_definition_drv that will never be used. Should have no "cime_model" conditions. Also remove some NUOPC options. Fix a few comments.
…oject#7573) Add some binary arithmetics for EAMxx diags [BFB]
…roject#7605) EAMxx: fix scripts tests Fix issue in scripts tests following ekat update. [BFB]
In buildlib.spio, NCZarr support was previously detected using: netcdf4_nczarr_string = "NetCDF_C_HAS_NCZARR:BOOL=TRUE" On some machines like Perlmutter and Aurora, NCZarr is enabled by default in the NetCDF libraries, so this variable is always TRUE. This causes buildlib.spio to incorrectly assume that NCZarr support is enabled in SCORPIO. Since NCZarr support in SCORPIO is still experimental and disabled by default, detection should instead rely on the PIO_ENABLE_NCZARR configuration flag. Updated search string: netcdf4_nczarr_string = "PIO_ENABLE_NCZARR:BOOL=ON"
…adata_improvement
Remove code that is unused in both mct and moab drivers. We never used or tested NUOPC and NUOPC_TIGHT coupling sequence options so remove them from driver and namelist options. They were used by CESM while developing the NUOPC-based coupler. Remove test for (trim(cime_model) == 'e3sm') in seq_flds_mod.F90. This is always true. Remove cime_model=cesm options in namelist_definition_drv because its never true. Remove config_components_cesm.xml from driver/cime_config. This is never read. Remove HAVE_MOAB ifdefs from driver-moab. Also remove model_comp_esmf.F90 from EAM, ELM and MOSART. This never-used code is left over from an attempt to build a coupler with ESMF (before NUOPC existed). [BFB]
This will be handled by the fates site initialization routine
While the associated boundary condition is currently set with a min check against this and nlevsoil, this check should be moved inside fates
Since the max rooting depth is calculated using multiple bc_in variables, handle the logic on the fates side
This will be handle on the fates-side
These have moved into fates
… can/should take place during init_coldstart instead of init This will mostly be the non-global data type variables
Since we pass vert_soilc namelist tag, we can replace this init_soil_depths logic on the fates side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.