Make cold deciduous variables and parameters PFT-specific

main/EDInitMod.F90

@@ -53,6 +53,7 @@ module EDInitMod
   use EDTypesMod                , only : phen_dstat_moistoff
   use EDTypesMod                , only : phen_cstat_notcold
   use EDTypesMod                , only : phen_dstat_moiston
+  use EDTypesMod                , only : phen_estat_evergreen
   use FatesInterfaceTypesMod         , only : bc_in_type,bc_out_type
   use FatesInterfaceTypesMod         , only : hlm_use_planthydro
   use FatesInterfaceTypesMod         , only : hlm_use_inventory_init
@@ -264,20 +265,15 @@ subroutine zero_site( site_in )
 
     ! PHENOLOGY
 
-    site_in%cstatus          = fates_unset_int    ! are leaves in this pixel on or off?
-    site_in%dstatus(:)       = fates_unset_int
-    site_in%grow_deg_days    = nan  ! growing degree days
+    site_in%phen_status(:)   = fates_unset_int  ! are leaves in this pixel on or off?
+    site_in%grow_deg_days(:) = nan              ! growing degree days
     site_in%snow_depth       = nan
-    site_in%nchilldays       = fates_unset_int
-    site_in%ncolddays        = fates_unset_int
-    site_in%cleafondate      = fates_unset_int  ! doy of leaf on (cold)
-    site_in%cleafoffdate     = fates_unset_int  ! doy of leaf off (cold)
-    site_in%dleafondate(:)   = fates_unset_int  ! doy of leaf on (drought)
-    site_in%dleafoffdate(:)  = fates_unset_int  ! doy of leaf off (drought)
-    site_in%cndaysleafon     = fates_unset_int  ! days since leaf on (cold)
-    site_in%cndaysleafoff    = fates_unset_int  ! days since leaf off (cold)
-    site_in%dndaysleafon(:)  = fates_unset_int  ! days since leaf on (drought)
-    site_in%dndaysleafoff(:) = fates_unset_int  ! days since leaf off (drought)
+    site_in%nchilldays(:)    = fates_unset_int  ! number of chilling days
+    site_in%ncolddays(:)     = fates_unset_int  ! number of cold days
+    site_in%leafondate(:)    = fates_unset_int  ! doy of last leaf flushing event
+    site_in%leafoffdate(:)   = fates_unset_int  ! doy of last leaf abscission event
+    site_in%ndaysleafon(:)   = fates_unset_int  ! days since last leaf flushing
+    site_in%ndaysleafoff(: ) = fates_unset_int  ! days since last leaf abscission
     site_in%elong_factor(:)  = nan              ! Elongation factor (0 - full abscission; 1 - fully flushed)
 
     site_in%liqvol_memory(:,:)  = nan
@@ -396,6 +392,7 @@ subroutine set_site_properties( nsites, sites,bc_in )
     !
     ! !LOCAL VARIABLES:
     integer  :: s
+    integer  :: estat      ! evergreen phenology flag
     integer  :: cstat      ! cold status phenology flag
     real(r8) :: GDD
     integer  :: dstat      ! drought status phenology flag
@@ -427,44 +424,69 @@ subroutine set_site_properties( nsites, sites,bc_in )
 
     if ( hlm_is_restart == ifalse ) then
 
-       GDD      = 30.0_r8
-       cleafon  = 100
-       cleafoff = 300
+       GDD        = 30.0_r8
+       cleafon    = 100
+       cleafoff   = 300
        cndleafon  = 0
        cndleafoff = 0
-       cstat    = phen_cstat_notcold     ! Leaves are on
-       dstat    = phen_dstat_moiston     ! Leaves are on
-       dleafoff = 300
-       dleafon  = 100
+       estat      = phen_estat_evergreen
+       cstat      = phen_cstat_notcold     ! Leaves are on
+       dstat      = phen_dstat_moiston     ! Leaves are on
+       dleafoff   = 300
+       dleafon    = 100
        dndleafon  = 0
        dndleafoff = 0
        liqvolmem  = 0.5_r8 
        smpmem     = 0._r8
        elong_factor = 1._r8
 
        do s = 1,nsites
-          sites(s)%nchilldays    = 0
-          sites(s)%ncolddays     = 0        ! recalculated in phenology
+          sites(s)%nchilldays(1:numpft)    = 0
+          sites(s)%ncolddays(1:numpft)     = 0        ! recalculated in phenology
                                             ! immediately, so yes this
                                             ! is memory-less, but needed
                                             ! for first value in history file
           sites(s)%phen_model_date         = 0
-          sites(s)%cleafondate             = cleafon    - hlm_day_of_year
-          sites(s)%cleafoffdate            = cleafoff   - hlm_day_of_year
-          sites(s)%cndaysleafon            = cndleafon
-          sites(s)%cndaysleafoff           = cndleafoff
-          sites(s)%dleafoffdate (1:numpft) = dleafoff   - hlm_day_of_year
-          sites(s)%dleafondate  (1:numpft) = dleafon    - hlm_day_of_year
-          sites(s)%dndaysleafon (1:numpft) = dndleafon
-          sites(s)%dndaysleafoff(1:numpft) = dndleafoff
-          sites(s)%grow_deg_days   = GDD
+          sites(s)%grow_deg_days(1:numpft) = GDD
 
           sites(s)%liqvol_memory(1:numWaterMem,1:numpft) = liqvolmem
           sites(s)%smp_memory(1:numWaterMem,1:numpft) = smpmem
           sites(s)%vegtemp_memory(1:num_vegtemp_mem) = 0._r8
 
-          sites(s)%cstatus = cstat
-          sites(s)%dstatus(1:numpft) = dstat
+          do ft = 1, numpft
+             ! These must be updated once the new parameter is integrated to FATES.
+             select case (prt_params%evergreen(ft))
+             case (itrue)
+                ! Evergreens. These variables are not used, set them to any state
+                sites(s)%phen_status (ft) = estat
+                sites(s)%leafondate  (ft) = cleafon    - hlm_day_of_year
+                sites(s)%leafoffdate (ft) = cleafoff   - hlm_day_of_year
+                sites(s)%ndaysleafon (ft) = 0
+                sites(s)%ndaysleafoff(ft) = 0
+             end select
+
+             select case (prt_params%season_decid(ft))
+             case (itrue)
+                ! Cold deciduous
+                sites(s)%phen_status (ft) = cstat
+                sites(s)%leafondate  (ft) = cleafon    - hlm_day_of_year
+                sites(s)%leafoffdate (ft) = cleafoff   - hlm_day_of_year
+                sites(s)%ndaysleafon (ft) = cndleafon
+                sites(s)%ndaysleafoff(ft) = cndleafoff
+             end select
+
+
+             select case (prt_params%stress_decid(ft))
+             case (ihard_stress_decid,isemi_stress_decid)
+                ! Drought deciduous
+                sites(s)%phen_status (ft) = dstat
+                sites(s)%leafondate  (ft) = dleafon    - hlm_day_of_year
+                sites(s)%leafoffdate (ft) = dleafoff   - hlm_day_of_year
+                sites(s)%ndaysleafon (ft) = dndleafon
+                sites(s)%ndaysleafoff(ft) = dndleafoff
+             end select
+          end do
+
           sites(s)%elong_factor(1:numpft) = elong_factor
 
           sites(s)%NF         = 0.0_r8
@@ -1148,7 +1170,7 @@ subroutine init_cohorts(site_in, patch_in, bc_in)
                ! use built-in phenology
                phen_select: select case (prt_params%phen_leaf_habit(pft))
                case (ihard_season_decid)
-                  if ( any(site_in%cstatus == [phen_cstat_nevercold, phen_cstat_iscold]) ) then 
+                  if ( any(site_in%phen_status(pft) == [phen_cstat_nevercold, phen_cstat_iscold]) ) then 
                      ! Cold deciduous, off season, assume complete abscission
                      efleaf_coh = 0.0_r8
                      effnrt_coh = 1.0_r8 - fnrt_drop_fraction 

main/EDMainMod.F90

@@ -553,7 +553,7 @@ subroutine ed_integrate_state_variables(currentSite, bc_in, bc_out )
 
              ! Conduct Maintenance Turnover (parteh)
              if(debug) call currentCohort%prt%CheckMassConservation(ft,3)
-             if(any(currentSite%dstatus(ft) == [phen_dstat_moiston,phen_dstat_timeon])) then
+             if(any(currentSite%phen_status(ft) == [phen_dstat_moiston,phen_dstat_timeon])) then
                 is_drought = .false.
              else
                 is_drought = .true.

main/EDParamsMod.F90

@@ -52,13 +52,6 @@ module EDParamsMod
    real(r8),protected, public :: ED_val_cwd_fcel                      ! Cellulose fraction for CWD
    real(r8),protected, public :: ED_val_cwd_flig                      ! Lignin fraction of coarse woody debris
    real(r8),protected, public :: maintresp_nonleaf_baserate           ! Base maintenance respiration rate for plant tissues
-   real(r8),protected, public :: ED_val_phen_a                        ! GDD accumulation function, intercept parameter: gdd_thesh = a + b exp(c*ncd)
-   real(r8),protected, public :: ED_val_phen_b                        ! GDD accumulation function, multiplier parameter: gdd_thesh = a + b exp(c*ncd)
-   real(r8),protected, public :: ED_val_phen_c                        ! GDD accumulation function, exponent parameter: gdd_thesh = a + b exp(c*ncd)
-   real(r8),protected, public :: ED_val_phen_chiltemp                 ! chilling day counting threshold for vegetation
-   real(r8),protected, public :: ED_val_phen_mindayson                ! day threshold compared against days since leaves became on-allometry
-   real(r8),protected, public :: ED_val_phen_ncolddayslim             ! day threshold exceedance for temperature leaf-drop
-   real(r8),protected, public :: ED_val_phen_coldtemp                 ! vegetation temperature exceedance that flags a cold-day for leaf-drop
    real(r8),protected, public :: ED_val_cohort_size_fusion_tol        ! minimum fraction in difference in dbh between cohorts
    real(r8),protected, public :: ED_val_cohort_age_fusion_tol         ! minimum fraction in differece in cohort age between cohorts
    real(r8),protected, public :: ED_val_patch_fusion_tol              ! minimum fraction in difference in profiles between patches
@@ -141,13 +134,6 @@ module EDParamsMod
    character(len=param_string_length),parameter,public :: ED_name_cwd_fcel= "fates_frag_cwd_fcel"   
    character(len=param_string_length),parameter,public :: ED_name_cwd_flig= "fates_frag_cwd_flig"   
    character(len=param_string_length),parameter,public :: fates_name_maintresp_nonleaf_baserate= "fates_maintresp_nonleaf_baserate"
-   character(len=param_string_length),parameter,public :: ED_name_phen_a= "fates_phen_gddthresh_a"   
-   character(len=param_string_length),parameter,public :: ED_name_phen_b= "fates_phen_gddthresh_b"   
-   character(len=param_string_length),parameter,public :: ED_name_phen_c= "fates_phen_gddthresh_c"   
-   character(len=param_string_length),parameter,public :: ED_name_phen_chiltemp= "fates_phen_chilltemp"   
-   character(len=param_string_length),parameter,public :: ED_name_phen_mindayson= "fates_phen_mindayson"
-   character(len=param_string_length),parameter,public :: ED_name_phen_ncolddayslim= "fates_phen_ncolddayslim"   
-   character(len=param_string_length),parameter,public :: ED_name_phen_coldtemp= "fates_phen_coldtemp"   
    character(len=param_string_length),parameter,public :: ED_name_cohort_size_fusion_tol= "fates_cohort_size_fusion_tol"
    character(len=param_string_length),parameter,public :: ED_name_cohort_age_fusion_tol = "fates_cohort_age_fusion_tol"
    character(len=param_string_length),parameter,public :: ED_name_patch_fusion_tol= "fates_patch_fusion_tol"
@@ -310,13 +296,6 @@ subroutine FatesParamsInit()
     ED_val_cwd_fcel                       = nan
     ED_val_cwd_flig                       = nan
     maintresp_nonleaf_baserate            = nan
-    ED_val_phen_a                         = nan
-    ED_val_phen_b                         = nan
-    ED_val_phen_c                         = nan
-    ED_val_phen_chiltemp                  = nan
-    ED_val_phen_mindayson                 = nan
-    ED_val_phen_ncolddayslim              = nan
-    ED_val_phen_coldtemp                  = nan
     ED_val_cohort_size_fusion_tol         = nan
     ED_val_cohort_age_fusion_tol          = nan
     ED_val_patch_fusion_tol               = nan
@@ -422,27 +401,6 @@ subroutine FatesRegisterParams(fates_params)
     call fates_params%RegisterParameter(name=fates_name_maintresp_nonleaf_baserate, dimension_shape=dimension_shape_scalar, &
          dimension_names=dim_names_scalar)
 
-    call fates_params%RegisterParameter(name=ED_name_phen_a, dimension_shape=dimension_shape_scalar, &
-         dimension_names=dim_names_scalar)
-
-    call fates_params%RegisterParameter(name=ED_name_phen_b, dimension_shape=dimension_shape_scalar, &
-         dimension_names=dim_names_scalar)
-
-    call fates_params%RegisterParameter(name=ED_name_phen_c, dimension_shape=dimension_shape_scalar, &
-         dimension_names=dim_names_scalar)
-
-    call fates_params%RegisterParameter(name=ED_name_phen_chiltemp, dimension_shape=dimension_shape_scalar, &
-         dimension_names=dim_names_scalar)
-
-    call fates_params%RegisterParameter(name=ED_name_phen_mindayson, dimension_shape=dimension_shape_scalar, &
-         dimension_names=dim_names_scalar)
-
-    call fates_params%RegisterParameter(name=ED_name_phen_ncolddayslim, dimension_shape=dimension_shape_scalar, &
-         dimension_names=dim_names_scalar)
-
-    call fates_params%RegisterParameter(name=ED_name_phen_coldtemp, dimension_shape=dimension_shape_scalar, &
-         dimension_names=dim_names_scalar)
-
     call fates_params%RegisterParameter(name=ED_name_cohort_size_fusion_tol, dimension_shape=dimension_shape_scalar, &
          dimension_names=dim_names_scalar)
 
@@ -632,27 +590,6 @@ subroutine FatesReceiveParams(fates_params)
     call fates_params%RetrieveParameter(name=fates_name_maintresp_nonleaf_baserate, &
          data=maintresp_nonleaf_baserate)
 
-    call fates_params%RetrieveParameter(name=ED_name_phen_a, &
-         data=ED_val_phen_a)
-
-    call fates_params%RetrieveParameter(name=ED_name_phen_b, &
-         data=ED_val_phen_b)
-
-    call fates_params%RetrieveParameter(name=ED_name_phen_c, &
-         data=ED_val_phen_c)
-
-    call fates_params%RetrieveParameter(name=ED_name_phen_chiltemp, &
-         data=ED_val_phen_chiltemp)
-
-    call fates_params%RetrieveParameter(name=ED_name_phen_mindayson, &
-         data=ED_val_phen_mindayson)
-
-    call fates_params%RetrieveParameter(name=ED_name_phen_ncolddayslim, &
-         data=ED_val_phen_ncolddayslim)
-
-    call fates_params%RetrieveParameter(name=ED_name_phen_coldtemp, &
-         data=ED_val_phen_coldtemp)
-
     call fates_params%RetrieveParameter(name=ED_name_cohort_size_fusion_tol, &
          data=ED_val_cohort_size_fusion_tol)
 
@@ -832,13 +769,6 @@ subroutine FatesReportParams(is_master)
         write(fates_log(),fmt0) 'ED_val_cwd_fcel = ',ED_val_cwd_fcel
         write(fates_log(),fmt0) 'ED_val_cwd_flig = ',ED_val_cwd_flig
         write(fates_log(),fmt0) 'fates_maintresp_nonleaf_baserate = ', maintresp_nonleaf_baserate
-        write(fates_log(),fmt0) 'ED_val_phen_a = ',ED_val_phen_a
-        write(fates_log(),fmt0) 'ED_val_phen_b = ',ED_val_phen_b
-        write(fates_log(),fmt0) 'ED_val_phen_c = ',ED_val_phen_c
-        write(fates_log(),fmt0) 'ED_val_phen_chiltemp = ',ED_val_phen_chiltemp
-        write(fates_log(),fmt0) 'ED_val_phen_mindayson = ',ED_val_phen_mindayson
-        write(fates_log(),fmt0) 'ED_val_phen_ncolddayslim = ',ED_val_phen_ncolddayslim
-        write(fates_log(),fmt0) 'ED_val_phen_coldtemp = ',ED_val_phen_coldtemp
         write(fates_log(),fmt0) 'ED_val_cohort_size_fusion_tol = ',ED_val_cohort_size_fusion_tol
         write(fates_log(),fmt0) 'ED_val_cohort_age_fusion_tol = ',ED_val_cohort_age_fusion_tol
         write(fates_log(),fmt0) 'ED_val_patch_fusion_tol = ',ED_val_patch_fusion_tol