Skip to content

Conversation

@maritsandstad
Copy link

Fixing comments on units in FatesInterfaceTypesMod.f90 that are wrong and therefore confusing

Description:

Unit description in FatesInterfaceTypesMod.f90 for fire_closs_to_atm_si says

! Loss of carbon to atmosphere via burning (includes burning from land use change) [Site-Level, gC m-2 s-1]

However, where it is being calculated in EdPatchDynamicsMod.f90 the unit is clearly in kg [Site-Level, kgC m-2 s-1]

This causes confusion, and so some further investigation for other variables like grazing_closs_to_atm_si is also warrented... It might also be that one should check whether this is kg total mass or kg Carbon and some other conversion factors are needed...

Collaborators:

@rosiealice , @mvdebolskiy

Expectation of Answer Changes:

No answers changing so far, just fixing confusing comments

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided
  • FATES-CLM6 Code Freeze: satellite phenology regression tests are b4b

If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

rosiealice and others added 30 commits April 1, 2024 10:05
Bring noresm branch up to dates with FATES main.
fix logical for ci of gnu compiler
rosiealice and others added 25 commits May 20, 2025 18:19
Update default fates cdl parameter file to NorESM3b1 version
@glemieux
Copy link
Contributor

@maritsandstad, @rgknox said he'll incorporate this into #1473.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

8 participants