-
Notifications
You must be signed in to change notification settings - Fork 105
Maritsandstad fix unit confusion comment #1474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
maritsandstad
wants to merge
82
commits into
NGEET:main
from
NorESMhub:maritsandstad-fix-unit-confusion-comment
Closed
Maritsandstad fix unit confusion comment #1474
maritsandstad
wants to merge
82
commits into
NGEET:main
from
NorESMhub:maritsandstad-fix-unit-confusion-comment
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring noresm branch up to dates with FATES main.
Megan fates update
…ase to fluxes for BETs
fix logical for ci of gnu compiler
Update to api 40.0.0
Nbp nobalancecheck
Update default fates cdl parameter file to NorESM3b1 version
Co-authored-by: Rosie Fisher <[email protected]>
…-v25 Updating parameterfile
… of EDPatchDynamicsMod
|
@maritsandstad, @rgknox said he'll incorporate this into #1473. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing comments on units in FatesInterfaceTypesMod.f90 that are wrong and therefore confusing
Description:
Unit description in FatesInterfaceTypesMod.f90 for fire_closs_to_atm_si says
! Loss of carbon to atmosphere via burning (includes burning from land use change) [Site-Level, gC m-2 s-1]However, where it is being calculated in EdPatchDynamicsMod.f90 the unit is clearly in kg [Site-Level, kgC m-2 s-1]
This causes confusion, and so some further investigation for other variables like grazing_closs_to_atm_si is also warrented... It might also be that one should check whether this is kg total mass or kg Carbon and some other conversion factors are needed...
Collaborators:
@rosiealice , @mvdebolskiy
Expectation of Answer Changes:
No answers changing so far, just fixing confusing comments
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: