[WIP] Edge forest flammability enhancements #1483
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add FatesEcotypesMod with is_patch_forest() function. Updates new Patch logical is_forest based on tree fraction, immediately after total_tree_area is updated. Set up for adding IS_FOREST outputs based on grass biomass. (cherry picked from commit 7ee78b4dc44d31eecbd9e98cde264392131bf93d)
Add parameter file fates_params_shuman24.cdl. As fates_params_default.cdl, but with only: - broadleaf_evergreen_tropical_tree - broadleaf_hydrodecid_tropical_tree - c4_grass Change shuman24 PFT names and some values. More changes based on Shuman et al. (2024) Table 2. Add params from fates_params_sci.1.45.0_api.15.0.0.cdl, for ref. Add Jackie's parameter file, for reference. Add fates_params_shuman24.20240819.cdl (just extracted PFTs). Apply Jackie's parameter file changes. To fates_params_shuman24.20240819.cdl. Minimal changes that match her CHANGES, not her VALUES. (cherry picked from commit 6151cd9bd255e8c82ea572bde39d6742b9ae09c7)
- FATES_AREA_PLANTS_AP - FATES_AREA_TREES_AP - FATES_IS_FOREST - FATES_IS_FOREST_AP - FATES_IS_FOREST_PCT10 - FATES_IS_FOREST_PCT10_0GRASS - FATES_IS_FOREST_PCT25 - FATES_IS_FOREST_PCT25_0GRASS - FATES_IS_FOREST_PCT50 - FATES_IS_FOREST_PCT50_0GRASS - FATES_IS_FOREST_PCT75 - FATES_IS_FOREST_PCT75_0GRASS - FATES_IS_FOREST_PCT90 - FATES_IS_FOREST_PCT90_0GRASS
Uses new dimension, site x fates_levedgebin.
Global 4x5 test of this change (on a different branch): Results in absolute differences in bin area of < 0.0001 m2 in any given gridcell. Total sum of abs. differences < 0.22 m2.
This reverts commit ecf7ec1.
…nterfaceMod." This reverts commit 54e543d.
This reverts commit d3cd1d4.
…HistoryInterfaceMod."" This reverts commit b1858ab.
It's actually now defined in EDParamsMod so it can be read from the parameter file. This instance was left over from the move to the parameter file.
This should be impossible because they all use the same netCDF dimension.
New sapwood, agb and leaf allometries for Grasses, by Xiulin Gao.
Patch level memory structures were refactor to be dynamic, paving the way for higher nclmax. # Conflicts: # biogeochem/FatesPatchMod.F90
Fire-weather refactor (non-bfb) This moves the effective wind speed and associated methods into the site-level fire weather class. When merging into edge-area-202410: Had added "currentPatch%is_forest = is_patch_forest()" and "call calculate_edge_area()" to subroutine wind_effect. These are now in subroutine CalculateTreeGrassAreaSite.
Changes the patch insertion method This update changes the patch ordering method to account for landuse and no comp pft label as well as patch age.
… change intended.
This was an attempt to resolve unexpected matching fireWeather in deep forest and other forest when edge flammability enhancement was requested. Didn't work.
This was another failed attempt to resolve unexpected matching fireWeather in deep forest and other forest when edge flammability enhancement was requested.
samsrabin
added
type: enhancement
science: fire
parameters: new
github-project-automation
bot
moved this to Finding Reviewers
in FATES Pull Request Planning and Status
samsrabin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR will remain a draft/WIP until scientific testing has been performed.
This PR builds upon #1432, which added diagnostic tracking of how much forest was in each "bin" of distance from nonforest "edge." (Note that unless and until that PR is merged, the diffs on this PR will include the diffs from that one as well.) Here, I add the option to enhance flammability based on edge bin, so that near-edge forest can have higher temperature, lower relative humidity, and higher wind speed. (Note that these ONLY apply for flammability calculations.) This can be done by both additive and multiplicative factors.
The way this is manifested in the model is by having each patch get its own fire weather, rather than each site. Forest patches can have area in multiple bins, so their actual fire weather will be an area-weighted average of each bin's fire weather.
The default parameter file contains all the new required parameters, but with no flammability enhancement.
fates_params_edgeflam.cdlsets it so that all but "deep forest" (farthest from edge) will get +2°C, –30 p.p. RH, and +11% wind speed, based on data and literature review by @menglinmet.Collaborators:
@menglinmet, @ckoven, @mpaiao
Expectation of Answer Changes:
Only if using flammability enhancement parameters (additive factors ≠ 0 and/or multiplicative factors ≠ 1) with
hlm_use_edge_foresttrue.Checklist
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: