Skip to content

Conversation

@ckoven
Copy link
Contributor

@ckoven ckoven commented Oct 10, 2025

This PR adds a few variables that I wanted to use for the TRENDY runs and/or global calibration.

Description:

These new variables include:

  • FATES_MEAN_95PCTILE_HEIGHT: calculates a gridcell-level height that is the average across all patcehs of the 95th percentile height. In discussions with @mpaiao, @JessicaNeedham and others, we decided this might be the closest approximation to a spaceborne or airborne lidar-derived metric
  • FATES_FIRE_CLOSS_LIVEFUELS: fire carbonloss from live fuels only
  • FATES_FIRE_CLOSS_LANDUSECHANGE: fire carbon loss associated with land use change ony (to allow separation of anthropogenic fire and wildfire fluxes, and thus allow calculation of a land-use-change carbon flux)
  • FATES_SECONDARY_AGB_ANTHROAGE_AP: The secondary aboveground biomass, resolved by age since anthropogenic disturbance. This is to allow comparison against observed secondary biomass regrowth curves.

In the interest of cleanup, this PR also gets rid of a few history variables:

  • FATES_PRIMARY_AREA: we don't need this anymore because we have FATES_PATCHAREA_LU which is the area of each land use type (and thus contains this info)
  • FATES_SECONDARY_AREA: ditto above
  • FATES_SECONDARY_AREA_ANTHRO: this variable as written didn't make sense, the correct variable with this info is FATES_SECONDARY_AREA_ANTHRO_AP

Collaborators:

@mpaiao, @JessicaNeedham

Expectation of Answer Changes:

should not be answer-changing except for the different variables (though perhaps roundoff level changes to fire and downstream fluxes like NBP because order of operations changed?)

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided
  • FATES-CLM6 Code Freeze: satellite phenology regression tests are b4b

If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.

Documentation

Test Results:

Not yet tested here. I cherry-picked all of these from my working branch, so it is possible there are conflicts that I didn't catch.

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@glemieux
Copy link
Contributor

@rgknox to review wrt potential conflicts with the mass balance PR #1473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

output: diagnostics software: history output Pertaining to FATES history output variables

Projects

Status: Finding Reviewers

Development

Successfully merging this pull request may close these issues.

2 participants