-
Notifications
You must be signed in to change notification settings - Fork 0
Thread yunhwa #44
base: main
Are you sure you want to change the base?
Thread yunhwa #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
접근제어자를 추가하면 좋을 것 같습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main에서 Consumer를 Interrupt를 해줄 때 결과 값에 중지합니다가 뜬 후에 물건 판매완료와 퇴장하는 결과값이 나오는 의도로 하신 이유가 있을까여?? deadlock이 걸릴 가능성을 생각하셔서 하신건가용?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
접근제어자를 달아 주시면 좋을 것 같습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parkminsu code review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
다음엔 반복문을 활용해보세요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
접근제어자를 default로 해주신 이유가 있을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 자료형의 필요성에 대해 생각하게 됩니다
add를 하지만 pop을 하지 않으니 queue여야 하는 이유가 있을까요
Thread를 순차적으로 깨워주기 위해서라기엔 이 자료형이 비어있을 때 모든 쓰레드를 notifyAll하는 구조이고... 만약 이 의도대로라면 pop을 하고, 그 자료형을 깨워주는 식으로 하면 어떨까싶습니다
실제로 구현될 지는 미지수지만요
과제 - 문제 2: semaphore 은 아직 풀지 못한 관계로 제외하고 코드리뷰 부탁드립니다!