Ci/setup fastlane #1219

limwa · 2024-04-02T09:37:58Z

Closes #506

Sets up fastlane for the CI.

Setup fastlane on Android.
Setup fastlane on iOS.
Setup CI to use fastlane.
Add build instructions.

Review checklist

Terms and conditions reflect the current change
Contains enough appropriate tests
If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
Properly adds an entry in changelog.md with the change
If PR includes UI updates/additions, its description has screenshots
Behavior is as expected
Clean, well-structured code

limwa · 2024-04-02T09:39:36Z

----------------------
--- fastlane lanes ---
----------------------
fastlane uses a `Fastfile` to store the automation configuration
Within that, you'll see different lanes.
Each is there to automate a different task, like screenshots, code signing, or pushing new releases
Continue by pressing Enter ⏎

--------------------------------------
--- How to customize your Fastfile ---
--------------------------------------
Use a text editor of your choice to open the newly created Fastfile and take a look
You can now edit the available lanes and actions to customize the setup to fit your needs
To get a list of all the available actions, open https://docs.fastlane.tools/actions
Continue by pressing Enter ⏎

------------------------------
--- Where to go from here? ---
------------------------------
📸  Learn more about how to automatically generate localized Google Play screenshots:
            https://docs.fastlane.tools/getting-started/android/screenshots/
👩‍✈️  Learn more about distribution to beta testing services:
            https://docs.fastlane.tools/getting-started/android/beta-deployment/
🚀  Learn more about how to automate the Google Play release process:
            https://docs.fastlane.tools/getting-started/android/release-deployment/

To try your new fastlane setup, just enter and run
$ fastlane test

codecov · 2024-04-02T09:43:37Z

Codecov Report

Merging #1219 (2c6d504) into develop (9cbaa3e) will decrease coverage by 0%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##           develop   #1219   +/-   ##
=======================================
- Coverage       17%     17%   -0%     
=======================================
  Files          229     229           
  Lines         6986    6986           
=======================================
- Hits          1150    1149    -1     
- Misses        5836    5837    +1

DGoiana

Before approval, I need to run pod install in order to create a new updated Podfile.lock

bdmendes · 2024-04-03T09:32:30Z

@limwa does fastlane support changing store descriptions, e.g. screenshots? That's awesome.

limwa · 2024-04-03T10:10:53Z

@limwa does fastlane support changing store descriptions, e.g. screenshots? That's awesome.

Yes, it does! Updating descriptons and screenshots should be done through fastlane once this PR is merged!

bdmendes · 2024-04-03T13:26:37Z

uni/ios/fastlane/Fastfile

+    increment_build_number(xcodeproj: "Runner.xcodeproj")
+    commit_version_bump(xcodeproj: "Runner.xcodeproj")


Double-check how this overrides/replaces our current versioning schema

bartekpacia · 2024-04-17T13:29:49Z

uni/.bundle/config

+---
+BUNDLE_SET: "path ./vendor/bundle"


what is this for?

bartekpacia · 2024-04-17T13:30:07Z

uni/.gitignore

@@ -128,3 +128,6 @@ app.*.symbols

 # Flutter Devtools
 devtools_options.yaml
+
+# Google Service Account Key
+/android/google-service-account-key.json


trailing newline :-P

bartekpacia · 2024-06-26T21:36:35Z

I'd consider setting up Fastlane once, instead of twice (for Android and iOS).

In my previous projects (at companies & personal ones), Fastlane was always being set up twice, but I'm wondering if if we do it once, it'll be better.

The main con of the current approach is that when updating Fastlane, everything has to be done twice (for no good reason). And then there's also duplication.

In other words, I suggest:

├── lib/
├── android/
├── ios/
├── fastlane/
│   ├── Gemfile
│   ├── Gemfile.lock
│   └── fastlane/
│       ├── Appfile
│       ├── Fastfile
│       ├── Matchfile
│       ├── Pluginfile

instead of:

├── lib/
├── android/
│   ├── Gemfile
│   ├── Gemfile.lock
│   └── fastlane/
│       ├── Appfile
│       ├── Fastfile
│       ├── Matchfile
├── ios/
│   ├── Gemfile
│   ├── Gemfile.lock
│   └── fastlane/
│       ├── Appfile
│       ├── Fastfile
│       ├── Matchfile

Fastlane is very much configurable, so I'm pretty sure we can make this setup work. Rn I'm in the process of trying it out in a personal project of mine (https://github.com/bartekpacia/opencaching), when I finish I can get back to you with the results.

limwa · 2024-06-26T21:41:07Z

@bartekpacia the reason it is done this way is because it is the recommended way in the documentation
I'm not sure about using only a single fastlane installation, it would still need to be duplicated in the Fastfile because some steps are not supported in Android, but are in iOS, or vice-versa

bartekpacia · 2024-06-26T21:50:19Z

it would still need to be duplicated in the Fastfile because some steps are not supported in Android, but are in iOS, or vice-versa

This doesn't really matter, you can have iOS-specific and Android-specific steps in a single Fastfile, e.g.:

platform :android do
  desc 'Upload a new Android testing build to Google Play'
  lane :deploy_tst do
    # ...
  end
end

platform :ios do
  desc 'Upload a new iOS testing build to TestFlight'
  lane :deploy_tst do
    # ...
  end
end

The above could be run with:

bundle exec fastlane trigger android deploy_tst
# or
bundle exec fastlane trigger ios deploy_tst

bartekpacia · 2024-06-26T21:53:46Z

Another good idea is to use a Ruby linter for to use for Fastfiles – Rubocop. I can help with setup, it's pretty simple anyway:)

limwa · 2024-06-26T21:56:39Z

That is my point, although the lanes are all in one file, most of them will still need to have an android and ios variants. I'll see what is possible in this regard, but since the two-fastlane approach is the recommended one, I'm inclined to sticking by it (since it is better for the future maintainability of the project - more people will more easily understand what is going on)

bartekpacia · 2024-06-26T22:02:27Z

Sure, I see you and understand the preference for going with the docs.

thePeras · 2024-06-26T21:50:35Z

uni/ios/fastlane/metadata/pt-PT/privacy_url.txt

@@ -0,0 +1 @@
+https://tiago-falves.github.io/UNI-Privacy-Policy/


Should this be a niaefeup link?

Maybe... It certainly would look more professional!

thePeras · 2024-06-26T21:50:50Z

uni/ios/fastlane/metadata/pt-PT/subtitle.txt

@@ -0,0 +1 @@
+A FEUP no teu bolso


We need to change that, for sure

thePeras · 2024-06-26T21:51:17Z

uni/ios/fastlane/metadata/pt-PT/support_url.txt

@@ -0,0 +1 @@
+https://github.com/NIAEFEUP/project-schrodinger/issues


~~project-schrodinger~~

thePeras · 2024-06-26T21:51:29Z

uni/ios/fastlane/metadata/review_information/demo_password.txt

@@ -0,0 +1 @@
+testeteste123!


uni/ios/fastlane/metadata/review_information/demo_user.txt

uni/ios/fastlane/metadata/review_information/phone_number.txt

limwa added 2 commits April 2, 2024 10:20

ci: install fastlane

abfe25a

ci: setup Android fastlane project

45e9f69

ci: move gemfile to project root

1566d85

limwa and others added 3 commits April 2, 2024 16:19

ci: setup supply for android

450263a

ci: add fastlane for ios

fc91ff4

setting up fastlane

2c6d504

DGoiana requested changes Apr 2, 2024

View reviewed changes

bdmendes reviewed Apr 3, 2024

View reviewed changes

bartekpacia reviewed Apr 17, 2024

View reviewed changes

thePeras reviewed Jun 26, 2024

View reviewed changes

bartekpacia mentioned this pull request Jun 28, 2024

Use a single-installation Fastlane bartekpacia/spitfire#23

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ci/setup fastlane #1219

Ci/setup fastlane #1219

limwa commented Apr 2, 2024 •

edited by DGoiana

Loading

limwa commented Apr 2, 2024

codecov bot commented Apr 2, 2024 •

edited

Loading

DGoiana left a comment

bdmendes commented Apr 3, 2024

limwa commented Apr 3, 2024

bdmendes Apr 3, 2024

bartekpacia Apr 17, 2024

bartekpacia Apr 17, 2024

bartekpacia commented Jun 26, 2024 •

edited

Loading

limwa commented Jun 26, 2024

bartekpacia commented Jun 26, 2024 •

edited

Loading

bartekpacia commented Jun 26, 2024

limwa commented Jun 26, 2024

bartekpacia commented Jun 26, 2024

thePeras Jun 26, 2024

limwa Jun 26, 2024

thePeras Jun 26, 2024

thePeras Jun 26, 2024

thePeras Jun 26, 2024

		increment_build_number(xcodeproj: "Runner.xcodeproj")
		commit_version_bump(xcodeproj: "Runner.xcodeproj")

		@@ -0,0 +1 @@
		https://tiago-falves.github.io/UNI-Privacy-Policy/

		@@ -0,0 +1 @@
		https://github.com/NIAEFEUP/project-schrodinger/issues

		@@ -0,0 +1 @@
		testeteste123!

Ci/setup fastlane #1219

Are you sure you want to change the base?

Ci/setup fastlane #1219

Conversation

limwa commented Apr 2, 2024 • edited by DGoiana Loading

Review checklist

limwa commented Apr 2, 2024

codecov bot commented Apr 2, 2024 • edited Loading

Codecov Report

DGoiana left a comment

Choose a reason for hiding this comment

bdmendes commented Apr 3, 2024

limwa commented Apr 3, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bartekpacia commented Jun 26, 2024 • edited Loading

limwa commented Jun 26, 2024

bartekpacia commented Jun 26, 2024 • edited Loading

bartekpacia commented Jun 26, 2024

limwa commented Jun 26, 2024

bartekpacia commented Jun 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

limwa commented Apr 2, 2024 •

edited by DGoiana

Loading

codecov bot commented Apr 2, 2024 •

edited

Loading

bartekpacia commented Jun 26, 2024 •

edited

Loading

bartekpacia commented Jun 26, 2024 •

edited

Loading