-
Notifications
You must be signed in to change notification settings - Fork 19
Redesign/translations #1482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Redesign/translations #1482
Conversation
|
The "BEIC" problem is not from here, should we fix it here? I don't think the goal now, we can live with that and fix later, my opinion |
|
The BEIC problem happens because the way we're getting the accronym is through regex. I don't personally think is a big deal, the way to solve this would be through an api or somehow changing the fetcher to give us that info |
Exactly, the fix seems complex, so ignore it that for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (6)
- packages/uni_app/lib/controller/fetchers/course_units_fetcher/all_course_units_fetcher.dart: Language not supported
- packages/uni_app/lib/controller/fetchers/course_units_fetcher/course_units_info_fetcher.dart: Language not supported
- packages/uni_app/lib/controller/fetchers/course_units_fetcher/current_course_units_fetcher.dart: Language not supported
- packages/uni_app/lib/controller/fetchers/courses_fetcher.dart: Language not supported
- packages/uni_app/lib/controller/networking/network_router.dart: Language not supported
- packages/uni_app/lib/view/academic_path/courses_page.dart: Language not supported
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (60%) is below the target coverage (70%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #1482 +/- ##
=======================================
Coverage 60% 60%
=======================================
Files 2 2
Lines 81 81
=======================================
Hits 48 48
Misses 33 33 🚀 New features to boost your workflow:
|
pedroafmonteiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for reviewing this so late! Here's what I found:
- The "Agora" or "Now" text below the course abbreviation is not appearing at all on my end.
- If the user changes the language in the app settings, this page still displays with the old language, requiring a manual page reload. This is probably not that big of a deal, because users normally stick to a specific language when they install the app, but I think it's worth seeing nonetheless!
Closes #1461
Some notes:
Review checklist
whatsnew/whatsnew-pt-PTchangelog.mdwith the change