Skip to content

Conversation

@Adriano-7
Copy link
Member

@Adriano-7 Adriano-7 commented Feb 19, 2025

Closes #1461

Some notes:

  • This PR fixes the translation of courses and course_units
  • The calendar and the schedule links break when the page is /en, that's why i use the languageSensitive condition
  • The course unit sheet is still in portuguese eventhough the link is /en because the link we're using returns the info in portuguese
  • There's a problem with the abbreviation of finished courses (see the TODO). LEIC it appears as BICE

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@Adriano-7 Adriano-7 linked an issue Feb 19, 2025 that may be closed by this pull request
@Adriano-7 Adriano-7 requested review from DGoiana and thePeras and removed request for thePeras March 1, 2025 15:08
@Adriano-7 Adriano-7 changed the base branch from develop to ui/redesign March 1, 2025 15:10
@thePeras
Copy link
Member

The "BEIC" problem is not from here, should we fix it here? I don't think the goal now, we can live with that and fix later, my opinion

@Adriano-7
Copy link
Member Author

The BEIC problem happens because the way we're getting the accronym is through regex. I don't personally think is a big deal, the way to solve this would be through an api or somehow changing the fetcher to give us that info

@thePeras
Copy link
Member

hould we fix it here? I don't think the goal now, we can live with that and fix later, my opinion

Exactly, the fix seems complex, so ignore it that for now

@Adriano-7 Adriano-7 requested a review from Copilot March 27, 2025 21:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (6)
  • packages/uni_app/lib/controller/fetchers/course_units_fetcher/all_course_units_fetcher.dart: Language not supported
  • packages/uni_app/lib/controller/fetchers/course_units_fetcher/course_units_info_fetcher.dart: Language not supported
  • packages/uni_app/lib/controller/fetchers/course_units_fetcher/current_course_units_fetcher.dart: Language not supported
  • packages/uni_app/lib/controller/fetchers/courses_fetcher.dart: Language not supported
  • packages/uni_app/lib/controller/networking/network_router.dart: Language not supported
  • packages/uni_app/lib/view/academic_path/courses_page.dart: Language not supported

@Adriano-7 Adriano-7 marked this pull request as ready for review August 4, 2025 16:44
@Adriano-7 Adriano-7 self-assigned this Aug 4, 2025
@Adriano-7 Adriano-7 changed the base branch from ui/redesign to develop August 4, 2025 17:07
@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60%. Comparing base (b826e54) to head (fd96a49).
⚠️ Report is 1 commits behind head on develop.

❌ Your project check has failed because the head coverage (60%) is below the target coverage (70%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1482   +/-   ##
=======================================
  Coverage       60%     60%           
=======================================
  Files            2       2           
  Lines           81      81           
=======================================
  Hits            48      48           
  Misses          33      33           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@pedroafmonteiro pedroafmonteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for reviewing this so late! Here's what I found:

  • The "Agora" or "Now" text below the course abbreviation is not appearing at all on my end.
  • If the user changes the language in the app settings, this page still displays with the old language, requiring a manual page reload. This is probably not that big of a deal, because users normally stick to a specific language when they install the app, but I think it's worth seeing nonetheless!

@pedroafmonteiro pedroafmonteiro requested a review from a team November 14, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle translations

5 participants