-
Notifications
You must be signed in to change notification settings - Fork 19
fix: better way to represent classes on the home page card #1715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Note: i noticed a bug when using the lectures that are scraped off sigarra, that when a lecture happened today, regardless of it ending or not, it will appear. For example today I had RCOM from 8:30 AM - 10:30 AM, it's now 10:14 PM, the message appears saying I have no more classes today however that said class that has already ended appears on my schedule. Will investigate what's wrong later on |
|
Hi! Just a heads up on this PR after reviewing with the team on the latest meeting, I think the icon should be changed to a beer icon instead of the sun to keep consistency. |
Okay, good point. I will change it to mantain the visual consistency. |
4179140 to
899aed9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (60%) is below the target coverage (70%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #1715 +/- ##
=======================================
Coverage 60% 60%
=======================================
Files 2 2
Lines 81 81
=======================================
Hits 48 48
Misses 33 33 🚀 New features to boost your workflow:
|
|
Hi! While testing I noticed something. At the moment is friday night, meaning I don't have any more classes today or this week. However it's showing me my classes for monday. Is this how it is supposed to be? maybe only show the next week classes on sunday, what do you think? |
Yes, I thought the idea would be to only display the "You don't have any more classes this week", if I had no classes planned in the next 7 days. I could make it so it displays that message as soon as the week is "over" but I don't see why it would be beneficial to only display monday's classes on sunday in this case. |

Closes #1624
As a way to improve the user experience while using UNI, the way the schedule section of the homepage functioned was changed. Instead of always showing the next two classes, regardless if they are today, tommorow or in a week, a new message appears on top of the schedule card, that states if the user has no more classes for that day and what the day of the week the user's next class is. Also, if the user's next two classes are on different days, only the next class will show up.
For the sake of testing, new mock lectures were added in order to see how the code works. Naturally, these will be removed.
Here are a few of said test cases:
Both classes are today
Only one of the users classes is today
The user's next classes are tomorrow
One of the user's classes is 3 days from now, the other is more than a week from now
Note: this was written on a tuesday.
No more classes this week
Review checklist
View Changes
Performance