Feature/recovery email #225

rubuy-74 · 2025-04-22T15:35:14Z

Closes #171
Closes #140

Integrates the email service with the recover password functionality.

The email message looks like this:

Review checklist

Behavior is as expected
Clean, well structured code
Properly documents API changes in the corresponding controller test
Contains enough appropriate tests
Changes are reflected in the Wiki if necessary

…ctivity)

github-actions · 2025-04-22T15:50:17Z

Check the documentation preview: https://6807bab7ab7865223fe5bdfa--niaefeup-backend-docs.netlify.app

github-actions · 2025-04-22T18:22:01Z

Check the documentation preview: https://6807de46053c504e8c4ad324--niaefeup-backend-docs.netlify.app

github-actions · 2025-06-27T17:55:18Z

Check the documentation preview: https://685edb0395873da364f3ba65--niaefeup-backend-docs.netlify.app

…niaefeup-backend into feature/recovery-email

Copilot

Pull Request Overview

This PR integrates the email service into the password recovery flow by adding Mustache templates, CSS styling, and wiring a RecoveryEmailBuilder into the AuthController.

Introduces recover-account.mustache and a shared HTML layout with inlined styles.
Adds TemplateEmailBuilder, RecoveryEmailBuilder, and CSS for email formatting.
Updates AuthController to send recovery emails and adapts tests.

Reviewed Changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/test/kotlin/.../AuthControllerTest.kt	Adjusted test imports for JUnit, removed unused import
src/main/resources/templates/email/recover-account.mustache	New Mustache template for recovery emails
src/main/resources/templates/email/layout.html.mustache	Updated HTML layout, inlines styles and adds header/footer
src/main/resources/email/style.css	Added CSS for email styling
src/main/resources/application.properties	Added blank line (minor) and email.from properties
src/main/kotlin/.../TemplateEmailBuilder.kt	Injected `baseServeUrl`, templating logic
src/main/kotlin/.../RecoveryEmailBuilder.kt	New builder for recovery email context
src/main/kotlin/.../AuthController.kt	Injected `EmailService`, sends recovery email

Comments suppressed due to low confidence (2)

src/main/kotlin/pt/up/fe/ni/website/backend/controller/AuthController.kt:64

This response format differs from the prior recovery_url JSON—this is a breaking change for API clients. Consider updating clients or restoring the original field name.

        return mapOf("message" to "Sent email to account recovery")

Copilot · 2025-07-01T18:12:53Z

src/test/kotlin/pt/up/fe/ni/website/backend/controller/AuthControllerTest.kt

-import java.util.*
 import java.util.Calendar
 import org.hamcrest.Matchers.startsWith
+import org.junit.Test


Mixing JUnit4’s @Test import with JUnit Jupiter in the same file may cause confusion—use org.junit.jupiter.api.Test consistently.

Suggested change

import org.junit.Test

import org.junit.jupiter.api.Test

Agree unless this is intentional

Copilot · 2025-07-01T18:12:53Z

src/main/resources/templates/email/layout.html.mustache

+            <img src="cid:image" alt="niaefeup-logo" width="100"/>
+            <h2>{{{ subject }}}</h2>
+        </div>
+            {{{ content }}}


Wrap the {{{ content }}} placeholder in a <div class="content"> to match the CSS selector .content and ensure consistent styling.

Suggested change

{{{ content }}}

<div class="content">

{{{ content }}}

</div>

Copilot · 2025-07-01T18:12:53Z

src/main/kotlin/pt/up/fe/ni/website/backend/email/TemplateEmailBuilder.kt

    private val commonmarkTextRenderer = ApplicationContextUtils.getBean(TextContentRenderer::class.java)
    private val mustache = ApplicationContextUtils.getBean(Mustache.Compiler::class.java)

+    @field:Value("\${upload.static-serve}")


The injected baseServeUrl field is not used in this class—consider removing it or using it for templating image URLs.

Copilot · 2025-07-01T18:12:54Z

src/main/resources/email/style.css

-/*
-TODO
-*/
+body {


The email CSS file is added but never referenced in the templates or passed to the builder’s styles front matter—ensure it’s loaded and inlined.

Copilot · 2025-07-01T18:12:54Z

src/main/kotlin/pt/up/fe/ni/website/backend/controller/AuthController.kt

+                        "$baseServeUrl/niaefeup.png"
+                    )
+                )
+                .to(recoveryRequestDto.email) // change to dev's email for testing


This inline comment indicates a temporary testing change—remove or replace it before merging to avoid sending test emails in production.

Suggested change

.to(recoveryRequestDto.email) // change to dev's email for testing

.to(if (isTestingEnabled) developerEmail else recoveryRequestDto.email)

github-actions · 2025-07-01T18:21:12Z

Check the documentation preview: https://686427162de5e5f922f67d2e--niaefeup-backend-docs.netlify.app

MRita443

Great job here! Left mostly some questions.

Also is there not a way in the tests to confirm an email was sent? Maybe by mocking some of the email functions? But if you think that's pedantic lmk!

MRita443 · 2025-07-01T18:16:35Z

src/main/resources/application.properties


 # Email config
-spring.mail.host=
+spring.mail.host= 


Suggested change

spring.mail.host=

spring.mail.host=

MRita443 · 2025-07-01T18:19:43Z

src/test/kotlin/pt/up/fe/ni/website/backend/controller/AuthControllerTest.kt

-import java.util.*
 import java.util.Calendar
 import org.hamcrest.Matchers.startsWith
+import org.junit.Test


Agree unless this is intentional

MRita443 · 2025-07-01T18:21:59Z

src/main/kotlin/pt/up/fe/ni/website/backend/email/TemplateEmailBuilder.kt

+    @field:Value("\${upload.static-serve}")
+    private var baseServeUrl: String = ""
+


Is this needed here?

MRita443 · 2025-07-01T18:24:48Z

build.gradle.kts

        exclude(group = "org.mockito2", module = "mockito-core")
    }
    testImplementation("org.mockito:mockito-inline:5.2.0")
+    testImplementation(kotlin("test"))


I think you can safely remove this

MRita443 · 2025-07-01T18:27:25Z

src/main/resources/email/style.css

+.expiry {
+  font-size: 13px;
+  color: #777;
+  margin-top: 30px;
+}
+.help {
+  margin-top: 30px;
+  font-size: 14px;
+}


Are these and others not currently used in the recovery template working well and may be used in the future or is it just leftover code?

MRita443 · 2025-07-01T18:30:12Z

src/main/kotlin/pt/up/fe/ni/website/backend/controller/AuthController.kt

+                )
+                .to(recoveryRequestDto.email) // change to dev's email for testing
+        )
+        return mapOf("message" to "Sent email to account recovery")


Suggested change

return mapOf("message" to "Sent email to account recovery")

return mapOf("message" to "Sent email for account recovery")

github-actions · 2025-07-21T14:41:38Z

Check the documentation preview: https://687e519f76a8848f7127441b--niaefeup-backend-docs.netlify.app

peucastro and others added 13 commits April 19, 2025 20:48

added thumbnail attribute to the Project model and seeder

6adefb2

fixing some tests

eec5fe3

added thumbnail attribute to the Project dto

dc906df

added thumbnail attribute to the Project controller

42872f5

setted thumbnail to be a Project-specific attribute (not present in A…

21ca3dd

…ctivity)

added thumbnail attribute to the PayloadProject api documentation

b8b8e38

removed thumbnail from updateProjectById

4c03f3b

fixed all tests

0137748

formatting

a854a6c

removed thumbnail documentation from PayloadAssociatedRoles

71dc32d

deleting old images

9768135

feat:email for account recovery

e3c236b

chore:lint

fddce7b

feat:more generic template

231d43a

rubuy-74 and others added 2 commits April 26, 2025 15:42

feat:changes

4a630ff

Merge branch 'develop' into feature/recovery-email

40a3ac8

rubuy-74 marked this pull request as ready for review June 27, 2025 17:47

rubuy-74 added 6 commits June 27, 2025 19:00

feat:final changes

0aebc6d

chore:remove sensitive data

ec08dae

chore:remove default application properties data

6e1508d

chore:add niaefeup logo to static folder

14e2047

Merge branch 'feature/recovery-email' of github.com:NIAEFEUP/website-…

02ef52f

…niaefeup-backend into feature/recovery-email

chore:remove comments

40489a0

MRita443 requested review from MRita443 and Copilot July 1, 2025 18:11

Merge branch 'develop' into feature/recovery-email

a11f836

Copilot AI reviewed Jul 1, 2025

View reviewed changes

MRita443 requested changes Jul 1, 2025

View reviewed changes

Merge branch 'develop' into feature/recovery-email

5ed45f7

	.to(recoveryRequestDto.email) // change to dev's email for testing
	.to(if (isTestingEnabled) developerEmail else recoveryRequestDto.email)

		@field:Value("\${upload.static-serve}")
		private var baseServeUrl: String = ""

	return mapOf("message" to "Sent email to account recovery")
	return mapOf("message" to "Sent email for account recovery")

Feature/recovery email #225

Are you sure you want to change the base?

Feature/recovery email #225

Uh oh!

Conversation

rubuy-74 commented Apr 22, 2025 • edited by MRita443 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review checklist

Uh oh!

github-actions bot commented Apr 22, 2025

Uh oh!

github-actions bot commented Apr 22, 2025

Uh oh!

github-actions bot commented Jun 27, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

MRita443 Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

MRita443 left a comment

Choose a reason for hiding this comment

Uh oh!

MRita443 Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

MRita443 Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

MRita443 Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

MRita443 Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

MRita443 Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

MRita443 Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rubuy-74 commented Apr 22, 2025 •

edited by MRita443

Loading