Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CICE updates to support IntelLLVM compiler #91

Closed
wants to merge 3 commits into from
Closed

CICE updates to support IntelLLVM compiler #91

wants to merge 3 commits into from

Conversation

NickSzapiro-NOAA
Copy link
Collaborator

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Add ifndef __INTEL_LLVM_COMPILER (for intel oneapi) around an OMP loop that the compiler doesn't handle properly in ice_history.F90. Remove ncat,ntrcr in call icepack_aggregate in ice_prescribed_mod.F90 following refactor
  • Developer(s):
    Nick Szapiro
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    b4b in CICE and UFS RT suites
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

Compilation and runtime error fixes needed in cice sync for ufs-community/ufs-weather-model#2224

apcraig and others added 3 commits September 24, 2024 09:28
@apcraig
Update Derecho Port
63887f3 
- update inteloneapi, validate, use -O1, problems with -check all.
- update cray to ncarenv/23.09 and cce/16.0.1, answers change
- update intel to ncarenv/23.09 and intel/2023.2.1, answer bit-for-bit
- update nvhpc to ncarenv/23.09 and nvhpc/23.7, answers change

Add ifndef __INTEL_LLVM_COMPILER (for intel oneapi) around an OMP
loop that the compiler doesn't handle properly (reported to intel)
in ice_history.F90.

Update QC documentation in the user guide to clarify where/how to run
the cice.t-test.py script.
@NickSzapiro-NOAA
No ncat,ntrcr in call icepack_aggregate in ice_prescribed_mod.F90
51e3ee7
@NickSzapiro-NOAA
Update Derecho Port
bf66bf7 
PR as in CICE-Consortium#974
@NickSzapiro-NOAA
Copy link
Collaborator Author

UFS RTs pass b4b on hercules:
RegressionTests_hercules.log

@NickSzapiro-NOAA NickSzapiro-NOAA linked an issue Sep 26, 2024 that may be closed by this pull request
Sync with CICE-Consortium for scheduled LLVM UFS PR #92
Closed
@DusanJovic-NOAA DusanJovic-NOAA mentioned this pull request Sep 26, 2024
Merged
14 tasks
@NickSzapiro-NOAA NickSzapiro-NOAA deleted the sync_cice branch October 7, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianCurtis-NOAA BrianCurtis-NOAA BrianCurtis-NOAA approved these changes

@dpsarmie dpsarmie dpsarmie approved these changes

@DeniseWorthen DeniseWorthen DeniseWorthen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync with CICE-Consortium for scheduled LLVM UFS PR
5 participants
@NickSzapiro-NOAA @DeniseWorthen @dpsarmie @BrianCurtis-NOAA @apcraig