Skip to content

Adding missing grib2 parameters (Section 0) from previous WMO updates #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
May 6, 2025

Conversation

AlysonStahl-NOAA
Copy link
Contributor

Fixes #563

@AlysonStahl-NOAA AlysonStahl-NOAA changed the title Adding missing grib2 parameters from previous WMO updates Adding missing grib2 parameters (Section 0) from previous WMO updates Apr 29, 2025
@AlysonStahl-NOAA AlysonStahl-NOAA marked this pull request as ready for review April 29, 2025 22:41
@Hang-Lei-NOAA
Copy link
Contributor

@AlysonStahl-NOAA These GRIB2 codes and template information are served in g2tmpl library.

@Hang-Lei-NOAA
Copy link
Contributor

@AlysonStahl-NOAA are you going to combine the functions of all g2 series libraries into one?

@AlysonStahl-NOAA
Copy link
Contributor Author

I currently only have plans to combine g2 and g2c template functions at the moment. I know the idea of having one library contain all of the params has been floated before (#255), but I don't know if there have been any further developments on that discussion.

@AlysonStahl-NOAA
Copy link
Contributor Author

I intended on including the parameter functions in those changes to g2, however, the parameters are only included if the file-based API option is enabled. Right now the g2 library does not require the API be enabled, but the parameter functions are used in too many other subroutines to build it optionally. I would either need to make the API a required part of the g2c build in g2 or update g2c's API build. I'm not sure how we want to handle that, so I will open an issue.

@Hang-Lei-NOAA
Copy link
Contributor

If so, go ahead and merge it.

@AlysonStahl-NOAA AlysonStahl-NOAA merged commit 14354a4 into NOAA-EMC:develop May 6, 2025
38 checks passed
@AlysonStahl-NOAA AlysonStahl-NOAA deleted the as_params2 branch May 6, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes required for quarterly GRIB2 table updates
2 participants