-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ww3 diffraction #1144
Draft
aronroland
wants to merge
221
commits into
NOAA-EMC:develop
Choose a base branch
from
erdc:ww3_diffraction
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Ww3 diffraction #1144
Changes from 179 commits
Commits
Show all changes
221 commits
Select commit
Hold shift + click to select a range
09164b5
ww3_wise: add my comp and link
aronroland 59638f6
ww3_wise: add my comp and link
aronroland 9fd1a47
ww3_wise: comp and link datarmo
aronroland bb00127
ww3_wise: group velocities and new limiter ...
aronroland e5d2d9d
ww3_wise: improve speed of computation
aronroland 826ab06
ww3_wise: further optimization level
aronroland d843168
ww3_wise: some more cleaning
aronroland 29139ac
ww3_wise: more on performance
aronroland ff51b11
Merge branch 'ww3_wise' of https://github.com/erdc/WW3 into ww3_wise
aronroland a586cc9
ww3_wise: more on performance
aronroland 89e2a1c
ww3_wise: ... memory ...
aronroland 78ee80f
ww3_wise: fix more memcheck issues
aronroland 4931557
ww3_wise: and more on memcheck
aronroland 54b301a
ww3_wise: more on memcheck and others
aronroland 193496b
ww3_wise: more on debugging ...
aronroland 1b1c04c
ww3_wise: more on limiters ...
aronroland 7924004
Merge branch 'develop' into ww3_wise
aronroland ed82af9
ww3_wise: merge from WISE
aronroland 6b22bca
ww3_wise: fix typo and syntax error
aronroland a9c17c4
ww3_wise: testing load imbalance
aronroland e388055
ww3_wise: update wave reflection and extend for implicit
aronroland b6ed65c
ww3_wise: commit missing use part for reflection
aronroland 5dcf76d
Merge branch 'develop' into ww3_wise
aronroland bb1ffd0
ww3_wise: conflicts
aronroland a6d7dfe
finished merge with develop
aronroland fba00ba
ww3_wise: more on the merge ...
aronroland 8f9ba92
ww3_wise: next part of consolodiation
aronroland b60e6cc
ww3_wise: merge wave_setup
aronroland e79c3aa
ww3_wise: more on setup
aronroland 70277b9
ww3_wise: 2nd part
aronroland fb2ba68
ww3_wise: debug stage 1 ...
aronroland e27966a
ww3_wise: update wave setup part
aronroland a850572
ww3_wise: add hycom modification for SHOM
aronroland a47ec3e
ww3_wise: Some bug fix for the HYCOM part
aronroland 9dcbb74
ww3_wise: add proper link line in link.itedev
aronroland bb20505
ww3_wise: interfacing c ...
aronroland 933fbc7
ww3_wise: type conversion in the solver
aronroland 1c0db66
ww3_wise: add DD to OASIS ... 1st part ...now debugging
aronroland 32a4b2b
ww3_wise: fix oasis coupling syntax error
aronroland 98b7a8c
ww3_wise: more fix for oasis dd treatment
aronroland 0edb71d
ww3_wise: more on the oasis part with respect to dd
aronroland a28560e
Merge branch 'develop' into ww3_wise
aronroland bcdf642
ww3_wise: more oasis stuff
aronroland 425e450
Merge branch 'ww3_wise' of https://github.com/erdc/WW3 into ww3_wise
aronroland a62a0b5
ww3_wise: fix typo for oasis dd
aronroland e2efe78
ww3_wise: working on the debug flags ...
aronroland d05ad6b
ww3_wise: add some debug for oasis
aronroland f3b76af
ww3_wise: add more oasis input
aronroland 5d1cea5
ww3_wise: add missing oasis part for unstructured now trying ORANGE p…
aronroland aa3380e
ww3_wise: add also for POINT partition ...
aronroland f903372
ww3_wise: add switch files ...
aronroland 7314010
Merge branch 'develop' into ww3_wise_merge_develop
aronroland 14cf5ee
ww3_wise_merge_develop: fixing merge errors ...
aronroland 08d307a
ww3_wise_merge_develop: more merge errors ...
aronroland c8f7e8b
ww3_wise_merge_develop: more merge errors ...
aronroland 8c9cc80
ww3_wise_merge_develop: more fixed for merge
aronroland 3e5c1aa
ww3_wise_merge_develop: more on the merging ...
aronroland 1c033a6
ww3_wise_merge_develop: more merging fun ...
aronroland 2ac2531
Merge branch 'ww3_wise_merge_develop' of https://github.com/erdc/WW3 …
aronroland ff5dbb9
ww3_wise_merge_develop: more merging ...
aronroland 0ea1334
ww3_wise_merge_develop: now it is compiling ...
aronroland 82647a4
ww3_wise_merge_develop: more merge of setup work
aronroland e930d09
Merge branch 'ww3_wise_merge_develop' of https://github.com/erdc/WW3 …
aronroland 508ee91
ww3_wise_merge_develop: consolidation of reflection part for ugtype
aronroland cf1464b
ww3_wise_merge_develop: more on setup and reflection ...
aronroland 86b3f25
ww3_wise_merge_develop: cleaning
aronroland b2ac283
ww3_wise_merge_develop: testing output ..
aronroland 2170617
ww3_wise_merge_develop: cleaning the refleciton part
aronroland 284e175
ww3_wise_merge_develop: cleaning implicit reflection ...
aronroland ac163db
ww3_wise_merge_develop: more cleaning on reflection
aronroland d2bf8eb
ww3_wise_merge_develop: working on higher order scheme
aronroland 390de6e
ww3_wise_merge_develop: fix bug in 2nd order explicit scheme and add …
aronroland fe8753e
ww3_wise_merge_develop: merge also my triad code
aronroland bbdc540
ww3_wise_merge_develop: merge last oasis work
aronroland b29df46
ww3_wise_merge_develop: more on oasis
aronroland df4d23f
ww3_wise_merge_develop: more on oasis
aronroland b4825a3
ww3_wise_merge_develop: now check for the wise version with OASIS, th…
aronroland 8a17ae9
Revert "ww3_wise_merge_develop: now check for the wise version with O…
aronroland 5dabcdb
ww3_wise_merge_develop: more on the oasis coupler ...
aronroland e3f9094
ww3_wise_merge_develop: fix compilation without pdlib
aronroland 9b34518
ww3_wise_merge_develop: more on oasis and cleaning
aronroland 8cd9af3
ww3_wise_merge_develop: next steps on oasis coupler ...
aronroland ca24457
ww3_wise_merge_develop: remove debug statements
aronroland 203e3ff
ww3_wise_merge_develop: add ndr
aronroland d408adc
Merge branch 'develop' into ww3_wise_merge_develop
aronroland 30ae20a
Merge branch 'develop' into ww3_wise_merge_develop
aronroland 28476b6
ww3_wise_merge_develop: do missing locality in block explicit scheme
aronroland 5694026
ww3_wise_merge_develop: rewrite block explicit scheme ...
aronroland 756c105
ww3_wise_merge_develop: fix some small bugs ..
aronroland 0f6c0ae
ww3_wise_merge_develop: add more testoutput
aronroland 5e65ffc
ww3_wise_merge_develop: add missing reflection part
aronroland ddcd86b
ww3_wise_merge_develop: sync with mathieu's latest work for setup + t…
aronroland 98d8ef3
ww3_wise_merge_develop: clean leftovers of setup computations ...
aronroland 897cc81
Merge branch 'ww3_wise_merge_develop' of https://github.com/erdc/WW3 …
aronroland 1b15ddc
ww3_wise_merge_develop: cleaning of the oasis part and more work on t…
aronroland 9315406
ww3_wise_merge_develop: add stdout about the unst schemes used
aronroland f686842
ww3_wise_merge_develop: getting rid of more barriers for oasis debugging
aronroland 701dbb6
ww3_wise_merge_develop: more on oasis
aronroland 748d7b0
ww3_wise_merge_develop: cleaning, consolidation, default variables, o…
aronroland c27a637
Merge branch 'ww3_wise_merge_develop' of https://github.com/erdc/WW3 …
aronroland acd34c7
ww3_wise_merge_develop: do intermediate fix for exchange of the block…
aronroland e4fd5c1
ww3_wise_merge_develop: fix for block explicit
aronroland 2678302
ww3_wise_merge_develop: missing part of last merge ...
aronroland 2083e06
ww3_wise_merge_develop: cleaning ..
aronroland 4e080fb
ww3_wise_merge_develop: turn of new limiter
aronroland 500f104
ww3_wise_merge_develop: quick fix for implicit scheme without sources…
aronroland ceefdee
Merge branch 'ww3_wise_merge_develop' of https://github.com/erdc/WW3 …
aronroland 6abc55a
ww3_wise_merge_develop: code consolidation
aronroland 54fee19
ww3_wise_merge_develop: fix for oasis
aronroland 7c2f6ee
ww3_wise_merge_develop: add swicthes for SHOM
aronroland 0a0c905
ww3_wise_merge_develop: fix logics in switches
aronroland eb04676
ww3_wise_merge_develop: cleaning
aronroland cf7c31e
ww3_wise_merge_develop: SOLVED THE CURRENT BUG!
aronroland f8005a0
fix conflict
3cb2ff3
two bug fixes for nonpdlib regtests
192b8ea
move CPUTIME to MPI swtich ifdef
fd450c3
fix for non-pdlib cases
a901e7b
update ncep matrix module versions
7a80232
additonal fixes for regtests
a32b4c5
add regtests for global_unstr
8f1ebea
revert model/bin
880f159
revert model/src/CMakeLists.txt
c68cfb3
revert regtests/ww3_tp2.6
03c3197
ww3_wise_merge_develop: comment in wave setup computation .ww3_wise_m…
aronroland aafb0d4
ww3_wise_merge_develop: some little test before final freeze
aronroland 06bf389
ww3_wise_merge_develop: revert
aronroland 3c51988
merge upstream dev
ca76d1c
ww3_wise_merge_develop: 1st round of cleaning debug statements
aronroland 3d68cd6
ww3_wise_merge_develop: cleaned all cluter, debug and other leftovers…
aronroland f682540
ww3_wise_merge_develop: move to point partition for OASIS
aronroland d7a3938
Merge branch 'ww3_wise_merge_develop' of https://github.com/erdc/WW3 …
aronroland d3d4981
ww3_wise_merge_develop: fix ifdef/endif issue
aronroland 3a60217
ww3_wise_merge_develop: fix bug in triads
aronroland b984b26
ww3_wise_merge_develop: add back doxygen
aronroland 5547572
ww3_wise_merge_develop: more on the comments
aronroland ec13e94
ww3_wise_merge_develop: order of declaration
aronroland df6cc07
ww3_wise_merge_develop: more cleaning
aronroland 30574c3
ww3_wise_merge_develop: more cleaning ...
aronroland d33791d
Merge branch 'ww3_wise_merge_develop' of https://github.com/erdc/WW3 …
aronroland 4bda7c6
ww3_wise_merge_develop: work on headers
aronroland bee8db5
ww3_wise_merge_develop: doing some more checks ...
aronroland 21f32d0
ww3_wise_merge_develop: extend for car-deck approach
aronroland 58585dc
ww3_wise_merge_develop: more cleanup and consolidation
aronroland 539907f
ww3_wise_merge_develop: delete cluter and dbg msg
aronroland c40694d
ww3_wise_merge_develop: more cleaning of stdout
aronroland 596a34d
ww3_wise_merge_develop: more cleaning
aronroland 0f4ed02
ww3_wise_merge_develop: add more namelist comments, not finished yet
aronroland a32ca06
ww3_wise_merge_develop: edit namelist based on jessica input
aronroland e29a9c0
ww3_wise_merge_develop: fix issues following tyler
aronroland d8ada73
ww3_wise_merge_develop: some more work on the namelist comments
aronroland 533ac5f
ww3_wise_merge_develop: working on the namelist
aronroland 8643a93
Merge branch 'NOAA-EMC:develop' into ww3_wise_merge_develop
aliabdolali 04b4451
ww3_wise_merge_develop: clean and add missing pragma
aronroland 1b6c95e
Merge branch 'ww3_wise_merge_develop' of https://github.com/erdc/WW3 …
aronroland f40ef82
ww3_wise_merge_develop: cleaning and namelist
aronroland ef22a77
Merge branch 'ww3_wise_merge_develop' of https://github.com/erdc/WW3 …
aronroland d9a5737
Merge branch 'ww3_wise_merge_develop' of https://github.com/erdc/WW3 …
aronroland dd60dcb
adding boers case regtest ww3_tp2.19
thesser1 3cd9ca2
ww3_wise_merge_develop: add explanation of unst namelist in the inp f…
aronroland 962900a
cleaning up regtest 2.19
thesser1 0ccb4e9
merge develop
2fa2b76
Update switch_PDLIB
aliabdolali 3757cd7
Merge branch 'ww3_wise_merge_develop' of https://github.com/erdc/WW3 …
aronroland c97791c
ww3_wise_merge_develop: some more work on oasis ...
aronroland 32a57df
update ftp retrieval routine and remove mesh from block explicit test
0cf7c74
ww3_wise_merge_develop: clean cpp pragma of pdlib based on jessicas i…
aronroland ffd8c0a
Merge branch 'ww3_wise_merge_develop' of https://github.com/erdc/WW3 …
aronroland 535bc12
update tp2.19 ounp.inp to include real option in spectra
thesser1 1eaff5f
updating ounp.inp for other cases on tp2.19
thesser1 f22835a
ww3_wise_merge_develop: clean and solver another oasis issue
aronroland 6408cf5
ww3_diffraction: implementation of wave diffraction approximation
aronroland 8821638
ww3_diffraction: finish implementation of wave diffraction, now it ne…
aronroland d62dab8
ww3_diffraction: add missing pragma
aronroland 5926077
ww3_diffraction: work more on diffraction approximation ...
aronroland 8d4ad7e
ww3_diffraction: more work on the higher order diffraction approximat…
aronroland f3a647f
ww3_gr3: initial commit ... still testing with issues at the wave bou…
aronroland 2c5947b
ww3_gr3: done and tested ...
aronroland 10195a4
ww3_gr3: consolidate input for limon and work on the source terms flags
aronroland 40f71c7
ww3_gr3: towards init_bugs branch
aronroland b51d11e
ww3_gr3: fix boundary issue for the neumann conditio
aronroland a3e143c
init_bugs2: solve neuman on boundary
aronroland e5efc45
Merge branch 'develop' into ww3_diffraction
aronroland f6110f5
ww3_diffraction: merge develop and fix conflicts
aronroland d99f8cd
Merge branch 'develop' into ww3_diffraction
aronroland 803192c
Merge branch 'develop' into ww3_2dm
aronroland 799e787
ww3_2dm: finished and tested implementation. Added needed files for t…
aronroland 57ba5f8
Merge branch 'develop' into init_bugs2
aronroland 2f62ff7
ww3_2dm: fix active wave boundary ...
aronroland 9e0a031
ww3_diffraction: chasing some bugs ...
aronroland 9164b16
ww3_2dm: some more debugging
aronroland 4cbe073
ug_imp_nmb_acc: Those changes to the number accuracy of the implicit …
aronroland 288366a
Merge branch 'ug_imp_nmb_acc' into ww3_2dm
aronroland 3030524
ww3_diffraction: work on testcase ...
aronroland bbee78e
Merge remote-tracking branch 'remotes/origin/ug_imp_nmb_acc' into ww3…
aronroland a43b8b0
ww3_diffraction: more on regtests ..
aronroland e0bea58
ug_imp_nmb_acc: add proper settings to limon
aronroland e60a45e
ug_imp_nmb_acc: add another input file
aronroland 542bd3b
ww3_2dm: add polygons for prescribing boundary conditions
aronroland a94054e
ww3_2dm: add meshbnd.2dm and script for meshtools to use polygons to …
aronroland d9bef70
ww3_2dm: update inputfiles ...
aronroland e6cd3a5
Merge branch 'init_bugs2' into ww3_diffraction
aronroland 81ad5dd
ww3_diffraction: work on the extended diffraction part ...
aronroland 87d24b7
Merge branch 'ug_imp_nmb_acc' into ww3_diffraction
aronroland d7157b7
ww3_diffraction: work on spherical transformation of the higher order…
aronroland d1d452f
ww3_diffraction: restructure the dd part of the ugrid and fix a bug
aronroland af05be6
ww3_diffraction: remove some warning in tria
aronroland 2c6b316
Merge branch 'ww3_2dm' into ww3_diffraction
aronroland baf3f7e
ww3_diffraction: more on diffraction ...
aronroland a3b88d0
ww3_diffraction: code cleaning, moved variables to w3gdat and added s…
aronroland 1af1777
ww3_diffraction: some more fixing
aronroland 60816a5
ww3_diffraction: finish smoothing implementation for the explicit sch…
aronroland b71b9b0
ww3_diffraction: more work on the diffraction based on the EMSE
aronroland 099591c
ww3_diffraction: more on refraction ...
aronroland 01d43df
ww3_diffraction: more on ww3_unst
aronroland b820c16
ug_imp_nmb_acc: revert changes to 2.6
aronroland a596f3d
ww3_diffraction: fix bug on boundary
aronroland 5004d4c
ww3_diffraction: cleaning and sec1
aronroland 0635f93
Merge branch 'ug_imp_nmb_acc' into ww3_diffraction
aronroland 07d4f6c
ww3_diffraction: add regression tests for semi-inifnite breakwater an…
aronroland 305153c
Merge branch 'develop' into ww3_diffraction
aronroland b837c0b
ww3_diffraction: minor edits ...
aronroland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -928,6 +928,8 @@ MODULE W3GRIDMD | |
INTEGER :: UNSTSCHEMES(6) | ||
INTEGER :: UNSTSCHEME | ||
INTEGER :: JGS_NLEVEL | ||
LOGICAL :: JGS_LDIFR | ||
INTEGER :: JGS_IDIFR | ||
REAL*8 :: JGS_PMIN | ||
REAL*8 :: JGS_DIFF_THR | ||
REAL*8 :: JGS_NORM_THR | ||
|
@@ -1097,7 +1099,8 @@ MODULE W3GRIDMD | |
JGS_NLEVEL, & | ||
JGS_SOURCE_NONLINEAR, & | ||
SETUP_APPLY_WLV, SOLVERTHR_SETUP, & | ||
CRIT_DEP_SETUP | ||
CRIT_DEP_SETUP, JGS_LDIFR, JGS_IDIFR | ||
|
||
NAMELIST /MISC/ CICE0, CICEN, LICE, XSEED, FLAGTR, XP, XR, & | ||
XFILT, PMOVE, IHM, HSPM, WSM, WSC, FLC, FMICHE, & | ||
RWNDC, FACBERG, NOSW, GSHIFT, WCOR1, WCOR2, & | ||
|
@@ -2440,6 +2443,8 @@ SUBROUTINE W3GRID() | |
JGS_NORM_THR = 1.E-20 | ||
JGS_NLEVEL = 0 | ||
JGS_SOURCE_NONLINEAR = .FALSE. | ||
JGS_LDIFR = .FALSE. | ||
JGS_IDIFR = 1 | ||
! read data from the unstructured devoted namelist | ||
CALL READNL ( NDSS, 'UNST', STATUS ) | ||
|
||
|
@@ -2455,6 +2460,8 @@ SUBROUTINE W3GRID() | |
B_JGS_DIFF_THR = JGS_DIFF_THR | ||
B_JGS_NORM_THR = JGS_NORM_THR | ||
B_JGS_NLEVEL = JGS_NLEVEL | ||
B_JGS_LDIFR = JGS_LDIFR | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add descriptions in model/inp/ww3_grid.inp of new variables. |
||
B_JGS_IDIFR = JGS_IDIFR | ||
B_JGS_SOURCE_NONLINEAR = JGS_SOURCE_NONLINEAR | ||
|
||
nbSel=0 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if the changes here are intentional. It looks like this is removing descriptions of variables that should have descriptions, plus from below it seems like we should have a few additional variables added here.