-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ww3 homp #1149
base: develop
Are you sure you want to change the base?
Ww3 homp #1149
Conversation
…solver have been forgotten to merge by me. The solver conevergence computation have not been good before due to the choosen accuracies.
@aronroland @thesser1 It's really great to see all this new work coming in! Can we expect the testing results soon as well? Please keep us posted on your progress so we know when we can start to review on our end. |
yes, sir we do our best |
Sounds good. Thank you, Aron |
model/src/w3profsmd_pdlib.F90
Outdated
FLUSH(740+IAPROC) | ||
#endif | ||
|
||
#ifdef W3_O MPH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @aronroland - just spotted this potential typo?
Should this be W3_OMPH
, not W3_O MPH
?
Or was it deliberate to disable that OMP directive?
@aronroland I'm going to mark this as a draft. Please mark it as ready to review when it's time and testing information is available. |
Pull Request Summary
Hybrid OpenMP for UG
Description
This pull request implements Hybrid OpenMP for UG-Schemes.
Please also include the following information:
new feature
No
Issue(s) addressed
none
Commit Message
OMPH for UGRID
Check list
tp2.6 was tested, certain regtests have to be designed yet.
Testing
tp2.6 war run with various settings
I made a new regression test needs to be added to the suite.
Will do that with ERDC
to be done ...
to be done ...