Save marine LETKF yaml #3489
Draft
Save marine LETKF yaml #3489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlyaeva
requested review from
guillaumevernieres and
AndrewEichmann-NOAA
as code owners
aerorahul
reviewed
Mar 25, 2025
| @@ -205,5 +205,9 @@ def finalize(self): | |||
| # stage the desired diag files | |||
| FileHandler({'mkdir': [os.path.join(letkfsaveconf.COMOUT_OCEAN_LETKF, 'diags')]}).sync() | |||
| FileHandler({'copy': obs_files_to_copy}).sync() | |||
| # yaml configurations | |||
| yamls_to_copy = [] | |||
| yamls_to_copy.append([letkfsaveconf.letkf_yaml_file, os.path.join(letkfsaveconf.COMOUT_OCEAN_LETKF, 'letkf.yaml')]) | |||
There was a problem hiding this comment.
This action is fine.
However, we are saving all the configurations to directory named COM_CONF instead of COMOUT_OCEAN_LETKF. COM_CONF is a directory in COM that has all the configurations of all the executables that are run in a cycle.
There was a problem hiding this comment.
Nice, I didn't know this! I'll take a look later this week to change this and maybe also some other marine yamls that get copied to a different directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Saves marine LETKF yaml for posterity and for EVA verifications plots.
Note: this is not urgent as it's not required for v17.
Type of change
Change characteristics
How has this been tested?
Tested with the hybrid C384m025 experiment in ci/cases/gfsv17, with hera/intel. The yaml is saved in COMROOT as expected and successfully used for diagnostics plots (see NOAA-EMC/gdas-marine-viz#511 for an example).
Checklist