Skip to content

Add the setting to use the reject list for station t/q observations in GSI based soil DA #3599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 30, 2025
Merged

Add the setting to use the reject list for station t/q observations in GSI based soil DA #3599

merged 8 commits into from
Apr 30, 2025
+5 −3

Conversation

jiaruidong2017
Copy link
Contributor

@jiaruidong2017 jiaruidong2017 commented Apr 19, 2025 •
edited by KateFriedman-NOAA
Loading

Description

This PR adds the setting to read and apply the reject list for removing the t/q observations from prepbufr file in GSA based soil DA.

Refs NOAA-EMC/GSI-fix#35, which will be updated in NOAA-EMC/GSI#866
Resolves #3546

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES (If YES, please add a link to any PRs that are pending.)

How has this been tested?

  • Cycled test on Orion

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@KateFriedman-NOAA KateFriedman-NOAA mentioned this pull request Apr 21, 2025
Closed
4 tasks
KateFriedman-NOAA
KateFriedman-NOAA previously approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @jiaruidong2017 ! Approve pending successful completion of CI testing.

@KateFriedman-NOAA
Copy link
Member

@jiaruidong2017 please sync your PR branch with develop and resolve the shellcheck error that is getting flagged. Then we can run CI on this, thanks!

@jiaruidong2017
Copy link
Contributor Author

Thanks @KateFriedman-NOAA reminder. Done as suggested.

KateFriedman-NOAA
KateFriedman-NOAA approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve pending successful completion of CI.

@KateFriedman-NOAA KateFriedman-NOAA added the CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS label Apr 28, 2025
@emcbot emcbot added CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS and removed CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS labels Apr 28, 2025
@emcbot emcbot added the CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress label Apr 28, 2025
@emcbot
Copy link

emcbot commented Apr 28, 2025

CI Tests set up to run in /lfs/h2/emc/ptmp/emc.global/PR/PR_3599/RUNTESTS on WCOSS

@KateFriedman-NOAA
Copy link
Member

KateFriedman-NOAA commented Apr 29, 2025 •
edited
Loading

Some gempak jobs hit their walltimes in the extended test on WCOSS2. I am rerunning them to confirm they ran long due to a machine issue. All other jobs and test cases completed without issue.

@KateFriedman-NOAA
Copy link
Member

CI on WCOSS2 completed successfully:

Wed Apr 30 13:27:20 UTC 2025
******** C48_ATM_3599 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Apr 28 2025 20:32:04    Apr 28 2025 21:40:41

******** C48mx500_3DVarAOWCDA_3599 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    Apr 28 2025 20:32:07    Apr 28 2025 20:51:05
202103250000        Done    Apr 28 2025 20:32:07    Apr 28 2025 22:25:55

******** C48mx500_hybAOWCDA_3599 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    Apr 28 2025 20:32:11    Apr 28 2025 20:51:18
202103250000        Done    Apr 28 2025 20:32:11    Apr 28 2025 21:55:54

******** C48_S2SW_3599 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Apr 28 2025 20:32:14    Apr 28 2025 21:40:56

******** C48_S2SWA_gefs_3599 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Apr 28 2025 20:32:19    Apr 28 2025 22:01:16

******** C96_atm3DVar_extended_3599 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    Apr 28 2025 20:32:23    Apr 28 2025 20:51:57
202112210000        Done    Apr 28 2025 20:32:23    Apr 29 2025 14:56:17
202112210600        Done    Apr 28 2025 20:32:23    Apr 29 2025 14:56:17
202112211200        Done    Apr 28 2025 20:56:46    Apr 29 2025 14:56:17
202112211800        Done    Apr 29 2025 15:01:02    Apr 30 2025 13:25:51

******** C96C48_hybatmaerosnowDA_3599 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    Apr 28 2025 20:32:26    Apr 28 2025 20:56:58
202112201800        Done    Apr 28 2025 20:32:26    Apr 28 2025 23:01:32
202112210000        Done    Apr 28 2025 20:32:26    Apr 28 2025 22:51:17

******** C96C48_hybatmDA_3599 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    Apr 28 2025 20:32:30    Apr 28 2025 20:52:11
202112210000        Done    Apr 28 2025 20:32:30    Apr 28 2025 22:56:31
202112210600        Done    Apr 28 2025 20:32:30    Apr 28 2025 22:46:24

******** C96C48_ufs_hybatmDA_3599 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202402231800        Done    Apr 28 2025 20:32:32    Apr 28 2025 20:52:16
202402240000        Done    Apr 28 2025 20:32:32    Apr 28 2025 23:26:36
202402240600        Done    Apr 28 2025 20:32:32    Apr 28 2025 23:11:29

******** C96mx100_S2S_3599 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
199405010000        Done    Apr 28 2025 20:32:37    Apr 28 2025 22:06:25

@KateFriedman-NOAA KateFriedman-NOAA added CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress labels Apr 30, 2025
@KateFriedman-NOAA KateFriedman-NOAA merged commit 315b55b into NOAA-EMC:develop Apr 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

@KateFriedman-NOAA KateFriedman-NOAA KateFriedman-NOAA approved these changes

@RussTreadon-NOAA RussTreadon-NOAA Awaiting requested review from RussTreadon-NOAA RussTreadon-NOAA is a code owner

@CatherineThomas-NOAA CatherineThomas-NOAA Awaiting requested review from CatherineThomas-NOAA

@DavidHuber-NOAA DavidHuber-NOAA Awaiting requested review from DavidHuber-NOAA

Assignees
No one assigned
Labels
CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update error table for surface T,Q observations
4 participants
@jiaruidong2017 @KateFriedman-NOAA @emcbot @CoryMartin-NOAA