Update ush scripts to comply with bash static code checkers #4292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalterKolczynski-NOAA
requested review from
BoCui-NOAA,
BrianCurtis-NOAA,
ClaraDraper-NOAA,
CoryMartin-NOAA,
DavidHuber-NOAA,
DeniseWorthen,
EdwardSafford-NOAA,
EricSinsky-NOAA,
JessicaMeixner-NOAA,
JiayiPeng-NOAA,
RussTreadon-NOAA,
WenMeng-NOAA,
aerorahul,
guoqing-noaa,
jiandewang,
junwang-noaa and
sbanihash
as code owners
DavidHuber-NOAA
requested changes
Dec 5, 2025
Contributor
DavidHuber-NOAA
left a comment
DavidHuber-NOAA
left a comment
There was a problem hiding this comment.
Looks good overall. A few suggestions and questions.
Comment on lines
+77
to
84
| "${EXECgfs}/${pgm}" 1> "prnc_${WAVECUR_FID}_${ymdh_rtofs}.out" 2>&1 | ||
| export err=$? | ||
| err_chk | ||
| if [[ "${err}" -ne 0 ]]; then | ||
| cat "prnc_${WAVECUR_FID}_${ymdh_rtofs}.out" | ||
| echo "WARNING: NON-FATAL ERROR IN ${pgm}." | ||
| exit 4 | ||
| fi |
Contributor
There was a problem hiding this comment.
@JessicaMeixner-NOAA Should this be a fatal error or not? err_chk is going to exit completely if err is not 0, so the WARNING will never be printed.
DavidHuber-NOAA
requested changes
Dec 9, 2025
Contributor
DavidHuber-NOAA
left a comment
DavidHuber-NOAA
left a comment
There was a problem hiding this comment.
Just one addition needed to retain noaacloud support.
dev/ush/load_modules.sh
Outdated
| module use "${HOMEgfs}/sorc/gdas.cd/modulefiles" | ||
|
|
||
| case "${MACHINE_ID}" in | ||
| "hera" | "orion" | "hercules" | "wcoss2" | "gaeac5" | "gaeac6" | "ursa") |
Contributor
There was a problem hiding this comment.
Suggested change
| "hera" | "orion" | "hercules" | "wcoss2" | "gaeac5" | "gaeac6" | "ursa") | |
| "hera" | "orion" | "hercules" | "wcoss2" | "gaeac5" | "gaeac6" | "ursa" | "noaacloud") |
Contributor
|
Launching CI tests. |
emcbot
added
CI-Gaeac6-Ready
DavidHuber-NOAA
added
the
CI-Wcoss2-Running
emcbot
added
CI-Hercules-Building
emcbot
added
CI-Ursa-Running
DavidHuber-NOAA
approved these changes
Dec 9, 2025
Contributor
DavidHuber-NOAA
left a comment
DavidHuber-NOAA
left a comment
There was a problem hiding this comment.
Approve pending successful CI testing.
emcbot
added
CI-Gaeac6-Passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the ush scripts (including dev/ush) to be compliant with the static bash code analysis checkers.
Also updates the reporter for the GH action so that it should be able to post recommendations on PRs.
Type of change
Change characteristics
How has this been tested?
Checklist