Skip to content

update gsi hash to include ABI G19 in build_gsinfo (issue #4287) #4304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jswhit wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

update gsi hash to include ABI G19 in build_gsinfo (issue #4287) #4304

jswhit wants to merge 1 commit into from
+1 −1

Conversation

@jswhit
Copy link

@jswhit jswhit commented Dec 8, 2025

#Description

This PR updates the GSI hash to include an updated version of build_gsinfo which turns on abi_g19 assimilaton.
Resolves #4287.
Refs NOAA-EMC/GSI#959, NOAA-EMC/GSI-fix#53, NOAA-PSL/build_gsinfo-fix#6

Type of change

  • [ x] Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • [ x] GFS
  • GEFS
  • SFS
  • GCAFS
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

GSI regression tests pass

Checklist

  • [ x] Any dependent changes have been merged and published
  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • [ x] I have documented my code, including function, input, and output descriptions
  • [ x] My changes generate no new warnings
  • New and existing tests pass with my changes
  • [x ] This change is covered by an existing CI test or a new one has been added
  • [ x] Any new scripts have been added to the .github/CODEOWNERS file with owners
  • [ x] I have made corresponding changes to the system documentation if necessary

@jswhit jswhit requested a review from aerorahul as a code owner December 8, 2025 19:10
aerorahul
aerorahul approved these changes Dec 8, 2025
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CatherineThomas-NOAA
CatherineThomas-NOAA approved these changes Dec 8, 2025
View reviewed changes
Copy link
Contributor

@CatherineThomas-NOAA CatherineThomas-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jswhit, looks good to me. Approved pending g-w CI testing. I'm currently running the suite on Gaea-C6.

@CatherineThomas-NOAA
Copy link
Contributor

CatherineThomas-NOAA commented Dec 9, 2025

Global-workflow CI passes on Gaea-C6:

SKIP C48_ATM_ecflow on gaeac6
 
/gpfs/f6/gfs-cpu/world-shared/Catherine.Thomas/RUNTESTS_gsi/EXPDIR/C48_ATM_gsi
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Dec 08 2025 22:05:09    Dec 09 2025 01:45:15
 
/gpfs/f6/gfs-cpu/world-shared/Catherine.Thomas/RUNTESTS_gsi/EXPDIR/C48mx500_3DVarAOWCDA_gsi
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    Dec 08 2025 22:05:06    Dec 08 2025 23:05:22
202103250000        Done    Dec 08 2025 22:05:06    Dec 09 2025 02:15:22
 
/gpfs/f6/gfs-cpu/world-shared/Catherine.Thomas/RUNTESTS_gsi/EXPDIR/C48mx500_hybAOWCDA_gsi
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    Dec 08 2025 22:05:07    Dec 08 2025 23:05:21
202103250000        Done    Dec 08 2025 22:05:07    Dec 09 2025 01:55:10
 
SKIP C48_S2SWA_gefs_RT on gaeac6
 
/gpfs/f6/gfs-cpu/world-shared/Catherine.Thomas/RUNTESTS_gsi/EXPDIR/C48_S2SWA_gefs_gsi
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Dec 08 2025 22:05:22    Dec 09 2025 02:05:06
 
SKIP C48_S2SW_extended on gaeac6
 
/gpfs/f6/gfs-cpu/world-shared/Catherine.Thomas/RUNTESTS_gsi/EXPDIR/C48_S2SW_gsi
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Dec 08 2025 22:05:06    Dec 09 2025 01:15:20
 
SKIP C96_atm3DVar_extended on gaeac6
 
/gpfs/f6/gfs-cpu/world-shared/Catherine.Thomas/RUNTESTS_gsi/EXPDIR/C96_atm3DVar_gsi
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    Dec 08 2025 22:05:06    Dec 08 2025 23:05:20
202112210000        Done    Dec 08 2025 22:05:06    Dec 09 2025 02:15:22
202112210600        Done    Dec 08 2025 22:05:06    Dec 09 2025 02:05:07
 
/gpfs/f6/gfs-cpu/world-shared/Catherine.Thomas/RUNTESTS_gsi/EXPDIR/C96C48_hybatmDA_gsi
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    Dec 08 2025 22:05:06    Dec 08 2025 23:05:21
202112210000        Done    Dec 08 2025 22:05:06    Dec 09 2025 02:10:07
202112210600        Done    Dec 08 2025 22:05:06    Dec 09 2025 02:35:22
 
/gpfs/f6/gfs-cpu/world-shared/Catherine.Thomas/RUNTESTS_gsi/EXPDIR/C96C48_hybatmsnowDA_gsi
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    Dec 08 2025 22:05:08    Dec 08 2025 23:50:07
202112201800        Done    Dec 08 2025 22:05:08    Dec 09 2025 02:15:23
202112210000        Done    Dec 08 2025 22:05:08    Dec 09 2025 02:40:14
 
/gpfs/f6/gfs-cpu/world-shared/Catherine.Thomas/RUNTESTS_gsi/EXPDIR/C96C48_hybatmsoilDA_gsi
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202205150600        Done    Dec 08 2025 22:05:21    Dec 08 2025 23:00:10
202205151200        Done    Dec 08 2025 22:05:21    Dec 09 2025 02:10:06
202205151800        Done    Dec 08 2025 22:05:21    Dec 09 2025 02:40:30
 
/gpfs/f6/gfs-cpu/world-shared/Catherine.Thomas/RUNTESTS_gsi/EXPDIR/C96C48mx500_S2SW_cyc_gfs_gsi
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    Dec 08 2025 22:05:09    Dec 08 2025 23:25:09
202112201800        Done    Dec 08 2025 22:05:09    Dec 09 2025 03:20:14
202112210000        Done    Dec 08 2025 22:05:09    Dec 09 2025 05:10:27
 
SKIP C96C48_ufsgsi_hybatmDA on gaeac6
 
SKIP C96C48_ufs_hybatmDA on gaeac6
 
/gpfs/f6/gfs-cpu/world-shared/Catherine.Thomas/RUNTESTS_gsi/EXPDIR/C96_gcafs_cycled_noDA_gsi
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    Dec 08 2025 22:05:06    Dec 09 2025 00:00:21
202112201800        Done    Dec 08 2025 22:05:06    Dec 09 2025 02:05:06
202112210000        Done    Dec 08 2025 22:05:06    Dec 09 2025 01:05:23
 
/gpfs/f6/gfs-cpu/world-shared/Catherine.Thomas/RUNTESTS_gsi/EXPDIR/C96_gcafs_cycled_gsi
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    Dec 08 2025 22:05:06    Dec 08 2025 23:00:10
202112201800        Done    Dec 08 2025 22:05:06    Dec 09 2025 02:05:09
202112210000        Done    Dec 08 2025 22:05:06    Dec 09 2025 01:45:16
 
/gpfs/f6/gfs-cpu/world-shared/Catherine.Thomas/RUNTESTS_gsi/EXPDIR/C96mx100_S2S_gsi
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
199405010000        Done    Dec 08 2025 22:05:06    Dec 09 2025 01:20:23

@CatherineThomas-NOAA
Copy link
Contributor

CatherineThomas-NOAA commented Dec 9, 2025

For the test C96C48mx500_S2SW_cyc_gfs, which is a low resolution v17-like configuration, ABI G19 is listed in the obs_input section of the log:

0:  abibufr              abi         g19         abi_g19                    0.00   1   0       3.00

This test's CDATE is too early for G19, but the GSI is now attempting to process the sensor. The PR is working as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aerorahul aerorahul aerorahul approved these changes

@CatherineThomas-NOAA CatherineThomas-NOAA CatherineThomas-NOAA approved these changes

@RussTreadon-NOAA RussTreadon-NOAA Awaiting requested review from RussTreadon-NOAA

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update GSI hash to include ABI G19 in build_gsinfo

3 participants

@jswhit @CatherineThomas-NOAA @aerorahul