221.Add force checkout and compile functionality #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eckout-and-compile -also fix decorator function in `run_fremake.py`
…rce-checkout-and-compile
…rce-checkout-and-compile
…rce-checkout-and-compile
…rce-checkout-and-compile
- code was repeated if `--force-compile` was used
- code was repeated if `--force-checkout`, `--force-compile` or `--force-dockerfile` was used
- code would be duplicated if `--force-dockerfile` option is used
…consistency
…rce-checkout-and-compile
…rce-checkout-and-compile
…rce-checkout-and-compile
…rce-checkout-and-compile
|
Looks fairly well thought out to me here- any tests coming? maybe add quick desc of what the PR adds in plain english when you can! |
Oh wait! I can totally add test to test_run_fremake since that's in there already. (I can also add to the compile test I have going in a PR and work with Avery to add tests for checkout). Maybe the compile test can be merged in first - then I can add to it to test this functionality. Also good idea on the description, I think I meant to add to it when I took it out of draft but then forgot |
|
@ilaflott Thanks for taking a look in your spare time btw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds
force-checkoutforce-compileforce-dockerfileThese make it easier to edit scripts in between steps. Previously, if steps were run to make scripts, then re-run, there would just be a print statement that the script existed already. However, if the user wanted to change something, let's say in the checkout script, then re-run to execute it, that functionality was not there. They would've had to edit something in their configuration and start over.
Issue ticket number and link (if applicable)
https://github.com/orgs/NOAA-GFDL/projects/32?pane=issue&itemId=85061800&issue=NOAA-GFDL%7Cfre-cli%7C221
Checklist before requesting a review