Conversation
…e-make-compile-test
…e-make-compile-test
kiihne-noaa
left a comment
There was a problem hiding this comment.
looks good to me! We discussed a number of these changes last week.
fre/make/create_compile_script.py
Outdated
There was a problem hiding this comment.
why click.echo instead of print or logger ?
There was a problem hiding this comment.
Good question. I believe Bennett made it click.echo, which was a cool thing to keep with click functionalities. I think I read somewhere that it might've been preferred (vs print) so I kept it in
|
|
||
| # Check for creation of compile script, FMS directory, | ||
| # log.compile file, the executable | ||
| assert Path(f"{OUT}/fremake_canopy/test/null_model_full/{plat}-{targ}/exec/compile.sh").exists() |
There was a problem hiding this comment.
f"{OUT}/fremake_canopy/test/null_model_full/{plat}-{targ}/exec/" could definitely be assigned to its own variable somewhere. unless you wanna edit the path in several places later upon needed to extend/fix something
There was a problem hiding this comment.
the platforms and targets sometimes change (test for bad platforms and targets or multi)
There was a problem hiding this comment.
sometimes functions like this:
some_func(arg1_val, arg2_val, arg3_val ...)
are nicer when written out like this:
some_func(arg1 = arg1_val,
arg2 = arg2_val,
arg3 = arg3_val ...)
ilaflott
left a comment
There was a problem hiding this comment.
it works, if needing some cleanup. Granting approval, but the only clarification i'm really wondering: why click.echo in create_compile_script ?
the requested change was addressed and i resolved the feedback- not sure why this is still blocked based on that alone.
Describe your changes
Add create-compile test
Issue ticket number and link (if applicable)
#224
Checklist before requesting a review