224.fre make compile test #295
Conversation
…e-make-compile-test
…e-make-compile-test
| # Check for creation of compile script | ||
| # Check for FMS directory | ||
| # Check for log.compile file | ||
| assert [Path(f"{OUT}/fremake_canopy/test/null_model_full/{plat}-{targ}/exec/compile.sh").exists(), |
There was a problem hiding this comment.
I think this should probably also check for the executable file too, the other files might still be there if it failed.
There was a problem hiding this comment.
Thanks for this catch! You're 100% right
There was a problem hiding this comment.
So I can't actually run the full compile here because it needs the checked out source code and the makefile (which are not made in this test). I can change the test name though to something more informative like "test_compile_execution_logfile_creation" or something (b/c even though the compile fails, the test passes since those paths are there)
Or, I can include that path check for the executable but mark the test as fail.
Thoughts?
There was a problem hiding this comment.
Ok, I suppose my first though there might be covered by def test_bad_target_compilelog():
There was a problem hiding this comment.
Update: I forgot I can just set an assert equal to False
Describe your changes
Issue ticket number and link (if applicable)
Checklist before requesting a review