-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container2step #300
base: main
Are you sure you want to change the base?
Container2step #300
Conversation
Improves error messages in container platform section
Did i break this? |
""" | ||
container_plat = CONTAINER_PLAT2[0] | ||
yamlfile_path = f"{TEST_DIR}/{NM_EXAMPLE}/{YAMLFILE}" | ||
create_makefile_script.makefile_create(yamlfile_path,container_plat,TARGET) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try just passing create_makefile_script.makefile_create(yamlfile_path,CONTAINER_PLAT2,TARGET)
instead. I'm pretty sure either the platformfre.py
or yamlfre.py
file is looking for a list that is passed. I used something like container_plat = CONTAINER_PLAT2[0]
in some other tests mainly for assertions for directory names I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That worked!
This needs an update to the schema submodule. NOAA-GFDL/gfdl_msd_schemas#17 |
Describe your changes
Adds two-step container build capability to fre make
Issue ticket number and link (if applicable)
#266
Checklist before requesting a review