Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container2step #300

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

thomas-robinson
Copy link
Member

@thomas-robinson thomas-robinson commented Dec 23, 2024

Describe your changes

Adds two-step container build capability to fre make

Issue ticket number and link (if applicable)

#266

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback

@thomas-robinson
Copy link
Member Author

Did i break this?

"""
container_plat = CONTAINER_PLAT2[0]
yamlfile_path = f"{TEST_DIR}/{NM_EXAMPLE}/{YAMLFILE}"
create_makefile_script.makefile_create(yamlfile_path,container_plat,TARGET)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try just passing create_makefile_script.makefile_create(yamlfile_path,CONTAINER_PLAT2,TARGET) instead. I'm pretty sure either the platformfre.py or yamlfre.py file is looking for a list that is passed. I used something like container_plat = CONTAINER_PLAT2[0] in some other tests mainly for assertions for directory names I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That worked!

@thomas-robinson thomas-robinson marked this pull request as draft December 23, 2024 18:17
@thomas-robinson
Copy link
Member Author

thomas-robinson commented Dec 23, 2024

This needs an update to the schema submodule. NOAA-GFDL/gfdl_msd_schemas#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants