Skip to content

Conversation

@uramirez8707
Copy link
Contributor

@uramirez8707 uramirez8707 commented Feb 24, 2025

Describe your changes

add the ability to specify the location of the output container

Issue ticket number and link (if applicable)

Fixes #333
Requires NOAA-GFDL/gfdl_msd_schemas#21

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

@uramirez8707
Copy link
Contributor Author

@singhd789 let me know if there is any documentation that needs to be updated as well.

@singhd789 singhd789 self-requested a review June 10, 2025 16:51
@singhd789
Copy link
Collaborator

@singhd789 let me know if there is any documentation that needs to be updated as well.

I think the main change here is adding containerOutputLocation in the platforms.yaml. Can you add it to this doc as well?: (the docs are going to be updated anyway but it would be good to include so we don't forget about it)

https://github.com/NOAA-GFDL/fre-cli/blob/main/docs/usage/yaml_dev/platforms_yaml.rst

Copy link
Collaborator

@singhd789 singhd789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good! Thank you! Let's just make sure the test works.

@singhd789 singhd789 self-requested a review June 11, 2025 21:25
Copy link
Collaborator

@singhd789 singhd789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woooo! 🎊

@singhd789 singhd789 merged commit c8cf4c9 into NOAA-GFDL:main Jun 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Specify container location in fre make

2 participants