Skip to content

Fix force-checkout functionality with fre make checkout-script#790

Open
singhd789 wants to merge 4 commits intoNOAA-GFDL:mainfrom
singhd789:force-checkout-fix
Open

Fix force-checkout functionality with fre make checkout-script#790
singhd789 wants to merge 4 commits intoNOAA-GFDL:mainfrom
singhd789:force-checkout-fix

Conversation

@singhd789
Copy link
Contributor

@singhd789 singhd789 commented Mar 19, 2026

Describe your changes

  • change order of function argument force_checkout
  • make force_checkout have default value = False
  • update test to include force_checkout
  • write test to make sure force_checkout is working with fre make all subtool

Issue ticket number and link (if applicable)

n/a (fixing a bug)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

Note: If you are a code maintainer updating the tag or releasing a new fre-cli version, please use the release_procedure.md template. To quickly use this template, open a new pull request, choose your branch, and add ?template=release_procedure.md to the end of the url.

@singhd789 singhd789 requested a review from uramirez8707 March 19, 2026 20:14
@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.22%. Comparing base (15f6c06) to head (4e00d25).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #790   +/-   ##
=======================================
  Coverage   84.22%   84.22%           
=======================================
  Files          70       70           
  Lines        4773     4773           
=======================================
  Hits         4020     4020           
  Misses        753      753           
Flag Coverage Δ
unittests 84.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
fre/make/fremake.py 95.58% <ø> (ø)
fre/make/run_fremake_script.py 97.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15f6c06...4e00d25. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@uramirez8707 uramirez8707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this Dana. The code changes look good to me. I will do more testing once the module has been created on GAEA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants