-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analysis updates #11
Analysis updates #11
Conversation
ceblanton
commented
Aug 19, 2024
•
edited
Loading
edited
- Add build and publish graph for analysis scripts that specify them; done
- Generate catalog before running analysis; done
- Remove mdtf as a standalone task; done
- Add build and publish task definitions; not quite working
- Use analysis yaml instead of the analysis/rose-app.conf
But only for analysis scripts that use timeseries.
…ions For now, keep the task definition in flow.cylc but it can be elsewhere.
…ed-interval analysis
…nalysis intervals with [^] syntax
…lection - turn off some that usually fail - add install and publish scripts for the ray-analysis
…own reasons but succeeds on retry
…-script. Remaining rose apps should set the definition themselves.
- move module loads to ppan site file - install analysis virtual envs to a subdirectory - add one more fre analysis env var expected by scripts
- install analysis envs in a subdirectory - parse legacy analysis script options
Non-accumulative timeaverage requests must conform to one of the chunks in order to pass a single time to the script in "in_data_file"
…d Bronx frequency mappings for AM5 scripts
Set them to yr1 and yr2, though they have different meaning in Bronx
in order to choose the most appropriate one for each script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not going to approve/disapprove quite yet cause this is still a draft- but wanted to provide some prelim feedback!
@@ -1,5 +1,8 @@ | |||
#!jinja2 | |||
|
|||
{# fre version should be programatically set, not hard-coded. #} | |||
{% set FRE_VERSION = 2025.01 %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a "fine-for-now". In the future, a Jinja2Filter
should assign this via import fre; fre.version;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point, thank you. You make it sound quite doable! We should do it right away if it's only three words like that.
…47.catalogs-before-analysis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM/Approving! We need real-use feedback, any nits i pointed out are fine for now. the switch DO_ANALYSIS
exists for a reason and we can always shut things down if they are problematic.