Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve names in grid roundtrip. #66

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Preserve names in grid roundtrip. #66

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
52c1809
Add mesh schema objects.
groutr Mar 30, 2021
8070935
Reuse dimension and variable mappings.
groutr Mar 30, 2021
35f6990
Init dictionary with values.
groutr Apr 1, 2021
e1e277d
Updates to Mesh classes.
groutr Apr 1, 2021
da8111e
Add node_coordinates alias
groutr Apr 1, 2021
a6a5e02
factor out key filter
groutr Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gridded/pyugrid/ugrid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,8 @@ def num_vertices(self):
def nodes(self):
return self._nodes

node_coordinates = nodes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look at the rest of the code, but I'd rather not add aliases for existing names -- and we really don't want to change the names.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisBarker-NOAA see my explanation here: #65 (comment)


@property
def node_lon(self):
return self._nodes[:, 0]
Expand Down