Skip to content

[1pt] PR: Update get_sample_data.py for lidar bridge elevation data #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 91 commits into
base: dev
Choose a base branch
from

Conversation

mluck
Copy link
Contributor

@mluck mluck commented Apr 2, 2025

Updates data/get_sample_data.py for changes in input data resulting from the addition of lidar bridge elevation. Resolves #1443 and supersedes #1452 and closes #1575.

Changes

  • data/get_sample_data.py: Updated input files and creates a VRT for bridge elevation diff.
  • fim_post_processing.sh: Used WBD environment variable instead of hardcoding.

Testing

Ran fim_pipeline.sh on HUCs 06010108 and 10280103.

Deployment Plan (For developer use)

How does the changes affect the product?

  • Code only?
  • If applicable, has a deployment plan be created with the deployment person/team?
  • Require new or adjusted data inputs? Does it have start, end and duration code (in UTC)?
  • If new or updated data sets, has the FIM code been updated and tested with the new/adjusted data (subset is fine, but must be a subset of the new data)?
  • Require new pre-clip set?
  • Has new or updated python packages?

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g. dev-revise-levee-masking)
  • Changes are limited to a single goal (no scope creep)
  • The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
  • pre-commit hooks were run locally
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • CHANGELOG updated with template version number, e.g. 4.x.x.x
  • Add yourself as an assignee in the PR as well as the FIM Technical Lead

Merge Checklist (For Technical Lead use only)

  • Update CHANGELOG with latest version number and merge date
  • Update the Citation.cff file to reflect the latest version number in the CHANGELOG
  • If applicable, update README with major alterations

AliForghani-NOAA and others added 30 commits December 27, 2024 06:44
@mluck mluck added bug Something isn't working Inputs For getting new data, updating data, changing inputs, etc labels Apr 2, 2025
@mluck mluck requested a review from RobHanna-NOAA April 2, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Inputs For getting new data, updating data, changing inputs, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1pt] Incorrect hardcoded file path in post-processing [8pt] Get Samples broken after new lidar bridges system
4 participants