Skip to content

[1pt]: PR: Docker merge depbot and overpy packages #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 25, 2025

Conversation

RobHanna-NOAA
Copy link
Contributor

@RobHanna-NOAA RobHanna-NOAA commented Jun 16, 2025

Decided to make a separate PR to incorporate both the depbot requests PR 1550. (Bump requests from 2.32.3 to 2.32.4), PR 1567. (Bump urllib3) and add overpay for an up and coming python package for the new roads system.

Changes

  • Pipfile, Pipfile.lock: as described.

Testing

  • created a new docker image, and tested it against an incoming PR 1543 for roads. In that PR, this image was used to ensure that the pull_osm_roads file worked and they were fine.
  • Also bumped up urllib and had to test urllib on OWP servers. I used generate_categorical_fim.py to validate it. Pulled just a small catfim set to validate the update to urllib.

Deployment Plan (For developer use)

How does the changes affect the product?

  • Code only?
  • If applicable, has a deployment plan be created with the deployment person/team?
  • Require new or adjusted data inputs? Does it have start, end and duration code (in UTC)?
  • If new or updated data sets, has the FIM code been updated and tested with the new/adjusted data (subset is fine, but must be a subset of the new data)?
  • Require new pre-clip set?
  • Has new or updated python packages?

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g. dev-revise-levee-masking)
  • Changes are limited to a single goal (no scope creep)
  • The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
  • n/a - pre-commit hooks were run locally
  • [x ] Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • CHANGELOG updated with template version number, e.g. 4.x.x.x
  • Add yourself as an assignee in the PR as well as the FIM Technical Lead

Merge Checklist (For Technical Lead use only)

  • Update CHANGELOG with latest version number and merge date
  • Update the Citation.cff file to reflect the latest version number in the CHANGELOG
  • If applicable, update README with major alterations

dependabot bot and others added 2 commits June 10, 2025 08:56
Bumps [requests](https://github.com/psf/requests) from 2.32.3 to 2.32.4.
- [Release notes](https://github.com/psf/requests/releases)
- [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md)
- [Commits](psf/requests@v2.32.3...v2.32.4)

---
updated-dependencies:
- dependency-name: requests
  dependency-version: 2.32.4
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@RobHanna-NOAA RobHanna-NOAA self-assigned this Jun 16, 2025
@RobHanna-NOAA RobHanna-NOAA added the dependencies Pull requests that update a dependency file label Jun 16, 2025
@RobHanna-NOAA RobHanna-NOAA changed the title WIP PR: Docker merge depbot and overpy packages [1pt]: Docker merge depbot and overpy packages Jun 16, 2025
@RobHanna-NOAA RobHanna-NOAA marked this pull request as ready for review June 16, 2025 20:32
@RobHanna-NOAA RobHanna-NOAA changed the title [1pt]: Docker merge depbot and overpy packages [1pt]: PR: Docker merge depbot and overpy packages Jun 16, 2025
@CarsonPruitt-NOAA CarsonPruitt-NOAA merged commit ae35c8c into dev Jun 25, 2025
1 check passed
@CarsonPruitt-NOAA CarsonPruitt-NOAA deleted the dev-docker-overpy branch June 25, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants