Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Update Discover-More #114

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Feat: Update Discover-More #114

wants to merge 5 commits into from

Conversation

GogoVega
Copy link
Collaborator

No description provided.

@GogoVega GogoVega added the documentation Improvements or additions to documentation label Jan 30, 2022
@GogoVega GogoVega marked this pull request as ready for review February 2, 2022 11:34
Copy link
Member

@crxporter crxporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment on contribution.md

thanks!

Copy link
Collaborator Author

@GogoVega GogoVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crxporter
crxporter previously approved these changes Feb 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2022

@github-actions github-actions bot temporarily deployed to commit March 30, 2022 09:50 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 30, 2022 09:50 Inactive

They can be marked that way for few reasons:
{{< alert icon="‼️" text="Beta versions may contain bug fixes and improvements!" />}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not special version :)
It is shipped in production release available via experimental mode.

-->

1. Install Node-RED on your new server
```bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```bash
```bash
  1. We should let empty line to be there
  2. Not sure if we need this indentation

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First without and second with indentation
Capture d’écran 2022-11-14 à 17 59 18

Co-authored-by: Tadeusz Wyrzykowski <[email protected]>
Comment on lines +15 to +16
These are beta versions containing possible future features.
We use beta versions to test and improve our features without compromising the experience of our users.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
These are beta versions containing possible future features.
We use beta versions to test and improve our features without compromising the experience of our users.
This mode provides access to possible future features for experienced users. These features are not yet fully tested or documented, may not be the final solution, and are subject to change at any time...

Comment on lines +18 to 19
{{< alert icon="‼️" text="Beta versions may contain bug fixes and improvements!" />}}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{< alert icon="‼️" text="Beta versions may contain bug fixes and improvements!" />}}
{{< alert icon="‼️" text="Using experimental mode is not recommended for new users!" />}}

Comment on lines +29 to +54
1. Install Node-RED on your new server
```bash
bash <(curl -sL https://raw.githubusercontent.com/node-red/linux-installers/master/deb/update-nodejs-and-nodered)
```
2. Install Node Modules used on your new server
```bash
cd /home/pi/.node-red/ && npm install node-red-contrib-homekit-bridged@latest
```
3. Shut down Node-RED on the old server
```bash
sudo node-red-stop
```
4. Copy over `homekit-persist` from the `.node-red` directory on the old server to the new server

5. Copy over `flows_<old machine's hostname>.json` from the `.node-red` directory on the old server to the new server

6. Rename the `flows_<old machine's hostname>.json` to `flows.json` on the new server.

7. Edit the `settings.js` file on the new server, and uncomment the line `flowFile: flows.json`
```bash
sudo nano /home/pi/.node-red/settings.js
```
8. (Re)Start Node-RED on your new server.
```bash
sudo node-red-start
```
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Install Node-RED on your new server
```bash
bash <(curl -sL https://raw.githubusercontent.com/node-red/linux-installers/master/deb/update-nodejs-and-nodered)
```
2. Install Node Modules used on your new server
```bash
cd /home/pi/.node-red/ && npm install node-red-contrib-homekit-bridged@latest
```
3. Shut down Node-RED on the old server
```bash
sudo node-red-stop
```
4. Copy over `homekit-persist` from the `.node-red` directory on the old server to the new server
5. Copy over `flows_<old machine's hostname>.json` from the `.node-red` directory on the old server to the new server
6. Rename the `flows_<old machine's hostname>.json` to `flows.json` on the new server.
7. Edit the `settings.js` file on the new server, and uncomment the line `flowFile: flows.json`
```bash
sudo nano /home/pi/.node-red/settings.js
```
8. (Re)Start Node-RED on your new server.
```bash
sudo node-red-start
```
1. Install Node-RED on your new server
```bash
bash <(curl -sL https://raw.githubusercontent.com/node-red/linux-installers/master/deb/update-nodejs-and-nodered)
```
2. Install Node Modules used on your new server
```bash
cd /home/pi/.node-red/ && npm install node-red-contrib-homekit-bridged@latest
```
3. Shut down Node-RED on the old server
```bash
sudo node-red-stop
```
4. Copy over `homekit-persist` from the `.node-red` directory on the old server to the new server
5. Copy over `flows_<old machine's hostname>.json` from the `.node-red` directory on the old server to the new server
6. Rename the `flows_<old machine's hostname>.json` to `flows.json` on the new server.
7. Edit the `settings.js` file on the new server, and uncomment the line `flowFile: flows.json`
```bash
sudo nano /home/pi/.node-red/settings.js
```
8. (Re)Start Node-RED on your new server.
```bash
sudo node-red-start
```

-->

1. Install Node-RED on your new server
```bash
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First without and second with indentation
Capture d’écran 2022-11-14 à 17 59 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants