ASHRAE Guideline 36, Section 4, Air-Side

[MatthewSteen]

Clean up for #263.

[MatthewSteen]

I removed the separate template in the original file, which didn't appear to work as intended in G36 because it's optional.

BuildingMOTIF/libraries/ashrae/guideline36/4.6-multiple-zone-vav-AHU.yml

Lines 34 to 50 in b1924b8

	# compose on the ahu's 'name'
	with-relief-damper:
	body: >
	@prefix p: <urn:___param___#> .
	@prefix brick: <https://brickschema.org/schema/Brick#> .
	p:name brick:hasPart p:relief-fan, p:relief-damper ;
	brick:hasPoint p:sp-sensor .
	p:relief-damper a brick:Exhaust_Damper .
	optional: ["sp-sensor"]
	dependencies:
	- template: relief-fan
	args: {"name": "relief-fan"}
	- template: damper
	args: {"name": "relief-damper"}
	- template: https://brickschema.org/schema/Brick#Static_Pressure_Sensor
	library: https://brickschema.org/schema/1.4/Brick
	args: {"name": "sp-sensor"}

[MatthewSteen]

I removed the separate template in the original file, which didn't appear to work as intended in G36 because it's optional.

BuildingMOTIF/libraries/ashrae/guideline36/4.6-multiple-zone-vav-AHU.yml

Lines 52 to 73 in b1924b8

	with-return-fan:
	body: >
	@prefix p: <urn:___param___#> .
	@prefix brick: <https://brickschema.org/schema/Brick#> .
	p:name brick:hasPart p:return-fan ;
	brick:hasPoint p:supply-air-flow, p:return-air-flow, p:sp-sensor .
	p:relief-damper a brick:Exhaust_Damper .
	optional: ["supply-air-flow", "return-air-flow", "sp-sensor"]
	dependencies:
	- template: return-fan
	args: {"name": "return-fan"}
	- template: damper
	args: {"name": "relief-damper"}
	- template: https://brickschema.org/schema/Brick#Static_Pressure_Sensor
	library: https://brickschema.org/schema/1.4/Brick
	args: {"name": "sp-sensor"}
	- template: https://brickschema.org/schema/Brick#Supply_Air_Flow_Sensor
	library: https://brickschema.org/schema/1.4/Brick
	args: {"name": "supply-air-flow"}
	- template: https://brickschema.org/schema/Brick#Return_Air_Flow_Sensor
	library: https://brickschema.org/schema/1.4/Brick
	args: {"name": "return-air-flow"}

[MatthewSteen]

I had to make the object here a brick:Fan class instead of p:name a p:constant-speed-fan (from components.yml like the TTL file) because it failed test_library.py. There are a couple/few cases where this may be convenient and might be worth revisiting during a future template discussion/refactor.

cls = <class 'buildingmotif.dataclasses.library._template_dependency'>, d = {'args': {'name': 'cav-fan'}}, dependent_library_name = 'guideline36'

    @classmethod
    def from_dict(
        cls, d: Dict[str, Any], dependent_library_name: str
    ) -> "_template_dependency":
        """Creates a py:class:`_template_dependency` from a dictionary.

        :param d: dictionary
        :type d: Dict[str, Any]
        :param dependent_library_name: library name
        :type dependent_library_name: str
        :return: the _template_dependency from the dict
        :rtype: _template_dependency
        """
>       template_name = d["template"]
E       KeyError: 'template'

buildingmotif/dataclasses/library.py:63: KeyError

[MatthewSteen]

@gtfierro this is ready. Please specifically review the template body syntax.

I think the CI test failure is unrelated and will fix in the guideline36-section4 branch if still present.

FAILED tests/unit/api/test_model.py::test_test_model_against_shapes[pyshacl] - sqlalchemy.exc.NoResultFound: No template found with name https://brickschema.org/schema/Brick#Leaving_Chilled_Water_Flow_Sensor
FAILED tests/unit/api/test_model.py::test_test_model_against_shapes[topquadrant] - sqlalchemy.exc.NoResultFound: No template found with name https://brickschema.org/schema/Brick#Leaving_Chilled_Water_Flow_Sensor

[gtfierro]

@MatthewSteen I've gone through the templates and I think they look good. The rdf:Alt syntax will eventually need to be supported in buildingMOTIF but I have no other comments. I'm running tests locally on these to verify everything works.

Some of the missing classes like the Leaving_Chilled_Water_Flow_Sensor are probably failing because the copy of Brick is old (v1.4.1 of Brick has this class, for example: https://ontology.brickschema.org/brick/Leaving_Chilled_Water_Flow_Sensor.html).

[MatthewSteen]

@gtfierro thanks. Should we update Brick to 1.4 in a separate PR? I've updated the templates here and will do the same in the base branch.

[gtfierro]

@gtfierro thanks. Should we update Brick to 1.4 in a separate PR? I've updated the templates here and will do the same in the base branch.

Yes, I think that's the right move. I'll handle that momentarily

[MatthewSteen]

@gtfierro are you ok with merging this into the base G36 branch?

[gtfierro]

Yes! Sounds good to me. I can help fix some other validation issues this weekend

[MatthewSteen]

Great! I'll merge and finalize in the base G36 branch.