Equipment Summary Air Heat Recovery Fixes #10995

mjwitte · 2025-03-18T00:49:54Z

Pull request overview

Fixes Equipment Summary - Air Heat Recovery table values #10985

Description of the purpose of this PR

Pull Request Author

Reviewer

github-actions · 2025-03-18T01:46:27Z

⚠️ Regressions detected on macos-14 for commit `21dc48f`

Regression Summary

Table Big Diffs: 736
Table String Diffs: 735

mjwitte · 2025-03-18T16:54:28Z

Here is a sample of the current table for OutdoorAirUnit.idf.

Here are some samples of the revised table. Note the changes from FlatPlate to Plate, and from [kg/s] to [m3/s].

DesiccantDehumidifierWithCompanionCoil

ASHRAE901_HotelLarge_STD2019_Denver

OutdoorAirUnit

rraustad · 2025-03-18T17:08:32Z

src/EnergyPlus/HeatRecovery.hh

        int CoolEffectLatentCurveIndex = 0;   // cooling latent effectiveness multiplier curve to CoolEffectLatent100
        // 1 = None, 2 = Bypass, 3 = Stop Rotary HX Rotation
-        HXConfigurationType ExchConfig = HXConfigurationType::Invalid; // parameter equivalent of HX configuration, plate or rotary
+        HXConfigurationType ExchConfig = HXConfigurationType::Rotary; // parameter equivalent of HX configuration, plate or rotary


Not standard but I assume this was done for the sake of the desiccant HX (as opposed to leaving this as invalid and setting Rotary in the desiccant HX getInput). If no other changes, which I don't expect since these changes and results look good, leave as is.

It was a punt to fix a unit test (maybe more than one?) that didn't do getInput and was throwing a vector error when trying to fill the table in size. I can undo this and set it properly in the unit test and add some asserts to protect that.

This change would be good to get into the latest release so I figured it could go as-is. There's still a few days left so it's up to you how you handle clean-up changes.

But there are OutputChanges (delete duplicate Name column, and change units on two columns), so I'm not sure this will be allowed in for 25.1. @Myoldmopar?

OK, then you have plenty of time.

You can also consider whether to change "Outdoor Airflow" to "Supply AirFlow".

You can also consider whether to change "Outdoor Airflow" to "Supply AirFlow".

Hmm, so they're currently called "Exhaust" and "Outdoor", but the three HXs all use different terminology:
HeatExchanger:AirToAir:FlatPlate: Supply and Secondary
HeatExchanger:AirToAir:SensibleAndLatent: Supply and Exhaust
HeatExchanger:Desiccant:BalancedFlow: Process and Regeneration

@JasonGlazer Any preference?

It would be good to use a consistent set of terms. I think AHRI probably has a standard on this, maybe we should see what terms it uses.

It would be good to use a consistent set of terms. I think AHRI probably has a standard on this, maybe we should see what terms it uses.

Supply and Exhaust, based on these two docs:
https://www.airxchange.com/wp-content/uploads/2019/07/AHRI-Guideline-W-2005.pdf
https://www.airxchange.com/wp-content/uploads/2019/07/AHRI-Standard-1060-I-P-2013.pdf

github-actions · 2025-03-18T20:24:27Z

⚠️ Regressions detected on macos-14 for commit `17347e0`

Regression Summary

Audit: 794

mjwitte · 2025-03-18T21:32:31Z

An updated example table.

rraustad · 2025-03-18T22:36:53Z

That looks very good. Why 0.63 and 0.43 in lower right corner? Never mind, that's the HX with both inputs.

rraustad · 2025-03-18T23:09:15Z

I just noticed you got rid of the duplicate name column. Put the header column title back as "Name" ?

rraustad · 2025-03-18T23:12:36Z

And maybe change the title "Input object type" to just "Type" like other tables.

JasonGlazer · 2025-03-19T13:17:12Z

Looking good!

mjwitte · 2025-03-20T20:50:55Z

I just noticed you got rid of the duplicate name column. Put the header column title back as "Name" ?

Well, most table reports have no heading in the first column.

I suppose we could change that. @JasonGlazer is there a way to place a header in the first column with current functions?

And maybe change the title "Input object type" to just "Type" like other tables.
Ok, done (locally).

mjwitte · 2025-03-20T20:53:05Z

From #10985 (comment)

I'll go with repeating the nominal supply flow, unless you object.

Can we report the maximum flow also?

@JasonGlazer Is this still something we want here? It would be a simulation result rather than documenting an input.

JasonGlazer · 2025-03-20T20:56:18Z

I suppose we could change that. @JasonGlazer is there a way to place a header in the first column with current functions?

I don't think there is a way to do that, but it could be added if it is important. newPreDefSubTable() could have another optional argument that would be the first column heading. I have thought about this before but decided in the past that it probably didn't matter too much.

JasonGlazer · 2025-03-20T20:57:10Z

@JasonGlazer Is this still something we want here? It would be a simulation result rather than documenting an input.

Results are welcome!

github-actions · 2025-03-20T23:16:45Z

⚠️ Regressions detected on macos-14 for commit `45a01d7`

Regression Summary

Audit: 794

mjwitte · 2025-03-21T17:48:46Z

Here's the latest version of the table (for OutdoorAirUnit.idf):

This is ready for final review after v25.1 is released. (The output changes will need to be moved the the 25.2 file at some point).

github-actions · 2025-04-09T17:02:02Z

⚠️ Regressions detected on macos-14 for commit `351897c`

Regression Summary

Audit: 794

nrel-bot-2 · 2025-05-09T00:42:14Z

@Myoldmopar @mjwitte @Myoldmopar it has been 29 days since this pull request was last updated.

Myoldmopar

All good here. Will run some quick local testing, but expect this to merge shortly.

Myoldmopar · 2025-05-27T16:55:59Z

src/EnergyPlus/DataHVACGlobals.hh

        Invalid = -1,
        AirToAir_FlatPlate,
-        AirToAir_Generic,
+        AirToAir_SensAndLatent,


That is a bit nicer naming.

Myoldmopar · 2025-05-27T16:58:43Z

src/EnergyPlus/HeatRecovery.cc

+            CompName = thisBDDPerf.Name;
+            CompType = thisBDDPerf.PerfType;
+            SizingString = thisBDDPerf.NumericFieldNames(FieldNum) + " [m3/s]";
+            TempSize = thisBDDPerf.NomSupAirVolFlow;


Nice and readable here.

Myoldmopar · 2025-05-27T16:58:58Z

src/EnergyPlus/HeatRecovery.cc

+            OutputReportPredefined::PreDefTableEntry(state, state.dataOutRptPredefined->pdchAirHRSenEffAt100PerCoolAirFlow, this->Name, "N/A");
+            OutputReportPredefined::PreDefTableEntry(state, state.dataOutRptPredefined->pdchAirHRLatEffAt100PerHeatAirFlow, this->Name, "N/A");
+            OutputReportPredefined::PreDefTableEntry(state, state.dataOutRptPredefined->pdchAirHRLatEffAt100PerCoolAirFlow, this->Name, "N/A");
+        }


Good output report changes here.

Myoldmopar · 2025-05-27T16:59:13Z

tst/EnergyPlus/unit/HeatRecovery.unit.cc

+              OutputReportPredefined::RetrievePreDefTableEntry(*state, state->dataOutRptPredefined->pdchAirHRLatEffAt100PerCoolAirFlow, compName));
+
+    EXPECT_EQ("1.00", OutputReportPredefined::RetrievePreDefTableEntry(*state, state->dataOutRptPredefined->pdchAirHRSupplyAirflow, compName));
+    EXPECT_EQ("1.00", OutputReportPredefined::RetrievePreDefTableEntry(*state, state->dataOutRptPredefined->pdchAirHRExhaustAirflow, compName));


Myoldmopar · 2025-05-27T17:30:29Z

Needed to resolve conflicts just from the output changes file. I'll let CI run, but this is all happy locally and should be good to merge shortly.

github-actions · 2025-05-27T18:26:33Z

⚠️ Regressions detected on macos-14 for commit `39cd0f7`

Regression Summary

Audit: 794
Table Big Diffs: 736

Myoldmopar · 2025-05-28T13:54:11Z

Alright, this seems ready to go now. CI is happy, and I just did a sanity check right now. Thanks @mjwitte !

Equip Summary Air Heat Recovery fixes

6ccc833

mjwitte added Defect Includes code to repair a defect in EnergyPlus OutputChange Code changes output in such a way that it cannot be merged after IO freeze labels Mar 18, 2025

mjwitte added this to the EnergyPlus 25.2 IO Freeze milestone Mar 18, 2025

more Equip Summary Air Heat Recovery fixes

2147e41

rraustad approved these changes Mar 18, 2025

View reviewed changes

mjwitte added 4 commits March 18, 2025 12:35

Proper unit test fix

9abf609

Delete redundant Name column

e30773f

Reorder/rename air flow columns

e1174f2

Output changes doc

4a9a98b

mjwitte marked this pull request as ready for review March 19, 2025 01:58

Merge remote-tracking branch 'remotes/origin/develop' into rpdTables1

dab7d92

mjwitte added 2 commits March 20, 2025 16:31

Change type heading

ce9d7a0

Extend unit tests

77b1711

mjwitte added 2 commits April 9, 2025 10:38

Merge remote-tracking branch 'remotes/origin/develop' into rpdTables1

81fc03f

Move output changes to 25-2-0

2125bfd

Myoldmopar self-assigned this Apr 9, 2025

Myoldmopar approved these changes May 27, 2025

View reviewed changes

Myoldmopar added 2 commits May 27, 2025 12:01

Merge develop; resolve conflict

d894d53

Merge remote-tracking branch 'origin/develop' into rpdTables1

70509c5

Myoldmopar merged commit 7453159 into develop May 28, 2025
9 checks passed

Myoldmopar deleted the rpdTables1 branch May 28, 2025 13:54

mjwitte added the RPD label Aug 4, 2025

Equipment Summary Air Heat Recovery Fixes #10995

Equipment Summary Air Heat Recovery Fixes #10995

Uh oh!

Conversation

mjwitte commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request overview

Description of the purpose of this PR

Pull Request Author

Reviewer

Uh oh!

github-actions bot commented Mar 18, 2025

⚠️ Regressions detected on macos-14 for commit 21dc48f

Uh oh!

mjwitte commented Mar 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 18, 2025

⚠️ Regressions detected on macos-14 for commit 17347e0

Uh oh!

mjwitte commented Mar 18, 2025

Uh oh!

rraustad commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rraustad commented Mar 18, 2025

Uh oh!

rraustad commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JasonGlazer commented Mar 19, 2025

Uh oh!

mjwitte commented Mar 20, 2025

Uh oh!

mjwitte commented Mar 20, 2025

Uh oh!

JasonGlazer commented Mar 20, 2025

Uh oh!

JasonGlazer commented Mar 20, 2025

Uh oh!

github-actions bot commented Mar 20, 2025

⚠️ Regressions detected on macos-14 for commit 45a01d7

Uh oh!

mjwitte commented Mar 21, 2025

Uh oh!

github-actions bot commented Apr 9, 2025

⚠️ Regressions detected on macos-14 for commit 351897c

Uh oh!

nrel-bot-2 commented May 9, 2025

Uh oh!

Myoldmopar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Myoldmopar commented May 27, 2025

Uh oh!

mjwitte commented Mar 18, 2025 •

edited

Loading

⚠️ Regressions detected on macos-14 for commit `21dc48f`

⚠️ Regressions detected on macos-14 for commit `17347e0`

rraustad commented Mar 18, 2025 •

edited

Loading

rraustad commented Mar 18, 2025 •

edited

Loading

⚠️ Regressions detected on macos-14 for commit `45a01d7`

⚠️ Regressions detected on macos-14 for commit `351897c`

⚠️ Regressions detected on macos-14 for commit `39cd0f7`