Add AirflowNetwork opening scheduling #11015

jasondegraw · 2025-03-31T21:46:50Z

Pull request overview

This PR builds on previous work done related to linkage scheduling and adds the ability to schedule openings when using the AirflowNetwork feature.

Pull Request Author

Reviewer

…scheduling

github-actions · 2025-04-01T00:57:19Z

⚠️ Regressions detected on macos-14 for commit `5d555cb`

Regression Summary

ERR: 35
EIO: 1
ESO Big Diffs: 1
Table Small Diffs: 1

May need to go back in here and adjust the schedule further to get closer to the original result, this is changing the results quite a bit. Maybe a Schedule:File that mimics the original behavior?

github-actions · 2025-04-01T04:47:50Z

⚠️ Regressions detected on macos-14 for commit `74da9d4`

Regression Summary

Audit: 1
EIO: 2
ERR: 35
ESO Big Diffs: 2
Table Big Diffs: 1
Table Small Diffs: 1

amirroth · 2025-04-03T13:26:53Z

src/EnergyPlus/AirflowNetwork/include/AirflowNetwork/Nodes.hpp

+        int RAFNNodeNum;                                 // Index of RAFN node number
+
+        // Default Constructor
+        MultizoneZoneProp()


I thought we're not doing constructors this way anymore and we're putting the default values into the declarations. That's much cleaner IMO. Same comment on constructors below.

amirroth · 2025-04-03T13:27:29Z

src/EnergyPlus/AirflowNetwork/include/AirflowNetwork/Nodes.hpp

+    {
+        // Members
+        std::string ZoneName;         // Name of Associated EnergyPlus Thermal Zone
+        std::string VentControl;      // Ventilation Control Mode: "TEMPERATURE", "ENTHALPIC", "CONSTANT", or "NOVENT"


Why is this a string?

amirroth · 2025-04-03T13:30:16Z

src/EnergyPlus/AirflowNetwork/src/Elements.cpp

-    // and moisture levels at each node, and airflow and sensible and latent energy losses
-    // at each element
-
    static Real64 square(Real64 x)


Why add the function call overhead? Will this inline if you add the inline keyword?

amirroth · 2025-04-03T13:31:48Z

src/EnergyPlus/AirflowNetwork/src/Linkages.cpp

+
+namespace AirflowNetwork {
+
+void handle_nonrectangular_surfaces(EquivRec equivalent_rectangle_method, EPVector<DataSurfaces::SurfaceData> Surface, const std::string &surface_name, int surface_number,


Passing EPVector by value? Not const &?

amirroth · 2025-04-03T13:32:57Z

src/EnergyPlus/AirflowNetwork/src/Linkages.cpp

+void handle_nonrectangular_surfaces(EquivRec equivalent_rectangle_method, EPVector<DataSurfaces::SurfaceData> Surface, const std::string &surface_name, int surface_number,
+    Real64 &height, Real64 &width, Real64 user_aspect_ratio, EnergyPlusData *state)
+{
+    if (equivalent_rectangle_method == EquivRec::Height) {


auto &surf = Surface(surface_number); shortcut would make this code more readable.

amirroth · 2025-04-03T13:43:22Z

src/EnergyPlus/AirflowNetwork/src/Solver.cpp

+                auto const equiv_rect_iter{fields.find("equivalent_rectangle_method")};
+                EquivRec equivrec{EquivRec::Height};
+                if (equiv_rect_iter != fields.end()) {
+                    // This is guaranteed to work since inputs are validated


getEnumValue, not maps.

amirroth · 2025-04-03T13:45:01Z

src/EnergyPlus/AirflowNetwork/src/Solver.cpp

                                         "\" is an air boundary surface.");
-                    ShowContinueError(m_state, "Ventilation Control Mode = " + Alphas(4) + " is not valid. Resetting to Constant.");
-                    MultizoneSurfaceData(i).VentSurfCtrNum = VentControlType::Const;
+                    ShowContinueError(m_state, "Ventilation Control Mode = " +  std::map<VentControlType, std::string> {{VentControlType::Temp, "TEMPERATURE"},


Once more. Creating a single-use map and then searching it is slower than just doing the if-else string comparison ladder that was there before.

amirroth · 2025-04-03T13:46:05Z

src/EnergyPlus/AirflowNetwork/src/Solver.cpp

@@ -5170,6 +4954,20 @@ namespace AirflowNetwork {
            }
        }

+        // Final linkage validation
+        for (auto& linkage : AirflowNetworkLinkageData)


This can be auto const &.

amirroth · 2025-04-03T13:46:48Z

src/EnergyPlus/AirflowNetwork/src/Solver.cpp

        int LF;
        int LT;
        int CompNum;
        int NF;
        int NT;
-        iComponentTypeNum CompTypeNum;
+        AirflowElementType CompTypeNum;


Why remove num from the type name but not the variable name?

amirroth · 2025-04-03T13:50:23Z

tst/EnergyPlus/unit/AirflowNetworkHVAC.unit.cc


+    // The original test was changing the CompTypeNum, as that goes away it's necessaey to actually
+    // switch out the elements. This is probably an unwise approach.
+    auto const ye_olde_element = state->afn->AirflowNetworkLinkageData(2).element;


Since element is a pointer, please declare this as auto const *.

nrel-bot-2 · 2025-05-04T00:42:23Z

@jasondegraw @Myoldmopar it has been 30 days since this pull request was last updated.

nrel-bot-2c · 2025-06-04T00:36:21Z

@jasondegraw @Myoldmopar it has been 31 days since this pull request was last updated.

nrel-bot-2c · 2025-07-03T00:58:54Z

@jasondegraw @Myoldmopar it has been 29 days since this pull request was last updated.

nrel-bot-2c · 2025-08-02T00:50:36Z

@jasondegraw @Myoldmopar it has been 30 days since this pull request was last updated.

nrel-bot-2c · 2025-08-30T00:55:25Z

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot-2 · 2025-09-29T01:18:58Z

@jasondegraw @Myoldmopar it has been 30 days since this pull request was last updated.

jasondegraw added 10 commits March 19, 2025 22:12

Some long-overdue reorg of the files

1d91a7d

Refactor prep and clean up

cc5bca8

Unit tests all work again

0fee08a

Add control schedule name

6ef99e3

Implement filling in the schedule

9ff6a50

Clean out some old commented out code

325754b

Remove more CompTypeNum, repair unit test

b81c95f

Update Properties.cpp

3cdf9dd

Checkpoint commit, example file up next

fd0264d

Merge branch 'dop-scheduling' of github.com:NREL/EnergyPlus into dop-…

8d84087

…scheduling

Modify an example file to use the control

4517d73

May need to go back in here and adjust the schedule further to get closer to the original result, this is changing the results quite a bit. Maybe a Schedule:File that mimics the original behavior?

amirroth requested changes Apr 3, 2025

View reviewed changes


		namespace AirflowNetwork {

		void handle_nonrectangular_surfaces(EquivRec equivalent_rectangle_method, EPVector<DataSurfaces::SurfaceData> Surface, const std::string &surface_name, int surface_number,

Add AirflowNetwork opening scheduling #11015

Are you sure you want to change the base?

Add AirflowNetwork opening scheduling #11015

Conversation

jasondegraw commented Mar 31, 2025

Pull request overview

Pull Request Author

Reviewer

Uh oh!

github-actions bot commented Apr 1, 2025

⚠️ Regressions detected on macos-14 for commit 5d555cb

Uh oh!

github-actions bot commented Apr 1, 2025

⚠️ Regressions detected on macos-14 for commit 74da9d4

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amirroth Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nrel-bot-2 commented May 4, 2025

Uh oh!

nrel-bot-2c commented Jun 4, 2025

Uh oh!

nrel-bot-2c commented Jul 3, 2025

Uh oh!

nrel-bot-2c commented Aug 2, 2025

Uh oh!

nrel-bot-2c commented Aug 30, 2025

Uh oh!

nrel-bot-2 commented Sep 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

⚠️ Regressions detected on macos-14 for commit `5d555cb`

⚠️ Regressions detected on macos-14 for commit `74da9d4`

amirroth Apr 3, 2025 •

edited

Loading