Fix Evaporative Fluid Cooler Table Reports and Add Design Entering Temperature Defaults #11043

mjwitte · 2025-04-23T21:38:33Z

Pull request overview

Fixes EvaporativeFluidCooler:TwoSpeed not populating Cooling Towers and Fluid Coolers table in Equipment Summary #10997
For EvaporativeFluidCooler:SingleSpeed and EvaporativeFluidCooler:TwoSpeed update the following input fields:
- Design Entering Water Temperature: make autosizable, default to autosize (takes the value from Sizing:Plant)
- Design Entering Air Temperature: add default of 35.0C (same as the hard-coded value for the StandardDesignCapacity option)
- Design Entering Air Wet-bulb Temperature: add default of 25.6C (same as the hard-coded value for the StandardDesignCapacity option)
- No transition necessary, just new defaults.

Testfile status (with this branch)

Filename	Equipment Type	autosized?	Sizing:Plant Object?	Present in Output?	All Data Filled?
ASHRAE901_ApartmentHighRise_STD2019_Denver	EvaporativeFluidCooler:TwoSpeed	Y	Y	Y	Y
CoolingTower_MerkelVariableSpeed	CoolingTower:VariableSpeed:Merkel	Y	Y	Y	Y
CoolingTower_SingleSpeed_MultiCell	CoolingTower:SingleSpeed	Y	Y	Y	Y
CoolingTower_TwoSpeed	CoolingTower:TwoSpeed	N	N	Y	Y
CoolingTower_VariableSpeed	CoolingTower:VariableSpeed	Y	Y	Y	Y
CoolingTower	CoolingTower:SingleSpeed	N	N	Y	Y
EvaporativeFluidCooler_TwoSpeed	EvaporativeFluidCooler:TwoSpeed	Y	Y	Y	Y
EvaporativeFluidCooler	EvaporativeFluidCooler:SingleSpeed	N	N	Y	Y
FluidCooler	FluidCooler:SingleSpeed	N	N	Y	Y
FluidCoolerTwoSpeed	FluidCooler:TwoSpeed	Mixed	Y	Y	Y

Pull Request Author

Reviewer

github-actions · 2025-04-23T22:28:25Z

⚠️ Regressions detected on macos-14 for commit `baf7c82`

Regression Summary

Audit: 3
Table String Diffs: 3
Table Big Diffs: 2

nrel-bot-2 · 2025-05-21T15:02:27Z

@mjwitte @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot-2c · 2025-06-25T00:33:33Z

@mjwitte @Myoldmopar it has been 34 days since this pull request was last updated.

github-actions · 2025-07-21T22:36:10Z

⚠️ Regressions detected on macos-14 for commit `cbdb3ec`

Regression Summary

Audit: 3
Table String Diffs: 3

github-actions · 2025-07-23T20:41:27Z

⚠️ Regressions detected on macos-14 for commit `c0248a9`

Regression Summary

Audit: 3
Table String Diffs: 3

github-actions · 2025-07-24T23:26:57Z

⚠️ Regressions detected on macos-14 for commit `688b97f`

Regression Summary

Audit: 3
Table String Diffs: 3
Table Big Diffs: 1

mjwitte · 2025-08-05T18:08:26Z

EvaporativeFluidCooler.idf
Develop:

This branch:

mjwitte · 2025-08-05T18:11:20Z

EvaporativeFluidCooler_TwoSpeed.idf
Develop:

This branch:

mjwitte

Code walkthru

mjwitte · 2025-08-05T18:14:18Z

src/EnergyPlus/EvaporativeFluidCoolers.cc

        Real64 tmpHighSpeedAirFlowRate = this->HighSpeedAirFlowRate;

        int PltSizCondNum = state.dataPlnt->PlantLoop(this->plantLoc.loopNum).PlantSizNum;
+        if (PltSizCondNum > 0) {


Get relevant values from sizing:plant if present.

mjwitte · 2025-08-05T18:14:52Z

src/EnergyPlus/EvaporativeFluidCoolers.hh

        bool LowSpeedEvapFluidCoolerUAWasAutoSized = false;  // true if low speed UA set to autosize on input
        Real64 LowSpeedEvapFluidCoolerUASizingFactor = 0.0;  // sizing factor for low speed UA []
        Real64 DesignEnteringWaterTemp = 0.0;                // Entering water temperature at design conditions
+        Real64 DesignExitWaterTemp = -999;                   // Leaving water temperature at design conditions [C]


Add this to the struct

Is that a new glycol limit?

Changed to DataSizing::AutoSize

Changed to DataSizing::AutoSize

Oh, but it's not supposed to be that. -999 was a lazy way to track if it was set along the way. I guess I'll keep it this way for now and make a todo for later.

No need for a ToDo unless that would cover all places that use this method. See ReportCoilSelection for a slew of these real values, e.g., -999.0

mjwitte · 2025-08-05T18:16:06Z

src/EnergyPlus/EvaporativeFluidCoolers.cc

                    DesignEnteringAirWetBulb = this->DesignEnteringAirWetBulbTemp;
                }
-                if (state.dataSize->PlantSizData(PltSizCondNum).ExitTemp <= DesignEnteringAirWetBulb) {
+                if (this->DesignExitWaterTemp <= DesignEnteringAirWetBulb) {


Use this->DesignExitWaterTemp throughout.

mjwitte · 2025-08-05T18:20:19Z

src/EnergyPlus/EvaporativeFluidCoolers.cc

+                this->DesignEnteringWaterTemp = this->inletConds.WaterTemp;
+                this->inletConds.AirTemp = 35.0;    // 95F design inlet air dry-bulb temp
+                this->inletConds.AirWetBulb = 25.6; // 78F design inlet air wet-bulb temp
+                this->DesignEnteringAirWetBulbTemp = this->inletConds.AirWetBulb;


Set this->DesignEnteringAirWetBulbTemp in all sizing options so it can be reported.

mjwitte · 2025-08-05T18:20:41Z

src/EnergyPlus/EvaporativeFluidCoolers.cc

-                    Real64 OutWaterTemp; // outlet water temperature [C]
-                    this->SimSimpleEvapFluidCooler(state, par1, par2, UA, OutWaterTemp);
-                    Real64 const CoolingOutput = Cp * par1 * (this->inletConds.WaterTemp - OutWaterTemp);
+                    this->SimSimpleEvapFluidCooler(state, par1, par2, UA, this->DesignExitWaterTemp);


Set this->DesignExitWaterTemp in all sizing options so it can be reported.

mjwitte · 2025-08-05T18:21:15Z

src/EnergyPlus/EvaporativeFluidCoolers.cc

            // create predefined report
            std::string equipName = this->Name;
            OutputReportPredefined::PreDefTableEntry(state, state.dataOutRptPredefined->pdchMechType, equipName, this->EvapFluidCoolerType);
+            OutputReportPredefined::PreDefTableEntry(state,


Add a bunch of missing table outputs.

github-actions · 2025-08-05T18:56:23Z

⚠️ Regressions detected on macos-14 for commit `d1e000f`

Regression Summary

Audit: 3
Table String Diffs: 3
Table Big Diffs: 1

mjwitte · 2025-08-05T20:32:26Z

Diffs as expected:

* Diffs by Type *:
{
  "Audit": [
    "ASHRAE901_ApartmentHighRise_STD2019_Denver",
    "EvaporativeFluidCooler",
    "EvaporativeFluidCooler_TwoSpeed"
  ],
  "Table Big Diffs": [
    "EvaporativeFluidCooler"
  ],
  "Table String Diffs": [
    "ASHRAE901_ApartmentHighRise_STD2019_Denver",
    "EvaporativeFluidCooler",
    "EvaporativeFluidCooler_TwoSpeed"
  ]

mjwitte · 2025-09-10T17:39:58Z

@rraustad Would appreciate your review here, especially for the new IDD defaults.

rraustad · 2025-09-25T16:09:33Z

src/EnergyPlus/EvaporativeFluidCoolers.cc

+            this->DesignExitWaterTemp = state.dataSize->PlantSizData(PltSizCondNum).ExitTemp;
+            if (this->DesignEnteringWaterTemp == DataSizing::AutoSize) {
+                this->DesignEnteringWaterTemp =
+                    state.dataSize->PlantSizData(PltSizCondNum).ExitTemp + state.dataSize->PlantSizData(PltSizCondNum).DeltaT;


Documentation above says The design entering water temperature must be greater than the design entering air temperature. Does that need to be checked when autosizing? I do see at line 1381 where exit water temp must be greater than entering air WB so maybe that is sufficient when autosizing. getInput does this:

if (thisEFC.DesignEnteringWaterTemp <= thisEFC.DesignEnteringAirWetBulbTemp) { ShowSevereError(state, format("{} = \"{}\", {} must be greater than {}.", state.dataIPShortCut->cCurrentModuleObject, AlphArray(1), state.dataIPShortCut->cNumericFieldNames(9), state.dataIPShortCut->cNumericFieldNames(11))); ErrorsFound = true; } if (thisEFC.DesignEnteringAirTemp <= thisEFC.DesignEnteringAirWetBulbTemp) { ShowSevereError(state, format("{} = \"{}\", {} must be greater than {}.", state.dataIPShortCut->cCurrentModuleObject, AlphArray(1), state.dataIPShortCut->cNumericFieldNames(10), state.dataIPShortCut->cNumericFieldNames(11))); ErrorsFound = true; }

Documentation above says The design entering water temperature must be greater than the design entering air temperature. Does that need to be checked when autosizing? I do see at line 1381 where exit water temp must be greater than entering air WB so maybe that is sufficient when autosizing. getInput does this:

@rraustad Hmm, not sure if this is ok or not. I may make some revisions in a follow-up PR.

@mitchute I've merged in develop. Assuming CI comes back as expected. This can merge.

rraustad · 2025-09-25T16:15:32Z

idd/Energy+.idd.in

  N21, \field Design Entering Air Wet-bulb Temperature
       \type real
       \units C
+       \default 25.6


I think for defaults these are reasonably extreme. The user can adjust as they see fit.

rraustad · 2025-09-25T16:17:17Z

Corrections to table reports, as shown in above examples, look much better.

rraustad

Other than any adjustments based on limited comments I think this is ready.

github-actions · 2025-09-25T22:15:31Z

⚠️ Regressions detected on ubuntu-24.04 for commit `02471ca`

Regression Summary

Audit: 3
Table String Diffs: 3
Table Big Diffs: 1
ESO Small Diffs: 1

github-actions · 2025-09-25T22:22:25Z

⚠️ Regressions detected on macos-14 for commit `02471ca`

Regression Summary

Audit: 3
Table String Diffs: 3
Table Big Diffs: 1

mjwitte · 2025-09-26T12:40:13Z

@mitchute CI is all green, diffs as before. Merge at will.

mjwitte added 3 commits April 9, 2025 11:12

Add reporting for EvapFluidCooler

4e85bfa

Merge remote-tracking branch 'remotes/origin/develop' into rpdTables3

36018de

Fix unit test

91c9041

mjwitte added the Defect Includes code to repair a defect in EnergyPlus label Apr 23, 2025

mjwitte added the RPD label Jul 7, 2025

mjwitte added 4 commits July 7, 2025 15:47

Merge remote-tracking branch 'remotes/origin/develop' into rpdTables3

b5980ac

Merge remote-tracking branch 'remotes/origin/develop' into rpdTables3

09b9c31

Add defaults for EvaporativeFluidCoolers

1e89469

EvaporativeFluidCooler reporting - more

26f3f8d

EvaporativeFluidCooler reporting - more2

7ff4940

mjwitte added 2 commits July 24, 2025 16:56

Merge remote-tracking branch 'remotes/origin/develop' into rpdTables3

f4ec458

evap cooler capacity in equipment summary central plant subtable

b4440e4

mjwitte added this to the EnergyPlus 25.2 IO Freeze milestone Aug 1, 2025

Merge remote-tracking branch 'remotes/origin/develop' into rpdTables3

2183c6e

mjwitte added the IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) label Aug 5, 2025

Revert field name changes - KISS

7671b03

mjwitte changed the title ~~Fix Evaporative Fluid Cooler Table Reports~~ Fix Evaporative Fluid Cooler Table Reports and Add Design Entering Temperature Defaults Aug 5, 2025

I/O Ref evap cooler temperature defaults

19a4a93

mjwitte marked this pull request as ready for review August 5, 2025 18:00

mjwitte commented Aug 5, 2025

View reviewed changes

Myoldmopar self-assigned this Aug 27, 2025

mjwitte requested a review from rraustad September 10, 2025 17:39

rraustad reviewed Sep 25, 2025

View reviewed changes

rraustad approved these changes Sep 25, 2025

View reviewed changes

Merge remote-tracking branch 'remotes/origin/develop' into rpdTables3

3b010bd

mitchute merged commit ca324c8 into develop Sep 26, 2025
11 checks passed

mitchute deleted the rpdTables3 branch September 26, 2025 16:11

Fix Evaporative Fluid Cooler Table Reports and Add Design Entering Temperature Defaults #11043

Fix Evaporative Fluid Cooler Table Reports and Add Design Entering Temperature Defaults #11043

Uh oh!

Conversation

mjwitte commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request overview

Testfile status (with this branch)

Pull Request Author

Reviewer

Uh oh!

github-actions bot commented Apr 23, 2025

⚠️ Regressions detected on macos-14 for commit baf7c82

Uh oh!

nrel-bot-2 commented May 21, 2025

Uh oh!

nrel-bot-2c commented Jun 25, 2025

Uh oh!

github-actions bot commented Jul 21, 2025

⚠️ Regressions detected on macos-14 for commit cbdb3ec

Uh oh!

github-actions bot commented Jul 23, 2025

⚠️ Regressions detected on macos-14 for commit c0248a9

Uh oh!

github-actions bot commented Jul 24, 2025

⚠️ Regressions detected on macos-14 for commit 688b97f

Uh oh!

mjwitte commented Aug 5, 2025

Uh oh!

mjwitte commented Aug 5, 2025

Uh oh!

mjwitte left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 5, 2025

⚠️ Regressions detected on macos-14 for commit d1e000f

Uh oh!

mjwitte commented Aug 5, 2025

Uh oh!

mjwitte commented Sep 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rraustad commented Sep 25, 2025

Uh oh!

rraustad left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 25, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit 02471ca

Uh oh!

github-actions bot commented Sep 25, 2025

⚠️ Regressions detected on macos-14 for commit 02471ca

Uh oh!

mjwitte commented Sep 26, 2025

Uh oh!

mjwitte commented Apr 23, 2025 •

edited

Loading

⚠️ Regressions detected on macos-14 for commit `baf7c82`

⚠️ Regressions detected on macos-14 for commit `cbdb3ec`

⚠️ Regressions detected on macos-14 for commit `c0248a9`

⚠️ Regressions detected on macos-14 for commit `688b97f`

⚠️ Regressions detected on macos-14 for commit `d1e000f`

⚠️ Regressions detected on ubuntu-24.04 for commit `02471ca`

⚠️ Regressions detected on macos-14 for commit `02471ca`