Correction of Return Temperature Output for Cooling Plant Loops and Condenser Loops in EIO Sizing Output

[RKStrand]

Pull request overview

• Fixes Report variable for PlantLoop Design Return Temperature uses same sign for heating and cooling #10654

Description of the purpose of this PR

In the sizing reports that are sent to the EIO, the cooling and condenser loop return temperatures were not being calculated correctly (wrong sign was used to include the delta temperature). This has been corrected and a unit test has been added. The only differences in the output should be EIO files where this is reported.

Pull Request Author

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[rraustad]

This looks good to me.

[github-actions]

⚠️ Regressions detected on macos-14 for commit 1328099

Regression Summary

• EIO: 435
• Table Big Diffs: 413
• Table String Diffs: 413

• View Results
• Download Regressions

[mjwitte]

@RKStrand Sorry, I addressed this (in a different way) as part of #10998 . I did not realize that #10654 was an open issue. I'll compare and see what to keep or not from here.

[RKStrand]

@mjwitte Oh, bummer. I mean good that it's getting fixed, but unfortunate that I didn't know that this was being worked on was part of something else. Yes, please let me know what your thoughts are regarding this. If I need to drop it since it's already fixed elsewhere, I'll need to plan on something else to work on for deliverables.

[mjwitte]

@RKStrand I've confirmed this fixes the issue and diffs are as expected (random checks of a few files). I've merged in develop and will let CI report back before merging.

[github-actions]

⚠️ Regressions detected on macos-14 for commit 733d8e1

Regression Summary

• EIO: 435
• Table Big Diffs: 413
• Table String Diffs: 413

• View Results
• Download Regressions

[github-actions]

⚠️ Regressions detected on ubuntu-24.04 for commit 733d8e1

Regression Summary

• EIO: 435
• Table Big Diffs: 413
• Table String Diffs: 413

• View Results
• Download Regressions

[mjwitte]

@Myoldmopar @jmarrec The windows regression failed here:

Run actions/github-script@v7
Error: Cannot find module 'D:aEnergyPlusEnergyPlus/regressions/summary.js'

https://github.com/NREL/EnergyPlus/actions/runs/17504501605/job/49725059608?pr=11146

But otherwise, CI is happy. Merging.