Skip to content

Conversation

GaryMarksBigladder
Copy link
Contributor

Pull request overview

Description of the purpose of this PR

Fix error message formatting when chiller EIR-F-PLR curve values are negative

Pull Request Author

Gary Marks

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@GaryMarksBigladder
Copy link
Contributor Author

Removed an old way of doing rounding where it multiplied by 100, converted to an int, and then divided by 100.
While doing that I also added variable precision to the error message so you don't end up with -0.00.
Adding the variable precision meant also changing the previously hard coded PLR line to also used variable precision, so the table would line up.

@mjwitte mjwitte added the Defect Includes code to repair a defect in EnergyPlus label Sep 25, 2025
@tanaya-mankad tanaya-mankad marked this pull request as ready for review October 8, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix formatting when chiller EIR-F-PLR curve values are negative

3 participants