Fix issues with meters reporting during warmup #11170
Open
+33
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rraustad
reviewed
Aug 26, 2025
|
@lymereJ @Myoldmopar it has been 28 days since this pull request was last updated. |
lymereJ
commented
Oct 3, 2025
Comment on lines
+457
to
+459
| if (state.dataSysVars->ReportDuringWarmup) { | ||
| OutputProcessor::ResetAccumulationWhenWarmupComplete(state); | ||
| } |
There was a problem hiding this comment.
Use (unused) existing function to reset the meters when warmup is complete.
Comment on lines
+10101
to
+10105
| EXPECT_NEAR(state->dataUnitarySystems->unitarySys[0].m_DesignCoolingCapacity, 24883.6371, 0.05); | ||
|
|
||
| // Check meter accumulation | ||
| // Lights are 1W so the meter should be 3600 [J] * 24 hours | ||
| EXPECT_TRUE(state->dataOutputProcessor->meters[4]->periodFinYrSM.Value == 3600 * 24); |
There was a problem hiding this comment.
Piggy-back on an existing unit test; A 1 W light object is used to check that the meters are being reset.
|
The defect file was updated to v25.2: defect_file_252.txt. When using this branch, the results are the same whether 
These are the same results that we get when using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Output:Diagnostics'sReportDuringWarmupoption impact annual energy use #11141Description of the purpose of this PR
Pull Request Author
Reviewer