Fix 10755 Carroll MRT Algorithm Imbalance

[kevin-moos]

Pull request overview

• Fixes Carroll MRT Algorithm Imbalanced #10755

Description of the purpose of this PR

Fix Carroll MRT algorithm imbalance, add unit test to show that it is now balanced, and update documentation. Regressions are expected in CarrollMRT-RefBldgLargeOfficeNew2004_Chicago.idf, _ResidentialBase.idf, and _ResidentialBaseboardHardSize.idf.

The original approach from Carroll's paper didn't balance. The zone's mean radiant temperature was being calculated as:

It should actually be calculated as:

Pull Request Author

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[kevin-moos]

@szvsw - we opened a PR for #10755 based on your Unmet Hours post

[szvsw]

Awesome! Glad to have mildly contributed at least in spirit to E+!

Out of curiosity have you seen any cases where the fixed formula significantly alters results?