Skip to content

Conversation

Myoldmopar
Copy link
Member

@Myoldmopar Myoldmopar commented Sep 18, 2025

Pull request overview

OK, this continues the ground heat exchanger modeling improvements. This one is about adding the ability to design and size the borehole field itself. Lots of caveats in here, and plenty of things needed for error handling, much improved documentation, more tests, double checking my flag usages, improvements to the required input configuration to make it work, etc. I'm pushing it tonight to see how GHA feels about it, and then I'll go from there tomorrow, including plenty of walkthrough.

Notable TO-DO:

  • Need to verify the loads are coming out as expected, and match the load sign convention for GHEDesigner
  • If we add an input field to the new :Sizing object that references the name of a SizingPeriod:WeatherFIleDays object, we could make the whole sizing/load operation much more flexible and robust.
  • Needs documentaiton updates in the engineering reference - probably a good time to go over the whole GLHE section.
  • Verify transition code changes work by pulling a 25.1 file, transitioning it, and running it in 25.2
  • Add outputs to the EIO file for the borehole field. Maybe a list of borehole X, Y coordinates?

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@Myoldmopar Myoldmopar self-assigned this Sep 18, 2025
@Myoldmopar Myoldmopar added the NewFeature Includes code to add a new feature to EnergyPlus label Sep 18, 2025
Copy link

⚠️ Regressions detected on ubuntu-24.04 for commit 4cbe567

Regression Summary
  • ERR: 1

Copy link

⚠️ Regressions detected on macos-14 for commit 4cbe567

Regression Summary
  • ERR: 1

@mjwitte mjwitte added the IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) label Sep 25, 2025
@mjwitte mjwitte added this to the EnergyPlus 25.2 IO Freeze milestone Sep 25, 2025
@rraustad
Copy link
Contributor

rraustad commented Oct 8, 2025

I don't know which code is more correct in test_pull_requests.yml so can't correct that. Linux debug failure seems unrelated.

Unit tests run locally. New borehole example file GSHP-GLHE-BoreholeFieldDesign fails witthout Python CLI:

**  Fatal  ** Attempted to use borehole field design in a build without PYTHON_CLI, which is invalid

and has an error when including Python CLI:

** Warning ** [G-Function Calculation for GHE Named: VERTICAL GHE 1X4 STD] EnergyPlus fluid concentration > 60% (GHEDesigner max), reducing to 60%, continuing
**  Fatal  ** GHEDesigner failed to calculate G-functions.
image

@mitchute
Copy link
Collaborator

mitchute commented Oct 8, 2025

Thanks, @rraustad. I've corrected the merge issues, and will push them up in the morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) NewFeature Includes code to add a new feature to EnergyPlus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants