Adding GHE borehole field design and sizing #11217
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
OK, this continues the ground heat exchanger modeling improvements. This one is about adding the ability to design and size the borehole field itself. Lots of caveats in here, and plenty of things needed for error handling, much improved documentation, more tests, double checking my flag usages, improvements to the required input configuration to make it work, etc. I'm pushing it tonight to see how GHA feels about it, and then I'll go from there tomorrow, including plenty of walkthrough.
Notable TO-DO:
SizingPeriod:WeatherFIleDays
object, we could make the whole sizing/load operation much more flexible and robust.Pull Request Author
Reviewer