Remove unused code in HeatPump:PlantLoop:EIR:Heating defrost getInput

[rraustad]

Pull request overview

• Fixes developer mistake in getting default field value

Description of the purpose of this PR

Someone pointed out some dead code

Pull Request Author

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[rraustad]

Excess safety in getInput for EIR HP default. Works as intended without the unused warning:

A19, \field Heat Pump Defrost Control
    \type choice
    \key None
    \key Timed
    \key OnDemand
    \key TimedEmpirical
    \note A blank field is the same as None.
N13, \field Heat Pump Defrost Time Period Fraction
    \type real
    \minimum 0.0
    \default 0.058333

Modified PlantLoopHeatPump_EIR_AirSource to test as:

HeatPump:PlantLoop:EIR:Heating,
  (snip)
  CapCurveFuncTemp,        !- Capacity Modifier Function of Temperature Curve Name
  EIRCurveFuncTemp,        !- Electric Input to Output Ratio Modifier Function of Temperature Curve Name
  EIRCurveFuncPLR,         !- Electric Input to Output Ratio Modifier Function of Part Load Ratio Curve Name
  ,
  ,
  ,
  ,
  ,
  ,
  ,
  ,
  ,
  ,
  ,
  Timed;  !- Heat Pump Defrost Control
          !- Heat Pump Defrost Time Period Fraction field intentionally not included to make sure json was grabbing default.

[mitchute]

Thanks @rraustad. It looks like there's a few more of these patterns scattered throughout this file. Not critical, but should we clean those up here?

EnergyPlus/src/EnergyPlus/PlantLoopHeatPumpEIR.cc

Lines 3457 to 3464 in 2ab91ec

	Real64 defaultVal_sizeFactor = 1.0;
	if (!state.dataInputProcessing->inputProcessor->getDefaultValue(
	state, cCurrentModuleObject, "sizing_factor", defaultVal_sizeFactor)) {
	ShowSevereError(state, "EIR FFHP: Sizing factor not entered and could not get default value");
	errorsFound = true;
	} else {
	thisPLHP.sizingFactor = defaultVal_sizeFactor;
	}