CppCheck Cleanups #11319
Draft
CppCheck Cleanups #11319
+345
−512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rraustad
approved these changes
Nov 4, 2025
Contributor
rraustad
left a comment
rraustad
left a comment
There was a problem hiding this comment.
CppCheck is running pretty fast so including these doesn't seem to hurt GHA run time.
Collaborator
Author
|
@rraustad yeah, I don't think it was the speed, but that it was just that those files were throwing some errors that they didn't have time to deal with. |
|
|
|
|
rraustad
reviewed
Nov 25, 2025
|
|
||
| // Check the number of primary air loops | ||
| if (!simulation_control.DuctLoss) { | ||
| int NumAPL; |
Contributor
There was a problem hiding this comment.
I would think this should be initialized to 0 here since distribution_simulated could be false? and NumAPL is used at line 2224.
rraustad
reviewed
Nov 25, 2025
src/EnergyPlus/BaseboardElectric.cc
Outdated
| int BaseboardNum = 0; | ||
| for (int ConvElecBBNum = 1; ConvElecBBNum <= NumConvElecBaseboards; ++ConvElecBBNum) { | ||
|
|
||
| auto &s_ipsc = state.dataIPShortCut; |
Contributor
There was a problem hiding this comment.
Shouldn't this be done outside the for loop? after line 190?
rraustad
reviewed
Nov 25, 2025
src/EnergyPlus/DataHeatBalance.cc
Outdated
| for (nLayer = 1; nLayer <= Construction::MaxLayersInConstruct; ++nLayer) { | ||
| state.dataConstruction->Construct(state.dataHeatBal->TotConstructs).LayerPoint(nLayer) = state.dataConstruction->LayerPoint(nLayer); | ||
| if (state.dataConstruction->LayerPoint(nLayer) != 0) { | ||
| auto &s_mat = state.dataMaterial; |
Contributor
There was a problem hiding this comment.
Same here, do this just above line 863?
rraustad
reviewed
Nov 25, 2025
src/EnergyPlus/DemandManager.cc
Outdated
|
|
||
| auto &thisDemandMgrList = state.dataDemandManager->DemandManagerList(ListNum); | ||
|
|
||
| auto &s_ipsc = state.dataIPShortCut; |
rraustad
reviewed
Nov 25, 2025
src/EnergyPlus/DuctLoss.cc
Outdated
| for (int DuctLossNum = 1; DuctLossNum <= state.dataDuctLoss->NumOfDuctLosses; DuctLossNum++) { | ||
| auto &thisDuctLoss(state.dataDuctLoss->ductloss(DuctLossNum)); | ||
|
|
||
| std::string CurrentModuleObject; |
rraustad
reviewed
Nov 25, 2025
| if (this->NumCompressors > 1) { | ||
| UpperStageCompressorRatio = (1.0 - this->CompressorSizeRatio) / (this->NumCompressors - 1); | ||
| int Stage; // used for crankcase heater power calculation | ||
| for (Stage = 1; Stage <= this->NumCompressors - 2; ++Stage) { |
Contributor
There was a problem hiding this comment.
really? could you reduce scope by 1 more line?
rraustad
reviewed
Nov 25, 2025
src/EnergyPlus/OutAirNodeManager.cc
Outdated
| // Loop over all outside air inlet nodes in the input and count them | ||
| CurrentModuleObject = "OutdoorAir:NodeList"; | ||
| int OutAirInletNodeListNum; // OUTSIDE AIR INLET NODE LIST index | ||
| for (OutAirInletNodeListNum = 1; OutAirInletNodeListNum <= NumOutAirInletNodeLists; ++OutAirInletNodeListNum) { |
Contributor
There was a problem hiding this comment.
Several of these here and below, for (int xxx
rraustad
reviewed
Nov 25, 2025
| bool errorsFound = false; | ||
| std::string &cCurrentModuleObject = state.dataIPShortCut->cCurrentModuleObject; | ||
| for (auto const &classToInput : classesToInput) { | ||
| std::string &cCurrentModuleObject = state.dataIPShortCut->cCurrentModuleObject; |
Contributor
There was a problem hiding this comment.
I wonder why CppCheck would want this scope reduced?? and line 3780.
Collaborator
|
@mitchute @rraustad I started the CppCheck cleanup with the |
|
|
|
|
|
rraustad
reviewed
Dec 5, 2025
src/EnergyPlus/DXCoils.cc
Outdated
| int CapacityStageNum; // Loop index for 1,Number of capacity stages | ||
| for (DehumidModeNum = 0; DehumidModeNum <= thisDXCoil.NumDehumidModes; ++DehumidModeNum) { | ||
| int CapacityStageNum; // Loop index for 1,Number of capacity stages | ||
| for (CapacityStageNum = 1; CapacityStageNum <= thisDXCoil.NumCapacityStages; ++CapacityStageNum) { |
Contributor
There was a problem hiding this comment.
You can delete lines 7044 and 7045 and update line 7046 with for (int DehumidModeNum and line 7047 with for (int CapacityStageNum. Same for lines 14665 and 15083 below.
|
|
|
|
|
|
|
|
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
CppCheck has a flagged number of warnings, as well as some style and performance recommendations. In addition, several files are being ignored. This is expected to be a pass at moving these towards a better place.
Pull Request Author
Reviewer