Skip to content

Conversation

@kevin-moos
Copy link
Contributor

Pull request overview

Description of the purpose of this PR

Remove Reheat Coil Air Inlet Node Name field from AirTerminal:SingleDuct:ParallelPIU:Reheat and AirTerminal:SingleDuct:SeriesPIU:Reheat since the node name can be pulled from the heating coil
Update unit tests
Update example IDF files
Update I/O reference
Update ExpandObjects
Update IDFVersionUpdater

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@kevin-moos kevin-moos changed the title Fix 9968 piu reheat coil node connection error Fix 9968 - Remove Reheat Coil Air Inlet Node Name field from PIU objects Dec 12, 2025
@kevin-moos
Copy link
Contributor Author

The regressions are due to NumOfNodeConnections being reduced. No results changed.
image

@kevin-moos kevin-moos marked this pull request as ready for review December 12, 2025 19:49
@mitchute mitchute added Defect Includes code to repair a defect in EnergyPlus IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) labels Dec 17, 2025
Copy link
Collaborator

@mitchute mitchute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tested about 2/3 of the affected IDFs and they all showed results consistent with the expected change. I also ran regression and integration tests locally, and tested a transition file. Everything looks good here.

@mitchute mitchute merged commit 6971c0f into NREL:develop Dec 17, 2025
9 of 11 checks passed
@mitchute mitchute deleted the Fix-9968-PIU-reheat-coil-node-connection-error branch December 17, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus IDDChange Code changes impact the IDD file (cannot be merged after IO freeze)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Entering an incorrect reheat coil inlet node name in AirTerminal:SingleDuct:SeriesPIU:Reheat gives node connection errors

3 participants