Skip to content

Conversation

RHammond2
Copy link
Collaborator

This PR addresses a series of small features and fixes from the HVS2 work as outlined below.

  • MonteCarloAEP
    • n_jobs to enable parallelization of each iteration's model
    • apply_iav to toggle the addition of the interannual variability at the end of the analysis.
    • run::progress_bar to toggle the use of a progress bar during the analysis. When running many models, turning off the progress bar for each iteration of a parameter sweep greatly reduces the amount of outputs to scroll through.
  • Implements and applies a wind speed calculation from the u and v components in place of a manual calculation.
  • Adds default empty data frames for the PlantData's asset_distance_matrix and asset_direction_matrix values. Without the defaults, plants not utilizing location data end up failing at analysis time since no data is able to be passed.

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.92%. Comparing base (a53308e) to head (3c92cc7).
Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
openoa/analysis/aep.py 82.35% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #307      +/-   ##
===========================================
- Coverage    72.49%   69.92%   -2.58%     
===========================================
  Files           29       29              
  Lines         3690     3840     +150     
  Branches       796      573     -223     
===========================================
+ Hits          2675     2685      +10     
- Misses         826      967     +141     
+ Partials       189      188       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@ejsimley ejsimley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting these fixes and improvements based on the HVS2 work! I appreciate the "apply_iav" option, which makes the code a lot more flexible and the new compute_wind_speed function.

I just have some minor comments to consider.

Copy link
Collaborator

@ejsimley ejsimley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes @RHammond2! I just added a little more to a couple docstrings (feel free to revise).

@RHammond2
Copy link
Collaborator Author

Thanks, @ejsimley, I think it's better with your addition, and will merge this in once the checks pass.

@RHammond2 RHammond2 merged commit 2200c4c into NREL:develop May 29, 2025
11 of 17 checks passed
@RHammond2 RHammond2 deleted the fix/minor-tidying branch May 29, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants