-
Notifications
You must be signed in to change notification settings - Fork 83
Enhancement: Add flexibility to the Monte Carlo analysis PlantData initialization #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #307 +/- ##
===========================================
- Coverage 72.49% 69.92% -2.58%
===========================================
Files 29 29
Lines 3690 3840 +150
Branches 796 573 -223
===========================================
+ Hits 2675 2685 +10
- Misses 826 967 +141
+ Partials 189 188 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting these fixes and improvements based on the HVS2 work! I appreciate the "apply_iav" option, which makes the code a lot more flexible and the new compute_wind_speed
function.
I just have some minor comments to consider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these changes @RHammond2! I just added a little more to a couple docstrings (feel free to revise).
Thanks, @ejsimley, I think it's better with your addition, and will merge this in once the checks pass. |
This PR addresses a series of small features and fixes from the HVS2 work as outlined below.
MonteCarloAEP
n_jobs
to enable parallelization of each iteration's modelapply_iav
to toggle the addition of the interannual variability at the end of the analysis.run::progress_bar
to toggle the use of a progress bar during the analysis. When running many models, turning off the progress bar for each iteration of a parameter sweep greatly reduces the amount of outputs to scroll through.PlantData
'sasset_distance_matrix
andasset_direction_matrix
values. Without the defaults, plants not utilizing location data end up failing at analysis time since no data is able to be passed.