Skip to content

Conversation

bpark1327
Copy link
Collaborator

@bpark1327 bpark1327 commented Mar 22, 2025

Pull Request Description

Address language update for floors -- added multifamily buffer space:
image

Checklist

Not all may apply:

  • OS-HPXML git subtree has been pulled
  • 301validator.xml has been updated (reference EPvalidator.xml)
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., rulesets\tests and/or workflow/tests/*_test.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results on CI

@bpark1327 bpark1327 self-assigned this Mar 22, 2025
Copy link
Collaborator

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also double-check the results for 1.2 vs 1.3 for the MFNCv13_CZ6_VT_elec_middle_interior.xml test case.

@bpark1327
Copy link
Collaborator Author

Let's also double-check the results for 1.2 vs 1.3 for the MFNCv13_CZ6_VT_elec_middle_interior.xml test case.

We observed an unexpected ERI discrepancy when using different mechanical ventilation system types (HRV for MFNC v1.3 and exhaust-only for MFNC v1.2). OS-ERI showed that the ventilation system type had a much greater impact on the rated home’s ERI than we expected. This difference seems to stem primarily from variations in the Rated Home's infiltration rates.
To clarify whether our modeling approach aligns with the intended ANSI 301 methodology, we reached out to Philip and Brian via email on 3/27/2025.

@bpark1327
Copy link
Collaborator Author

Let's also double-check the results for 1.2 vs 1.3 for the MFNCv13_CZ6_VT_elec_middle_interior.xml test case.

We observed an unexpected ERI discrepancy when using different mechanical ventilation system types (HRV for MFNC v1.3 and exhaust-only for MFNC v1.2). OS-ERI showed that the ventilation system type had a much greater impact on the rated home’s ERI than we expected. This difference seems to stem primarily from variations in the Rated Home's infiltration rates. To clarify whether our modeling approach aligns with the intended ANSI 301 methodology, we reached out to Philip and Brian via email on 3/27/2025.

It is addressed in #774

@bpark1327 bpark1327 marked this pull request as ready for review April 1, 2025 21:03
@bpark1327 bpark1327 requested a review from shorowit April 1, 2025 21:03
Copy link
Collaborator

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two minor requests.

Copy link
Collaborator

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Assuming the CI passes and results look reasonable, I'll merge this in. Thanks!

@shorowit shorowit merged commit 7f8ce36 into master Apr 1, 2025
@shorowit shorowit deleted the es_mfnc_rev5 branch April 1, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants