Skip to content

Conversation

bpark1327
Copy link
Collaborator

@bpark1327 bpark1327 commented Apr 3, 2025

Pull Request Description

HVAC system's fuel type(s) shall be same as Rated Home, including any dual-fuel equipment where applicable.

Checklist

Not all may apply:

  • OS-HPXML git subtree has been pulled
  • 301validator.xml has been updated (reference EPvalidator.xml)
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., rulesets\tests and/or workflow/tests/*_test.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results on CI

@bpark1327 bpark1327 added the bug label Apr 3, 2025
@bpark1327 bpark1327 self-assigned this Apr 3, 2025
@bpark1327 bpark1327 changed the title ENERGY STAR Update: Reference Design Fuel Type Bugfix ENERGY STAR Update: Reference Design HVAC Fuel Type Bugfix Apr 3, 2025
@bpark1327
Copy link
Collaborator Author

bpark1327 commented Apr 8, 2025

I tested with the base-hvac-dual-fuel-air-to-air-heat-pump-1-speed-lockout-temperatures model. After the bug fix, the ES Target Home now retains the dual-fuel heat pump system type from the Rated Home. The difference in the ERI scores before and after the bug fix is minimal. as shown below.

  before after
Reference Home ERI 52 52.11
SAF (Size Adjustment Factor) 1 1
SAF Adjusted ERI Target 52 52.11
     
Rated Home ERI 80.97 80.97
Rated Home ERI w/o OPP 80.97 80.97

@bpark1327

This comment was marked as resolved.

Copy link
Collaborator

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also check how this affects the original issue raised by BSI.

@bpark1327
Copy link
Collaborator Author

Let's also check how this affects the original issue raised by BSI.

Received two HPXML files from BSI.
269820-03-27-2025T10-03_28-ESReference-ERIRatedHome.xml.txt
269820-03-27-2025T10-03_28-ERIRatedHome.xml.txt

@bpark1327 bpark1327 marked this pull request as ready for review April 22, 2025 18:06
@bpark1327 bpark1327 requested a review from shorowit April 22, 2025 18:07
@bpark1327 bpark1327 changed the title ENERGY STAR Update: Reference Design HVAC Fuel Type Bugfix ZERH and ENERGY STAR Update: Reference Design HVAC Fuel Type Bugfix Apr 22, 2025
Copy link
Collaborator

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @bpark1327!

@shorowit shorowit merged commit 3cb486c into master Apr 24, 2025
@shorowit shorowit deleted the es_ref_design_dualfuel_bugfix branch April 24, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants