Skip to content

Conversation

rathod-b
Copy link
Collaborator

@rathod-b rathod-b commented Jun 3, 2025

No description provided.

gellwood and others added 11 commits May 22, 2025 08:57
Added results processing for TOU energy and demand charges
cleanup and handle energy storage tech
add support for tiered demand charges
debug failing tests
Add tiered rate support, add exports from techs of type elec, add energy and demand charge vectors, add support for BAU values for certain fields.
Clean up new outputs, add documentation.
@rathod-b
Copy link
Collaborator Author

rathod-b commented Jul 2, 2025

@Bill-Becker could you check out the results\electric_tariff.jl in this PR? I have added all outputs we have talked about till now and wanted to get your input on names and how we calculate these outputs at this time.

@rathod-b rathod-b requested review from Bill-Becker and gellwood July 2, 2025 21:43
@rathod-b rathod-b marked this pull request as ready for review July 2, 2025 21:44
Copy link
Collaborator

@Bill-Becker Bill-Becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know you have any questions on the comments, and if another meeting would be helpful after you look through them.

- `energy_charge_cost_matrix` matrix for cost of electricity (rows = cost for each timestep, columns = # of tiers)
- `facility_demand_charge_cost_matrix` matrix for facility demand charges (rows = months, columns = # of tiers)
- `utility_to_gross_loads_cost_series` timeseries of cost of gross electricity purchases (grid to load, grid to battery)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is just the energy charges, not demand charges, so I'm wondering how we can make this consistent with our current naming conventions while making it specific to energy. I think "utility" is too generic.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on other technologies (e.g. PV.electric_**to_grid**_series_kw) and other outputs of ElectricTariff (wholesale_electric_**to_grid**_series_kw), I think we should replace utility with grid. I know that we have a object called ElectricUtility, and that's why you used utility, but seems like we should just call it grid to be consistent.

Also, wondering about the need to include gross in the naming of e.g. to_gross_loads. I realize it's because it's both the "original" load plus the battery load, but I think that's inherently known that the load may include battery charging. On the flip side, if there is PV or other tech generating power, then these loads would actually be net of that generation, right? If so, I'd suggest just removing the _gross part.

- `_electric_to_grid_series_kw` exported electricity timeseries for type of export category
- `_monthly_export_series_kwh` monthly exported energy totals by export category
- `_monthly_export_cost_benefit` monthly export benefit by export category
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need "monthly_fixed_cost".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing monthly_fixed_cost still. I realize it is just the [year_one_fixed_cost_before_tax]*12, but I still think it's useful to have to avoid separate processing of the monthly costs (with energy and demand) to stack up bar charts for them.

Add fixed cost, energy costs and demand charges into the results dictionary
address more PR comments
Copy link
Collaborator

@Bill-Becker Bill-Becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just a couple more very minor re-naming suggestions. Otherwise it's approved. But let's wait to merge until we finish presenting reporting stuff to the ANCCR team in case they request anything we don't currently have here.

- `energy_charge_cost_matrix` matrix for cost of electricity (rows = cost for each timestep, columns = # of tiers)
- `facility_demand_charge_cost_matrix` matrix for facility demand charges (rows = months, columns = # of tiers)
- `utility_to_gross_loads_cost_series` timeseries of cost of gross electricity purchases (grid to load, grid to battery)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on other technologies (e.g. PV.electric_**to_grid**_series_kw) and other outputs of ElectricTariff (wholesale_electric_**to_grid**_series_kw), I think we should replace utility with grid. I know that we have a object called ElectricUtility, and that's why you used utility, but seems like we should just call it grid to be consistent.

Also, wondering about the need to include gross in the naming of e.g. to_gross_loads. I realize it's because it's both the "original" load plus the battery load, but I think that's inherently known that the load may include battery charging. On the flip side, if there is PV or other tech generating power, then these loads would actually be net of that generation, right? If so, I'd suggest just removing the _gross part.

- `_electric_to_grid_series_kw` exported electricity timeseries for type of export category
- `_monthly_export_series_kwh` monthly exported energy totals by export category
- `_monthly_export_cost_benefit` monthly export benefit by export category
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing monthly_fixed_cost still. I realize it is just the [year_one_fixed_cost_before_tax]*12, but I still think it's useful to have to avoid separate processing of the monthly costs (with energy and demand) to stack up bar charts for them.

Addressed comments, updated documentation and conducted testing
@rathod-b
Copy link
Collaborator Author

rathod-b commented Sep 8, 2025

Looks great. Just a couple more very minor re-naming suggestions. Otherwise it's approved. But let's wait to merge until we finish presenting reporting stuff to the ANCCR team in case they request anything we don't currently have here.

Thanks for your comments Bill, these have been addressed. I will begin the REopt API additions for these outputs so we can test the functionality in a feature branch of the API as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants