-
Notifications
You must be signed in to change notification settings - Fork 41
Access electric load and tariff metrics #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Added results processing for TOU energy and demand charges
cleanup and handle energy storage tech
add support for tiered demand charges
debug failing tests
Add tiered rate support, add exports from techs of type elec, add energy and demand charge vectors, add support for BAU values for certain fields.
Clean up new outputs, add documentation.
@Bill-Becker could you check out the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know you have any questions on the comments, and if another meeting would be helpful after you look through them.
src/results/electric_tariff.jl
Outdated
- `energy_charge_cost_matrix` matrix for cost of electricity (rows = cost for each timestep, columns = # of tiers) | ||
- `facility_demand_charge_cost_matrix` matrix for facility demand charges (rows = months, columns = # of tiers) | ||
- `utility_to_gross_loads_cost_series` timeseries of cost of gross electricity purchases (grid to load, grid to battery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this is just the energy charges, not demand charges, so I'm wondering how we can make this consistent with our current naming conventions while making it specific to energy. I think "utility" is too generic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on other technologies (e.g. PV.electric_**to_grid**_series_kw
) and other outputs of ElectricTariff (wholesale_electric_**to_grid**_series_kw
), I think we should replace utility
with grid
. I know that we have a object called ElectricUtility
, and that's why you used utility
, but seems like we should just call it grid
to be consistent.
Also, wondering about the need to include gross
in the naming of e.g. to_gross_loads
. I realize it's because it's both the "original" load plus the battery load, but I think that's inherently known that the load may include battery charging. On the flip side, if there is PV or other tech generating power, then these loads would actually be net of that generation, right? If so, I'd suggest just removing the _gross
part.
- `_electric_to_grid_series_kw` exported electricity timeseries for type of export category | ||
- `_monthly_export_series_kwh` monthly exported energy totals by export category | ||
- `_monthly_export_cost_benefit` monthly export benefit by export category | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need "monthly_fixed_cost".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing monthly_fixed_cost
still. I realize it is just the [year_one_fixed_cost_before_tax]*12
, but I still think it's useful to have to avoid separate processing of the monthly costs (with energy and demand) to stack up bar charts for them.
Add fixed cost, energy costs and demand charges into the results dictionary
address more PR comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Just a couple more very minor re-naming suggestions. Otherwise it's approved. But let's wait to merge until we finish presenting reporting stuff to the ANCCR team in case they request anything we don't currently have here.
src/results/electric_tariff.jl
Outdated
- `energy_charge_cost_matrix` matrix for cost of electricity (rows = cost for each timestep, columns = # of tiers) | ||
- `facility_demand_charge_cost_matrix` matrix for facility demand charges (rows = months, columns = # of tiers) | ||
- `utility_to_gross_loads_cost_series` timeseries of cost of gross electricity purchases (grid to load, grid to battery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on other technologies (e.g. PV.electric_**to_grid**_series_kw
) and other outputs of ElectricTariff (wholesale_electric_**to_grid**_series_kw
), I think we should replace utility
with grid
. I know that we have a object called ElectricUtility
, and that's why you used utility
, but seems like we should just call it grid
to be consistent.
Also, wondering about the need to include gross
in the naming of e.g. to_gross_loads
. I realize it's because it's both the "original" load plus the battery load, but I think that's inherently known that the load may include battery charging. On the flip side, if there is PV or other tech generating power, then these loads would actually be net of that generation, right? If so, I'd suggest just removing the _gross
part.
- `_electric_to_grid_series_kw` exported electricity timeseries for type of export category | ||
- `_monthly_export_series_kwh` monthly exported energy totals by export category | ||
- `_monthly_export_cost_benefit` monthly export benefit by export category | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing monthly_fixed_cost
still. I realize it is just the [year_one_fixed_cost_before_tax]*12
, but I still think it's useful to have to avoid separate processing of the monthly costs (with energy and demand) to stack up bar charts for them.
Addressed comments, updated documentation and conducted testing
Thanks for your comments Bill, these have been addressed. I will begin the REopt API additions for these outputs so we can test the functionality in a feature branch of the API as well. |
No description provided.